| Message ID | 20230418-dpu-drop-useless-for-lookup-v3-0-e8d869eea455@somainline.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/msm/dpu: Drop useless for-loop HW block lookup | expand |
On Wed, 26 Apr 2023 01:11:08 +0200, Marijn Suijten wrote: > Doing a for loop in every DPU HW block driver init to find a catalog > entry matching the given ID is rather useless if the init function > called by RM already has that catalog entry pointer, and uses exactly > its ID to drive this init and for loop. Remove all that machinery to > drop quite some lines of unnecessarily-complicated code, and the > fallibility that comes with it, by simply giving _init() the catalog > entry pointers straight away. > > [...] Applied, thanks! [1/3] drm/msm/dpu: Assign missing writeback log_mask https://gitlab.freedesktop.org/abhinavk/msm/-/commit/a432fc31f03d Best regards,
Doing a for loop in every DPU HW block driver init to find a catalog entry matching the given ID is rather useless if the init function called by RM already has that catalog entry pointer, and uses exactly its ID to drive this init and for loop. Remove all that machinery to drop quite some lines of unnecessarily-complicated code, and the fallibility that comes with it, by simply giving _init() the catalog entry pointers straight away. Also clean up some unused struct members, and assign a log_mask for WB. --- Changes in v3: - Return NULL from dpu_hw_intf_init() on INTF_NONE, and omit identical check in dpu_rm_init(); - Retitle patch 3/3. v2: https://lore.kernel.org/r/20230418-dpu-drop-useless-for-lookup-v2-0-acb08e82ef19@somainline.org Changes in v2: - Replace "sysfs" with "debugfs" in patch 2/3 description; - Reorder WB log_mask fix as patch 1; - Drop Fixes: tags from "unused struct members removal"; - Replace dpu_mdss_cfg parameter in dpu_hw_sspp_init() with immediate dpu_ubwc_cfg pointer; - Replace dpu_mdss_cfg parameter in dpu_hw_ctl_init() with immediate dpu_lm_cfg array pointer. v1: https://lore.kernel.org/r/20230418-dpu-drop-useless-for-lookup-v1-0-b9897ceb6f3e@somainline.org --- Marijn Suijten (3): drm/msm/dpu: Assign missing writeback log_mask drm/msm/dpu: Drop unused members from HW structs drm/msm/dpu: Pass catalog pointers in RM to replace for-loop ID lookups drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 37 +++++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.h | 14 ++++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 32 +++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 11 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.c | 38 ++++----------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dspp.h | 12 +++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 41 ++++++----------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 13 +++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 38 ++++----------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.h | 10 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_merge3d.c | 33 +++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_merge3d.h | 14 ++++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.c | 33 +++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_pingpong.h | 14 ++++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 40 ++++------------------ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 14 ++++---- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.c | 33 +++--------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_vbif.h | 11 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.c | 33 ++++-------------- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_wb.h | 16 +++------ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 17 +++++----- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 22 +++++------- 23 files changed, 139 insertions(+), 389 deletions(-) --- base-commit: f600e0bbde8562a06bee31b3eb1b69d49acac4c5 change-id: 20230418-dpu-drop-useless-for-lookup-488700c7a469 Best regards,