[0/2] PCI: qcom: Enable ASPM on host bridge and devices

Message

Manivannan Sadhasivam Aug. 9, 2023, 8:18 a.m. UTC

Hi,

This series enables ASPM by default on the host bridge and devices of selected
Qcom platforms.

The motivation behind enabling ASPM in the controller driver is provided in the
commit message of patch 2/2.

This series has been tested on SC8280-CRD and Lenovo Thinkpad X13s laptop
and it helped save ~0.6W of power during runtime.

- Mani

Manivannan Sadhasivam (2):
  PCI: dwc: Add host_post_init() callback
  PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops

 .../pci/controller/dwc/pcie-designware-host.c |  3 ++
 drivers/pci/controller/dwc/pcie-designware.h  |  1 +
 drivers/pci/controller/dwc/pcie-qcom.c        | 28 +++++++++++++++++++
 3 files changed, 32 insertions(+)

Comments

Steev Klimaszewski Aug. 10, 2023, 3:33 a.m. UTC | #1

On Wed, Aug 9, 2023 at 3:19 AM Manivannan Sadhasivam
<[e-mail]> wrote:
>
> Hi,
>
> This series enables ASPM by default on the host bridge and devices of selected
> Qcom platforms.
>
> The motivation behind enabling ASPM in the controller driver is provided in the
> commit message of patch 2/2.
>
> This series has been tested on SC8280-CRD and Lenovo Thinkpad X13s laptop
> and it helped save ~0.6W of power during runtime.
>
> - Mani
>
> Manivannan Sadhasivam (2):
>   PCI: dwc: Add host_post_init() callback
>   PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops
>
>  .../pci/controller/dwc/pcie-designware-host.c |  3 ++
>  drivers/pci/controller/dwc/pcie-designware.h  |  1 +
>  drivers/pci/controller/dwc/pcie-qcom.c        | 28 +++++++++++++++++++
>  3 files changed, 32 insertions(+)
>
> --
> 2.25.1
>
While not extremely scientific, and I don't have any way to measure
the power usage on my Thinkpad X13s, with these patches applied, I've
only gone down 29% battery power in the past 6 hours, suspend and
resume cycles don't see any issues either.

Tested-by: Steev Klimaszewski <[e-mail]>