| Message ID | 20230822-add-widebus-support-v4-0-9dc86083d6ea@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/msm: Enable widebus for DSI | expand |
On Tue, 22 Aug 2023 10:42:03 -0700, Jessica Zhang wrote: > DSI 6G v2.5.x+ and DPU support a data-bus widen mode that allows DSI > to send 48 bits of compressed data per pclk instead of 24. > > For all chipsets that support this mode, enable it whenever DSC is > enabled as recommended by the hardware programming guide. > > Only enable this for command mode as we are currently unable to validate > widebus for video mode. > > [...] Applied, thanks! [1/4] drm/msm/dpu: Move setting of dpu_enc::wide_bus_en to atomic enable() https://gitlab.freedesktop.org/lumag/msm/-/commit/97aab03bb3fa [2/4] drm/msm/dpu: Enable widebus for DSI INTF https://gitlab.freedesktop.org/lumag/msm/-/commit/c9b7bae463bb [3/4] drm/msm/dsi: Add DATABUS_WIDEN MDP_CTRL2 bit https://gitlab.freedesktop.org/lumag/msm/-/commit/5467774e55fb [4/4] drm/msm/dsi: Enable widebus for DSI https://gitlab.freedesktop.org/lumag/msm/-/commit/4b90679c6864 Best regards,
DSI 6G v2.5.x+ and DPU support a data-bus widen mode that allows DSI to send 48 bits of compressed data per pclk instead of 24. For all chipsets that support this mode, enable it whenever DSC is enabled as recommended by the hardware programming guide. Only enable this for command mode as we are currently unable to validate widebus for video mode. Note: The dsi.xml.h changes were generated using the headergen2 script in envytools [2], but the changes to the copyright and rules-ng-ng source file paths were dropped. [1] https://patchwork.freedesktop.org/series/121742/ [2] https://github.com/freedreno/envytools/ -- Changes in v4: - *_widebus_* -> *_wide_bus_* (Marijn) - Moved dpu_enc::wide_bus setting to outside of DSC check (Dmitry) - Switched order of dpu_enc::widebus setting (Dmitry) - Added note about INTF_CONFIG2 being present for DPU 5.0+ (Dmitry) - Added method stub for msm_dsi_is_widebus_enabled() as to not break compilation (Dmitry) - Whitespace and formatting fixes (Dmitry) - Edited commit msg for "Move DPU encoder wide_bus_en setting" for clarity (Dmitry, Marijn) - Dropped redundant initialization of disp_info - Picked up reviewed-by tags - Link to v3: https://lore.kernel.org/r/20230802-add-widebus-support-v3-0-2661706be001@quicinc.com Changes in v3: - Split commit into DPU, dsi.xml.h, and DSI changes (Dmitry) - Add DSC enabled check to DSI *_is_widebus_enabled() helper (Dmitry) - Dropped mention of DPU in cover letter title - Moved setting of dpu_enc->wide_bus_en to dpu_encoder_virt_atomic_enable() - Link to v2: https://lore.kernel.org/r/20230713-add-widebus-support-v2-1-ad0added17b6@quicinc.com Changes in v2: - Rebased on top of "drm/msm/dpu: Re-introduce dpu core revision" - Squashed all commits to avoid breaking feature if the series is only partially applied - Moved DATABUS_WIDEN bit setting to dsi_ctr_enable() (Marijn) - Have DPU check if wide bus is requested by output driver (Dmitry) - Introduced bytes_per_pclk variable for dsi_timing_setup() hdisplay adjustment (Marijn) - Link to v1: https://lore.kernel.org/r/20230525-add-widebus-support-v1-0-c7069f2efca1@quicinc.com --- Jessica Zhang (4): drm/msm/dpu: Move setting of dpu_enc::wide_bus_en to atomic enable() drm/msm/dpu: Enable widebus for DSI INTF drm/msm/dsi: Add DATABUS_WIDEN MDP_CTRL2 bit drm/msm/dsi: Enable widebus for DSI drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 14 +++++++--- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 ++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 7 +++++ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.h | 1 + drivers/gpu/drm/msm/dsi/dsi.c | 5 ++++ drivers/gpu/drm/msm/dsi/dsi.h | 1 + drivers/gpu/drm/msm/dsi/dsi.xml.h | 1 + drivers/gpu/drm/msm/dsi/dsi_host.c | 31 +++++++++++++++++++--- drivers/gpu/drm/msm/msm_drv.h | 5 ++++ 9 files changed, 59 insertions(+), 8 deletions(-) --- base-commit: 00ee72279c963989ab435b0bc90b5dc05a9aab79 change-id: 20230525-add-widebus-support-f785546ee751 Best regards,