[net-next,v2,0/2] net: phy: qcom: qca808x: fill in possible_interfaces

Message

Robert Marko Feb. 28, 2024, 5:24 p.m. UTC

QCA808x does not currently fill in the possible_interfaces.

This leads to Phylink not being aware that it supports 2500Base-X as well
so in cases where it is connected to a DSA switch like MV88E6393 it will
limit that port to phy-mode set in the DTS.

That means that if SGMII is used you are limited to 1G only while if
2500Base-X was set you are limited to 2.5G only.

Populating the possible_interfaces fixes this.

Changes in v2:
* Get rid of the if/else by Russels suggestion in the helper

Robert Marko (2):
  net: phy: qcom: qca808x: add helper for checking for 1G only model
  net: phy: qcom: qca808x: fill in possible_interfaces

 drivers/net/phy/qcom/qca808x.c | 29 ++++++++++++++++++++++++-----
 1 file changed, 24 insertions(+), 5 deletions(-)

Comments

[e-mail] March 1, 2024, 9 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <[e-mail]>:

On Wed, 28 Feb 2024 18:24:08 +0100 you wrote:
> QCA808x does not currently fill in the possible_interfaces.
> 
> This leads to Phylink not being aware that it supports 2500Base-X as well
> so in cases where it is connected to a DSA switch like MV88E6393 it will
> limit that port to phy-mode set in the DTS.
> 
> That means that if SGMII is used you are limited to 1G only while if
> 2500Base-X was set you are limited to 2.5G only.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/2] net: phy: qcom: qca808x: add helper for checking for 1G only model
    https://git.kernel.org/netdev/net-next/c/f058b2dd70b1
  - [net-next,v2,2/2] net: phy: qcom: qca808x: fill in possible_interfaces
    https://git.kernel.org/netdev/net-next/c/cb28f7029606

You are awesome, thank you!