[net-next,v2,0/7] net: ipa: simplify device pointer access

Message

Alex Elder March 1, 2024, 5:02 p.m. UTC

This version of this patch series fixes the bugs in the first patch
(which were fixed in the second), where ipa_interrupt_config() had
two remaining spots that returned a pointer rather than an integer.

Outside of initialization, all uses of the platform device pointer
stored in the IPA structure determine the address of device
structure embedded within the platform device structure.

By changing some of the initialization functions to take a platform
device as argument we can simplify getting at the device structure
address by storing it (instead of the platform device pointer) in
the IPA structure.

The first two patches split the interrupt initialization code into
two parts--one done earlier than before.  The next four patches
update some initialization functions to take a platform device
pointer as argument.  And the last patch replaces the platform
device pointer with a device pointer, and converts all remaining
references to the &ipa->pdev->dev to use ipa->dev.

					-Alex

Alex Elder (7):
  net: ipa: change ipa_interrupt_config() prototype
  net: ipa: introduce ipa_interrupt_init()
  net: ipa: pass a platform device to ipa_reg_init()
  net: ipa: pass a platform device to ipa_mem_init()
  net: ipa: pass a platform device to ipa_smp2p_irq_init()
  net: ipa: pass a platform device to ipa_smp2p_init()
  net: ipa: don't save the platform device

 drivers/net/ipa/ipa.h           |  5 +--
 drivers/net/ipa/ipa_cmd.c       |  6 +--
 drivers/net/ipa/ipa_endpoint.c  | 29 +++++++-------
 drivers/net/ipa/ipa_interrupt.c | 69 +++++++++++++++++++++------------
 drivers/net/ipa/ipa_interrupt.h | 22 +++++++++--
 drivers/net/ipa/ipa_main.c      | 60 +++++++++++++++++-----------
 drivers/net/ipa/ipa_mem.c       | 37 +++++++++---------
 drivers/net/ipa/ipa_mem.h       |  5 ++-
 drivers/net/ipa/ipa_modem.c     | 14 +++----
 drivers/net/ipa/ipa_power.c     |  4 +-
 drivers/net/ipa/ipa_qmi.c       | 10 ++---
 drivers/net/ipa/ipa_reg.c       |  8 ++--
 drivers/net/ipa/ipa_reg.h       |  4 +-
 drivers/net/ipa/ipa_smp2p.c     | 33 ++++++++--------
 drivers/net/ipa/ipa_smp2p.h     |  7 +++-
 drivers/net/ipa/ipa_table.c     | 18 ++++-----
 drivers/net/ipa/ipa_uc.c        |  9 ++---
 17 files changed, 197 insertions(+), 143 deletions(-)

Comments

[e-mail] March 4, 2024, 11:50 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <[e-mail]>:

On Fri,  1 Mar 2024 11:02:35 -0600 you wrote:
> This version of this patch series fixes the bugs in the first patch
> (which were fixed in the second), where ipa_interrupt_config() had
> two remaining spots that returned a pointer rather than an integer.
> 
> Outside of initialization, all uses of the platform device pointer
> stored in the IPA structure determine the address of device
> structure embedded within the platform device structure.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/7] net: ipa: change ipa_interrupt_config() prototype
    https://git.kernel.org/netdev/net-next/c/e87e4371edfc
  - [net-next,v2,2/7] net: ipa: introduce ipa_interrupt_init()
    https://git.kernel.org/netdev/net-next/c/ad1be80d7582
  - [net-next,v2,3/7] net: ipa: pass a platform device to ipa_reg_init()
    https://git.kernel.org/netdev/net-next/c/a47956e72a3e
  - [net-next,v2,4/7] net: ipa: pass a platform device to ipa_mem_init()
    https://git.kernel.org/netdev/net-next/c/95c54a963b24
  - [net-next,v2,5/7] net: ipa: pass a platform device to ipa_smp2p_irq_init()
    https://git.kernel.org/netdev/net-next/c/59622a8fb453
  - [net-next,v2,6/7] net: ipa: pass a platform device to ipa_smp2p_init()
    https://git.kernel.org/netdev/net-next/c/81d65f3413da
  - [net-next,v2,7/7] net: ipa: don't save the platform device
    https://git.kernel.org/netdev/net-next/c/5245f4fd28d1

You are awesome, thank you!