| Message ID | 20240510-topic-msm-polling-cleanup-v2-0-436ca4218da2@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Clean up thermal zone polling-delay | expand |
On 10/05/2024 12:59, Konrad Dybcio wrote: > A trivial follow-up on the changes introduced in Commit 488164006a28 > ("thermal/of: Assume polling-delay(-passive) 0 when absent"). > > Should probably wait until v6.9-rc1 so that the patch in question is > in the base tree, otherwise TZs will fail to register. > > FWIW, Compile-tested only (except 8280). > > To: Bjorn Andersson <andersson@kernel.org> > To: Rob Herring <robh@kernel.org> > To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > To: Conor Dooley <conor+dt@kernel.org> > To: cros-qcom-dts-watchers@chromium.org > To: Krzysztof Kozlowski <krzk+dt@kernel.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > > Changes in v2: > - Un-drop passive delays. Whether they're useful where they're enabled > is a topic for another patchset, as it requires examination on a case- > -by-case basis. > - Better unify the style (newlines between properties) > - Link to v1: https://lore.kernel.org/r/20240319-topic-msm-polling-cleanup-v1-0-e0aee1dbcd78@linaro.org So perhaps you can answer the question I have. Right now, we have non-zero delay values, doesn't this mean the thermal framework driver has a delay between evaluating dT/dt values per Documentation/devicetree/bindings/thermal/thermal-zones.yaml Your commit log implies or my reading of it is, there's no functional change because its currently driven by an IRQ but, is that actually _so_ with non-zero values in the DT? --- bod
On 10.05.2024 2:49 PM, Bryan O'Donoghue wrote: > On 10/05/2024 12:59, Konrad Dybcio wrote: >> A trivial follow-up on the changes introduced in Commit 488164006a28 >> ("thermal/of: Assume polling-delay(-passive) 0 when absent"). >> >> Should probably wait until v6.9-rc1 so that the patch in question is >> in the base tree, otherwise TZs will fail to register. >> >> FWIW, Compile-tested only (except 8280). >> >> To: Bjorn Andersson <andersson@kernel.org> >> To: Rob Herring <robh@kernel.org> >> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> >> To: Conor Dooley <conor+dt@kernel.org> >> To: cros-qcom-dts-watchers@chromium.org >> To: Krzysztof Kozlowski <krzk+dt@kernel.org> >> Cc: linux-arm-msm@vger.kernel.org >> Cc: devicetree@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> >> Changes in v2: >> - Un-drop passive delays. Whether they're useful where they're enabled >> is a topic for another patchset, as it requires examination on a case- >> -by-case basis. >> - Better unify the style (newlines between properties) >> - Link to v1: https://lore.kernel.org/r/20240319-topic-msm-polling-cleanup-v1-0-e0aee1dbcd78@linaro.org > > So perhaps you can answer the question I have. > > Right now, we have non-zero delay values, doesn't this mean the thermal framework driver has a delay between evaluating dT/dt values per > > Documentation/devicetree/bindings/thermal/thermal-zones.yaml > > Your commit log implies or my reading of it is, there's no functional change because its currently driven by an IRQ but, is that actually _so_ with non-zero values in the DT? Yes, tsens irq fires a threshold change notification down the thermal framework Konrad
On Fri, 10 May 2024 13:59:23 +0200, Konrad Dybcio wrote: > A trivial follow-up on the changes introduced in Commit 488164006a28 > ("thermal/of: Assume polling-delay(-passive) 0 when absent"). > > Should probably wait until v6.9-rc1 so that the patch in question is > in the base tree, otherwise TZs will fail to register. > > FWIW, Compile-tested only (except 8280). > > [...] Applied, thanks! [01/31] arm64: dts: qcom: ipq6018-*: Remove thermal zone polling delays commit: 28930820bf8928c8247d6b001e042ce7e0037350 [02/31] arm64: dts: qcom: ipq8074-*: Remove thermal zone polling delays commit: bebd3c6476c97d0aee8985eb9544dfd82f6e8e36 [03/31] arm64: dts: qcom: ipq9574-*: Remove thermal zone polling delays commit: 88dd10e237ee1cfc70595c0feb37c8a71e521bfc [04/31] arm64: dts: qcom: msm8916-*: Remove thermal zone polling delays commit: b3f0d522b548e969b138c48c0fd4098703363c53 [05/31] arm64: dts: qcom: msm8939-*: Remove thermal zone polling delays commit: 19c658e5bfe71b01ae41e85dab076da051814857 [06/31] arm64: dts: qcom: msm8953-*: Remove thermal zone polling delays commit: 1a43ff5b5f5a51c2dd0859bc46020e7f1c282414 [07/31] arm64: dts: qcom: msm8976-*: Remove thermal zone polling delays commit: adfb64b78f2f0e894c2520b8e2ff8bd5f2d49825 [08/31] arm64: dts: qcom: msm8996-*: Remove thermal zone polling delays commit: 612f017315fb466bc9348fb9a5f1d9506f4b5260 [09/31] arm64: dts: qcom: msm8998-*: Remove thermal zone polling delays commit: 47d92455f59f7e8414ebc962f60bd7a990563a7c [10/31] arm64: dts: qcom: pm7550ba: Remove thermal zone polling delays commit: d96854de5d69a08a893d4a137d69c65f2feb40d5 [11/31] arm64: dts: qcom: pms405: Remove thermal zone polling delays commit: 1a78b5da8164afc1d60bec7c02b8fd8e6451f0f3 [12/31] arm64: dts: qcom: pmx75: Remove thermal zone polling delays commit: 8e49df9200591c469dfbdd29c93ee6cbe970aa2a [13/31] arm64: dts: qcom: qcm2290-*: Remove thermal zone polling delays commit: d3eb8179f21f86439053745bb1504791236d38bf [14/31] arm64: dts: qcom: qcs404-*: Remove thermal zone polling delays commit: 8d7807d24746af11ba966bce854ef3cd8df5267e [15/31] arm64: dts: qcom: sa8775p-*: Remove thermal zone polling delays commit: a759962163af22b7f50c8f43ed8b3fc5e09bec19 [16/31] arm64: dts: qcom: sc7180-*: Remove thermal zone polling delays commit: 7cd2d9080a6eb281701f7303b1699719640380d0 [17/31] arm64: dts: qcom: sc7280-*: Remove thermal zone polling delays commit: 7747a49db7e54978151d74b22907a373c9b4de1b [18/31] arm64: dts: qcom: sc8180x-*: Remove thermal zone polling delays commit: 1f57b1cff485c02678ea2dfe0ff7efa3b9f51e9d [19/31] arm64: dts: qcom: sc8280xp-*: Remove thermal zone polling delays commit: e388421387e8b1b51c507883aaf13f40277fe137 [20/31] arm64: dts: qcom: sdm660-*: Remove thermal zone polling delays commit: 82162bf535a76f87e20a6eece83375d2dd791655 [21/31] arm64: dts: qcom: sdm845-*: Remove thermal zone polling delays commit: 2e58dbeae40e5fc7b2742bed05957cae32031387 [22/31] arm64: dts: qcom: sm6115-*: Remove thermal zone polling delays commit: 190f743561a44cf0176707b6e2f37b1a1b7ff367 [23/31] arm64: dts: qcom: sm6125-*: Remove thermal zone polling delays commit: d1a12560ef38021ce42ac31408fc53d2b8e08cc8 [24/31] arm64: dts: qcom: sm6350-*: Remove thermal zone polling delays commit: 2aad3fd3820d047fa70b62906565c185d830465c [25/31] arm64: dts: qcom: sm6375-*: Remove thermal zone polling delays commit: 088d826d5af3cda20deb04dce406c95ef1ed8563 [26/31] arm64: dts: qcom: sm8150-*: Remove thermal zone polling delays commit: fc2f92b522019a5bfd464c946b15d180c31b092b [27/31] arm64: dts: qcom: sm8250-*: Remove thermal zone polling delays commit: 2d10e2e28df7a690d670b3452d4891b50011dc42 [28/31] arm64: dts: qcom: sm8350-*: Remove thermal zone polling delays commit: 07fab48327ad0d85c2b2763d26ce56c84043515a [29/31] arm64: dts: qcom: sm8450-*: Remove thermal zone polling delays commit: d0730a729f1a723f06e7b9db7f1a540cf72de871 [30/31] arm64: dts: qcom: sm8550-*: Remove thermal zone polling delays commit: fe5cb7d30795d81ed55888bcfb896086af3adc01 [31/31] arm64: dts: qcom: sm8650-*: Remove thermal zone polling delays commit: 92332cca0551b7c5c44f4236b8d1ce2828888e92 Best regards,
A trivial follow-up on the changes introduced in Commit 488164006a28 ("thermal/of: Assume polling-delay(-passive) 0 when absent"). Should probably wait until v6.9-rc1 so that the patch in question is in the base tree, otherwise TZs will fail to register. FWIW, Compile-tested only (except 8280). To: Bjorn Andersson <andersson@kernel.org> To: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> To: Conor Dooley <conor+dt@kernel.org> To: cros-qcom-dts-watchers@chromium.org To: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: linux-arm-msm@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Changes in v2: - Un-drop passive delays. Whether they're useful where they're enabled is a topic for another patchset, as it requires examination on a case- -by-case basis. - Better unify the style (newlines between properties) - Link to v1: https://lore.kernel.org/r/20240319-topic-msm-polling-cleanup-v1-0-e0aee1dbcd78@linaro.org --- Konrad Dybcio (31): arm64: dts: qcom: ipq6018-*: Remove thermal zone polling delays arm64: dts: qcom: ipq8074-*: Remove thermal zone polling delays arm64: dts: qcom: ipq9574-*: Remove thermal zone polling delays arm64: dts: qcom: msm8916-*: Remove thermal zone polling delays arm64: dts: qcom: msm8939-*: Remove thermal zone polling delays arm64: dts: qcom: msm8953-*: Remove thermal zone polling delays arm64: dts: qcom: msm8976-*: Remove thermal zone polling delays arm64: dts: qcom: msm8996-*: Remove thermal zone polling delays arm64: dts: qcom: msm8998-*: Remove thermal zone polling delays arm64: dts: qcom: pm7550ba: Remove thermal zone polling delays arm64: dts: qcom: pms405: Remove thermal zone polling delays arm64: dts: qcom: pmx75: Remove thermal zone polling delays arm64: dts: qcom: qcm2290-*: Remove thermal zone polling delays arm64: dts: qcom: qcs404-*: Remove thermal zone polling delays arm64: dts: qcom: sa8775p-*: Remove thermal zone polling delays arm64: dts: qcom: sc7180-*: Remove thermal zone polling delays arm64: dts: qcom: sc7280-*: Remove thermal zone polling delays arm64: dts: qcom: sc8180x-*: Remove thermal zone polling delays arm64: dts: qcom: sc8280xp-*: Remove thermal zone polling delays arm64: dts: qcom: sdm660-*: Remove thermal zone polling delays arm64: dts: qcom: sdm845-*: Remove thermal zone polling delays arm64: dts: qcom: sm6115-*: Remove thermal zone polling delays arm64: dts: qcom: sm6125-*: Remove thermal zone polling delays arm64: dts: qcom: sm6350-*: Remove thermal zone polling delays arm64: dts: qcom: sm6375-*: Remove thermal zone polling delays arm64: dts: qcom: sm8150-*: Remove thermal zone polling delays arm64: dts: qcom: sm8250-*: Remove thermal zone polling delays arm64: dts: qcom: sm8350-*: Remove thermal zone polling delays arm64: dts: qcom: sm8450-*: Remove thermal zone polling delays arm64: dts: qcom: sm8550-*: Remove thermal zone polling delays arm64: dts: qcom: sm8650-*: Remove thermal zone polling delays arch/arm64/boot/dts/qcom/ipq6018.dtsi | 6 -- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 12 --- arch/arm64/boot/dts/qcom/ipq9574.dtsi | 26 ------- arch/arm64/boot/dts/qcom/msm8916.dtsi | 5 -- arch/arm64/boot/dts/qcom/msm8939.dtsi | 9 --- arch/arm64/boot/dts/qcom/msm8953.dtsi | 17 ++--- arch/arm64/boot/dts/qcom/msm8976.dtsi | 18 ++--- arch/arm64/boot/dts/qcom/msm8996.dtsi | 14 ---- arch/arm64/boot/dts/qcom/msm8998.dtsi | 19 ----- arch/arm64/boot/dts/qcom/pm6125.dtsi | 1 - arch/arm64/boot/dts/qcom/pm6150.dtsi | 2 +- arch/arm64/boot/dts/qcom/pm6150l.dtsi | 3 - arch/arm64/boot/dts/qcom/pm6350.dtsi | 1 - arch/arm64/boot/dts/qcom/pm660.dtsi | 1 - arch/arm64/boot/dts/qcom/pm660l.dtsi | 1 - arch/arm64/boot/dts/qcom/pm7250b.dtsi | 1 - arch/arm64/boot/dts/qcom/pm7325.dtsi | 2 +- arch/arm64/boot/dts/qcom/pm7550ba.dtsi | 1 - arch/arm64/boot/dts/qcom/pm8010.dtsi | 2 - arch/arm64/boot/dts/qcom/pm8150.dtsi | 1 - arch/arm64/boot/dts/qcom/pm8150b.dtsi | 1 - arch/arm64/boot/dts/qcom/pm8150l.dtsi | 1 - arch/arm64/boot/dts/qcom/pm8350.dtsi | 2 +- arch/arm64/boot/dts/qcom/pm8350b.dtsi | 2 +- arch/arm64/boot/dts/qcom/pm8350c.dtsi | 2 +- arch/arm64/boot/dts/qcom/pm8450.dtsi | 1 - arch/arm64/boot/dts/qcom/pm8550.dtsi | 1 - arch/arm64/boot/dts/qcom/pm8550b.dtsi | 1 - arch/arm64/boot/dts/qcom/pm8550ve.dtsi | 1 - arch/arm64/boot/dts/qcom/pm8550vs.dtsi | 4 - arch/arm64/boot/dts/qcom/pm8953.dtsi | 3 - arch/arm64/boot/dts/qcom/pm8994.dtsi | 1 - arch/arm64/boot/dts/qcom/pm8998.dtsi | 1 - arch/arm64/boot/dts/qcom/pmi632.dtsi | 1 - arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi | 1 - arch/arm64/boot/dts/qcom/pmm8155au_2.dtsi | 1 - arch/arm64/boot/dts/qcom/pmr735a.dtsi | 2 +- arch/arm64/boot/dts/qcom/pmr735b.dtsi | 2 +- arch/arm64/boot/dts/qcom/pmr735d_a.dtsi | 1 - arch/arm64/boot/dts/qcom/pmr735d_b.dtsi | 1 - arch/arm64/boot/dts/qcom/pms405.dtsi | 1 - arch/arm64/boot/dts/qcom/pmx75.dtsi | 1 - arch/arm64/boot/dts/qcom/qcm2290.dtsi | 30 -------- arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 14 ++-- arch/arm64/boot/dts/qcom/qcs404.dtsi | 10 --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 10 --- arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 8 +- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 82 -------------------- .../arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 1 - .../boot/dts/qcom/sc7180-trogdor-homestar.dtsi | 1 - .../arm64/boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 3 - .../boot/dts/qcom/sc7180-trogdor-wormdingler.dtsi | 1 - arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 - arch/arm64/boot/dts/qcom/sc7180.dtsi | 25 ------ arch/arm64/boot/dts/qcom/sc7280.dtsi | 45 ----------- arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi | 2 - arch/arm64/boot/dts/qcom/sc8180x.dtsi | 26 ------- .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 +- arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 4 +- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 13 ---- arch/arm64/boot/dts/qcom/sdm630.dtsi | 9 --- arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 12 --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 21 ------ arch/arm64/boot/dts/qcom/sm6115.dtsi | 32 -------- .../dts/qcom/sm6125-sony-xperia-seine-pdx201.dts | 8 -- .../boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts | 6 -- arch/arm64/boot/dts/qcom/sm6350.dtsi | 81 -------------------- arch/arm64/boot/dts/qcom/sm6375.dtsi | 78 ------------------- arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 4 - arch/arm64/boot/dts/qcom/sm8150.dtsi | 28 ------- arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 14 ---- arch/arm64/boot/dts/qcom/sm8250.dtsi | 25 ------ arch/arm64/boot/dts/qcom/sm8350.dtsi | 29 ------- arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 16 ++-- arch/arm64/boot/dts/qcom/sm8450.dtsi | 64 ++-------------- arch/arm64/boot/dts/qcom/sm8550.dtsi | 82 ++++---------------- arch/arm64/boot/dts/qcom/sm8650.dtsi | 88 ++++------------------ 77 files changed, 78 insertions(+), 973 deletions(-) --- base-commit: 704ba27ac55579704ba1289392448b0c66b56258 change-id: 20240319-topic-msm-polling-cleanup-2616a8bece70 Best regards,