mbox series

[v4,00/11] Add missing features to FastRPC driver

Message ID 20240606165939.12950-1-quic_ekangupt@quicinc.com (mailing list archive)
Headers show
Series Add missing features to FastRPC driver | expand

Message

Ekansh Gupta June 6, 2024, 4:59 p.m. UTC 
This patch series adds the listed features that have been missing
in upstream fastRPC driver.
- Add missing bug fixes.
- Add static PD restart support for audio and sensors PD using
  PDR framework.
- Redesign and improve remote heap management.
- Add fixes for unsigned PD. Unsigned PD can be enabled
  using userspace API:
  https://git.codelinaro.org/linaro/qcomlt/fastrpc/-/blob/master/src/fastrpc_apps_user.c?ref_type=heads#L1173

Changes in v2:
- Added separate patch to add newlines in dev_err.
- Added a bug fix in fastrpc capability function.
- Added a new patch to save and restore interrupted context.
- Fixed config dependency for PDR support.

Changes in v3:
- Dropped interrupted context patch.
- Splitted few of the bug fix patches.
- Added Fixes tag wherever applicable.
- Updated proper commit message for few of the patches.

Changes in v4:
- Dropped untrusted process and system unsigned PD patches.
- Updated proper commit message for few of the patches.
- Splitted patches in more meaningful way.
- Added helped functions for fastrpc_req_mmap.

Ekansh Gupta (11):
  misc: fastrpc: Add missing dev_err newlines
  misc: fastrpc: Fix DSP capabilities request
  misc: fastrpc: Copy the complete capability structure to user
  misc: fastrpc: Avoid updating PD type for capability request
  misc: fastrpc: Add static PD restart support
  misc: fastrpc: Fix memory leak in audio daemon attach operation
  misc: fastrpc: Redesign remote heap management
  misc: fastrpc: Fix ownership reassignment of remote heap
  misc: fastrpc: Fix remote heap alloc and free user request
  misc: fastrpc: Fix unsigned PD support
  misc: fastrpc: Restrict untrusted app to attach to privileged PD

 drivers/misc/Kconfig        |   2 +
 drivers/misc/fastrpc.c      | 635 +++++++++++++++++++++++++++++-------
 include/uapi/misc/fastrpc.h |   3 +
 3 files changed, 527 insertions(+), 113 deletions(-)

Comments

Dmitry Baryshkov June 7, 2024, 11:50 a.m. UTC | #1 
On Thu, Jun 06, 2024 at 10:29:20PM +0530, Ekansh Gupta wrote:
> This patch series adds the listed features that have been missing
> in upstream fastRPC driver.
> - Add missing bug fixes.
> - Add static PD restart support for audio and sensors PD using
>   PDR framework.
> - Redesign and improve remote heap management.
> - Add fixes for unsigned PD. Unsigned PD can be enabled
>   using userspace API:
>   https://git.codelinaro.org/linaro/qcomlt/fastrpc/-/blob/master/src/fastrpc_apps_user.c?ref_type=heads#L1173
> 
> Changes in v2:
> - Added separate patch to add newlines in dev_err.
> - Added a bug fix in fastrpc capability function.
> - Added a new patch to save and restore interrupted context.
> - Fixed config dependency for PDR support.
> 
> Changes in v3:
> - Dropped interrupted context patch.
> - Splitted few of the bug fix patches.
> - Added Fixes tag wherever applicable.
> - Updated proper commit message for few of the patches.
> 
> Changes in v4:
> - Dropped untrusted process and system unsigned PD patches.
> - Updated proper commit message for few of the patches.
> - Splitted patches in more meaningful way.
> - Added helped functions for fastrpc_req_mmap.
> 

I'd suggest to land patches 1-4, they seem to be fine.

The rest of the series needs more rework. Please start by reordering the
patches, so that fixes come first. Think about the people who will
backport them to earlier kernels.