mbox series

[v3,0/5] phy: qcom: qmp-pcie: drop second clock-output-names entry

Message ID 20240614-fix-pcie-phy-compat-v3-0-730d1811acf4@linaro.org (mailing list archive)
Headers show
Series phy: qcom: qmp-pcie: drop second clock-output-names entry | expand

Message

Dmitry Baryshkov June 14, 2024, 10:18 a.m. UTC
While testing the linux-next on SM8450-HDK I noticed that one of the
PCIe hosts stays in the deferred state, because the corresponding PHY
isn't probed. A quick debug pointed out that while the patches that
added support for the PIPE AUX clock to the PHY driver have landed,
corresponding DT changes were not picked up for 6.10. Restore the
compatibility with the existing DT files by dropping the second entry in
the clock-output-names array and always generating the corresponding
name on the fly.

To: Vinod Koul <vkoul@kernel.org>
To: Kishon Vijay Abraham I <kishon@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: linux-phy@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Changes in v3:
- Also added DT bits to remove DT warning
- Link to v2: https://lore.kernel.org/r/20240614-fix-pcie-phy-compat-v2-0-990863ea53bf@linaro.org

Changes in v2:
- Fixed generated AUX clock name (Neil)
- Link to v1: https://lore.kernel.org/r/20240521-fix-pcie-phy-compat-v1-0-8aa415b92308@linaro.org

---
Dmitry Baryshkov (5):
      phy: qcom: qmp-pcie: restore compatibility with existing DTs
      dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: drop second output clock name
      arm64: dts: qcom: sm8450: drop second clock name from clock-output-names
      arm64: dts: qcom: sm8550: drop second clock name from clock-output-names
      arm64: dts: qcom: sm8650: drop second clock name from clock-output-names

 .../devicetree/bindings/phy/qcom,sc8280xp-qmp-pcie-phy.yaml      | 7 +------
 arch/arm64/boot/dts/qcom/sm8450.dtsi                             | 2 +-
 arch/arm64/boot/dts/qcom/sm8550.dtsi                             | 2 +-
 arch/arm64/boot/dts/qcom/sm8650.dtsi                             | 2 +-
 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c                         | 9 +++------
 5 files changed, 7 insertions(+), 15 deletions(-)
---
base-commit: 6906a84c482f098d31486df8dc98cead21cce2d0
change-id: 20240521-fix-pcie-phy-compat-b0fd4eb46bda

Best regards,

Comments

Vinod Koul June 15, 2024, 6:52 p.m. UTC | #1
On Fri, 14 Jun 2024 13:18:23 +0300, Dmitry Baryshkov wrote:
> While testing the linux-next on SM8450-HDK I noticed that one of the
> PCIe hosts stays in the deferred state, because the corresponding PHY
> isn't probed. A quick debug pointed out that while the patches that
> added support for the PIPE AUX clock to the PHY driver have landed,
> corresponding DT changes were not picked up for 6.10. Restore the
> compatibility with the existing DT files by dropping the second entry in
> the clock-output-names array and always generating the corresponding
> name on the fly.
> 
> [...]

Applied, thanks!

[1/5] phy: qcom: qmp-pcie: restore compatibility with existing DTs
      commit: 912cee11c14376a6f707d72fcaf343a40bff48e8
[2/5] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: drop second output clock name
      commit: 7cd3e586068aca123ff244fc259ba62ba96b6d31
[3/5] arm64: dts: qcom: sm8450: drop second clock name from clock-output-names
      (no commit info)
[4/5] arm64: dts: qcom: sm8550: drop second clock name from clock-output-names
      (no commit info)
[5/5] arm64: dts: qcom: sm8650: drop second clock name from clock-output-names
      (no commit info)

Best regards,
Bjorn Andersson June 21, 2024, 6:11 a.m. UTC | #2
On Fri, 14 Jun 2024 13:18:23 +0300, Dmitry Baryshkov wrote:
> While testing the linux-next on SM8450-HDK I noticed that one of the
> PCIe hosts stays in the deferred state, because the corresponding PHY
> isn't probed. A quick debug pointed out that while the patches that
> added support for the PIPE AUX clock to the PHY driver have landed,
> corresponding DT changes were not picked up for 6.10. Restore the
> compatibility with the existing DT files by dropping the second entry in
> the clock-output-names array and always generating the corresponding
> name on the fly.
> 
> [...]

Applied, thanks!

[3/5] arm64: dts: qcom: sm8450: drop second clock name from clock-output-names
      commit: 831f66d3423c22457ec1d686e565e152b10fbd91
[4/5] arm64: dts: qcom: sm8550: drop second clock name from clock-output-names
      commit: 84ea430eb0719ebe4c423bdc9c92e0f94a46a47e
[5/5] arm64: dts: qcom: sm8650: drop second clock name from clock-output-names
      commit: dc323623c3b87c48c99fe8dbbd1962f0129d3da9

Best regards,