mbox series

[v2,0/7] arm64: dts: qcom: sc8180x: Enable the USB multiport controller

Message ID 20240730-sc8180x-usb-mp-v2-0-a7dc4265b553@quicinc.com (mailing list archive)
Headers show
Series arm64: dts: qcom: sc8180x: Enable the USB multiport controller | expand

Message

Bjorn Andersson July 31, 2024, 3:24 a.m. UTC
The USB multiport controller found in SC8180X is used to driver the
camera in the Lenovo Flex 5G, and a couple of additional USB ports on
the Primus AUX board.

---
Changes in v2:
- Moved mp index last in DT labels
- Dropped applied PHY patches, and sent dwc3 binding update separately
- Spelled out GPIO_ACTIVE_HIGH as necessary
- Moved status last in a few nodes
- Corrected MP_PHY_PIPE_1_CLK
- Link to v1: https://lore.kernel.org/r/20240525-sc8180x-usb-mp-v1-0-60a904392438@quicinc.com

---
Bjorn Andersson (7):
      dt-bindings: clock: qcom: Add missing USB MP resets
      clk: qcom: gcc-sc8180x: Add missing USB MP resets
      arm64: dts: qcom: sc8180x-pmics: Add second PMC8180 GPIO
      arm64: dts: qcom: sc8180x: Align USB nodes with binding
      arm64: dts: qcom: sc8180x: Add USB MP controller and phys
      arm64: dts: qcom: sc8180x-primus: Enable the two MP USB ports
      arm64: dts: qcom: sc8180x-lenovo-flex-5g: Enable USB multiport controller

 .../arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts |  34 ++++
 arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi        |  16 +-
 arch/arm64/boot/dts/qcom/sc8180x-primus.dts        |  60 +++++++
 arch/arm64/boot/dts/qcom/sc8180x.dtsi              | 181 +++++++++++++++++++--
 drivers/clk/qcom/gcc-sc8180x.c                     |   4 +
 include/dt-bindings/clock/qcom,gcc-sc8180x.h       |   4 +
 6 files changed, 285 insertions(+), 14 deletions(-)
---
base-commit: 668d33c9ff922c4590c58754ab064aaf53c387dd
change-id: 20240524-sc8180x-usb-mp-4eb278df7ef1

Best regards,

Comments

Bjorn Andersson Aug. 1, 2024, 3:19 a.m. UTC | #1
On Tue, 30 Jul 2024 20:24:37 -0700, Bjorn Andersson wrote:
> The USB multiport controller found in SC8180X is used to driver the
> camera in the Lenovo Flex 5G, and a couple of additional USB ports on
> the Primus AUX board.
> 

Applied, thanks!

[3/7] arm64: dts: qcom: sc8180x-pmics: Add second PMC8180 GPIO
      commit: c8d8e936bc820eaad0ca725ac0456f4839e50ad3
[4/7] arm64: dts: qcom: sc8180x: Align USB nodes with binding
      commit: 82a40c7b06566bf0ff4fb7fbf29ab7b267c78f03
[5/7] arm64: dts: qcom: sc8180x: Add USB MP controller and phys
      commit: 96aab8ff59a9fca54dd0e13660684b4a8e73e1a3
[6/7] arm64: dts: qcom: sc8180x-primus: Enable the two MP USB ports
      commit: e12953d3b126dbff40a8531b99c377d653f0e27d
[7/7] arm64: dts: qcom: sc8180x-lenovo-flex-5g: Enable USB multiport controller
      commit: c1ece392ed906cc598a7b96234961721060aae05

Best regards,
Steev Klimaszewski Aug. 13, 2024, 2:06 a.m. UTC | #2
On Tue, Jul 30, 2024 at 10:20 PM Bjorn Andersson <andersson@kernel.org> wrote:
>
> The USB multiport controller found in SC8180X is used to driver the
> camera in the Lenovo Flex 5G, and a couple of additional USB ports on
> the Primus AUX board.
>
> ---
> Changes in v2:
> - Moved mp index last in DT labels
> - Dropped applied PHY patches, and sent dwc3 binding update separately
> - Spelled out GPIO_ACTIVE_HIGH as necessary
> - Moved status last in a few nodes
> - Corrected MP_PHY_PIPE_1_CLK
> - Link to v1: https://lore.kernel.org/r/20240525-sc8180x-usb-mp-v1-0-60a904392438@quicinc.com
>
> ---
> Bjorn Andersson (7):
>       dt-bindings: clock: qcom: Add missing USB MP resets
>       clk: qcom: gcc-sc8180x: Add missing USB MP resets
>       arm64: dts: qcom: sc8180x-pmics: Add second PMC8180 GPIO
>       arm64: dts: qcom: sc8180x: Align USB nodes with binding
>       arm64: dts: qcom: sc8180x: Add USB MP controller and phys
>       arm64: dts: qcom: sc8180x-primus: Enable the two MP USB ports
>       arm64: dts: qcom: sc8180x-lenovo-flex-5g: Enable USB multiport controller
>
>  .../arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts |  34 ++++
>  arch/arm64/boot/dts/qcom/sc8180x-pmics.dtsi        |  16 +-
>  arch/arm64/boot/dts/qcom/sc8180x-primus.dts        |  60 +++++++
>  arch/arm64/boot/dts/qcom/sc8180x.dtsi              | 181 +++++++++++++++++++--
>  drivers/clk/qcom/gcc-sc8180x.c                     |   4 +
>  include/dt-bindings/clock/qcom,gcc-sc8180x.h       |   4 +
>  6 files changed, 285 insertions(+), 14 deletions(-)
> ---
> base-commit: 668d33c9ff922c4590c58754ab064aaf53c387dd
> change-id: 20240524-sc8180x-usb-mp-4eb278df7ef1
>
> Best regards,
> --
> Bjorn Andersson <quic_bjorande@quicinc.com>
>
>
Tested here on the Lenovo Flex 5G with Cheese 44.1-1+b4 in Gnome 46,
have a working webcam, can record videos, and take pictures without
issue, and the webcam shows up as Bus 001 Device 002: ID 13d3:5419 IMC
Network Integrated Camera

Tested-by: Steev Klimaszewski <steev@kali.org>