mbox series

[0/8] serial: qcom-geni: fix console corruption

Message ID 20240902152451.862-1-johan+linaro@kernel.org (mailing list archive)
Headers show
Series serial: qcom-geni: fix console corruption | expand

Message

Johan Hovold Sept. 2, 2024, 3:24 p.m. UTC
This series is a follow-on series to the lockup fixes [1] that addresses
a number of issues in the Qualcomm GENI console code, including corrupt
console output during boot, which is a problem for automated CI testing.

Johan

[1] https://lore.kernel.org/lkml/20240704101805.30612-1-johan+linaro@kernel.org/


Douglas Anderson (3):
  soc: qcom: geni-se: add GP_LENGTH/IRQ_EN_SET/IRQ_EN_CLEAR registers
  serial: qcom-geni: fix arg types for qcom_geni_serial_poll_bit()
  serial: qcom-geni: introduce qcom_geni_serial_poll_bitfield()

Johan Hovold (5):
  serial: qcom-geni: fix fifo polling timeout
  serial: qcom-geni: fix false console tx restart
  serial: qcom-geni: fix console corruption
  serial: qcom-geni: disable interrupts during console writes
  serial: qcom-geni: fix polled console corruption

 drivers/tty/serial/qcom_geni_serial.c | 133 +++++++++++++++-----------
 include/linux/soc/qcom/geni-se.h      |   9 ++
 2 files changed, 85 insertions(+), 57 deletions(-)

Comments

Nícolas F. R. A. Prado Sept. 4, 2024, 6:08 p.m. UTC | #1
On Mon, Sep 02, 2024 at 05:24:43PM +0200, Johan Hovold wrote:
> This series is a follow-on series to the lockup fixes [1] that addresses
> a number of issues in the Qualcomm GENI console code, including corrupt
> console output during boot, which is a problem for automated CI testing.
> 
> Johan
> 
> [1] https://lore.kernel.org/lkml/20240704101805.30612-1-johan+linaro@kernel.org/
> 
> 
> Douglas Anderson (3):
>   soc: qcom: geni-se: add GP_LENGTH/IRQ_EN_SET/IRQ_EN_CLEAR registers
>   serial: qcom-geni: fix arg types for qcom_geni_serial_poll_bit()
>   serial: qcom-geni: introduce qcom_geni_serial_poll_bitfield()
> 
> Johan Hovold (5):
>   serial: qcom-geni: fix fifo polling timeout
>   serial: qcom-geni: fix false console tx restart
>   serial: qcom-geni: fix console corruption
>   serial: qcom-geni: disable interrupts during console writes
>   serial: qcom-geni: fix polled console corruption
> 
>  drivers/tty/serial/qcom_geni_serial.c | 133 +++++++++++++++-----------
>  include/linux/soc/qcom/geni-se.h      |   9 ++
>  2 files changed, 85 insertions(+), 57 deletions(-)
> 
> -- 
> 2.44.2
> 

This series fixes the serial issues we're seeing on the sc7180 based
(sc7180-trogdor-lazor-limozeen and sc7180-trogdor-kingoftown) boards that we
have hooked up to KernelCI. Out of a 10-job batch of boot tests all succeeded
after the patch, whereas before most failed (7/10), due to a missing message in
the serial.

Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Looking forward to see this landed!

Thanks,
Nícolas
Johan Hovold Sept. 5, 2024, 8:15 a.m. UTC | #2
On Wed, Sep 04, 2024 at 02:08:54PM -0400, Nícolas F. R. A. Prado wrote:
> On Mon, Sep 02, 2024 at 05:24:43PM +0200, Johan Hovold wrote:
> > This series is a follow-on series to the lockup fixes [1] that addresses
> > a number of issues in the Qualcomm GENI console code, including corrupt
> > console output during boot, which is a problem for automated CI testing.

> This series fixes the serial issues we're seeing on the sc7180 based
> (sc7180-trogdor-lazor-limozeen and sc7180-trogdor-kingoftown) boards that we
> have hooked up to KernelCI. Out of a 10-job batch of boot tests all succeeded
> after the patch, whereas before most failed (7/10), due to a missing message in
> the serial.
> 
> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Thanks for testing!

Johan