| Message ID | 20241025123227.3527720-1-quic_sibis@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | X1E001DE Snapdragon Devkit for Windows | expand |
On Fri, 25 Oct 2024 18:02:24 +0530, Sibi Sankar wrote: > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE > is the speed binned variant of X1E80100 that supports turbo boost up to > 4.3 Ghz. The initial support includes the following: > > -DSPs > -Ethernet (RTL8125BG) over the pcie 5 instance. > -NVme > -Wifi > -USB-C ports > > V3: > * Asked around and looked at the firmware, couldn't find a codename so > will keep it as DEVKIT. Will update it if someone from the community > finds something else. > * Update type c roles as reported by ucsi. [Dmitry] > * Update THUNDERCOMM to Thundercomm. [Dmitry] > * Update regulator names and sort Order. [Dmitry] > * Add x1e001DE devkit to the safe list. > * Mark regulator-nmve as boot enabled. > > > V2: > * Fix Ghz -> GHz [Jeff] > * Pick up Ab tag from Rob. > * Use Vendor in ADSP/CDSP firmware path [Dmitry] > * Fix reserved gpios [Dmitry] > * Only port0 supports DRD update the dt accordingly [Dmitry] > > Sibi Sankar (3): > dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows > firmware: qcom: uefisecapp: Allow X1E Devkit devices > arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows > > .../devicetree/bindings/arm/qcom.yaml | 6 + > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 814 ++++++++++++++++++ > drivers/firmware/qcom/qcom_scm.c | 1 + > 4 files changed, 822 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts > > -- > 2.34.1 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y qcom/x1e001de-devkit.dtb' for 20241025123227.3527720-1-quic_sibis@quicinc.com: arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml# arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: system-cache-controller@25000000: reg: [[0, 620756992, 0, 2097152], [0, 622854144, 0, 2097152], [0, 624951296, 0, 2097152], [0, 627048448, 0, 2097152], [0, 629145600, 0, 2097152], [0, 631242752, 0, 2097152], [0, 633339904, 0, 2097152], [0, 635437056, 0, 2097152], [0, 637534208, 0, 2097152], [0, 639631360, 0, 2097152]] is too long from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml# arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: system-cache-controller@25000000: reg-names: ['llcc0_base', 'llcc1_base', 'llcc2_base', 'llcc3_base', 'llcc4_base', 'llcc5_base', 'llcc6_base', 'llcc7_base', 'llcc_broadcast_base', 'llcc_broadcast_and_base'] is too long from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml# arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: system-cache-controller@25000000: reg: [[0, 620756992, 0, 2097152], [0, 622854144, 0, 2097152], [0, 624951296, 0, 2097152], [0, 627048448, 0, 2097152], [0, 629145600, 0, 2097152], [0, 631242752, 0, 2097152], [0, 633339904, 0, 2097152], [0, 635437056, 0, 2097152], [0, 637534208, 0, 2097152], [0, 639631360, 0, 2097152]] is too long from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml# arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: system-cache-controller@25000000: reg-names: ['llcc0_base', 'llcc1_base', 'llcc2_base', 'llcc3_base', 'llcc4_base', 'llcc5_base', 'llcc6_base', 'llcc7_base', 'llcc_broadcast_base', 'llcc_broadcast_and_base'] is too long from schema $id: http://devicetree.org/schemas/cache/qcom,llcc.yaml#
On 25.10.24 14:32, Sibi Sankar wrote: > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE > is the speed binned variant of X1E80100 that supports turbo boost up to > 4.3 Ghz. The initial support includes the following: > > -DSPs > -Ethernet (RTL8125BG) over the pcie 5 instance. > -NVme > -Wifi > -USB-C ports > > V3: > * Asked around and looked at the firmware, couldn't find a codename so > will keep it as DEVKIT. Will update it if someone from the community > finds something else. > * Update type c roles as reported by ucsi. [Dmitry] > * Update THUNDERCOMM to Thundercomm. [Dmitry] > * Update regulator names and sort Order. [Dmitry] > * Add x1e001DE devkit to the safe list. > * Mark regulator-nmve as boot enabled. > > > V2: > * Fix Ghz -> GHz [Jeff] > * Pick up Ab tag from Rob. > * Use Vendor in ADSP/CDSP firmware path [Dmitry] > * Fix reserved gpios [Dmitry] > * Only port0 supports DRD update the dt accordingly [Dmitry] > > Sibi Sankar (3): > dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows > firmware: qcom: uefisecapp: Allow X1E Devkit devices > arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows > > .../devicetree/bindings/arm/qcom.yaml | 6 + > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 814 ++++++++++++++++++ > drivers/firmware/qcom/qcom_scm.c | 1 + > 4 files changed, 822 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts > I have used this dt to bring up my Dev Kit, it is a great help. Thank you! - Jens link: https://github.com/jglathe/linux_ms_dev_kit/wiki/Bringing-up-the-SnapDragon-Dev-Kit-for-Windows-with-Linux-%E2%80%90-without-working-display Tested-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>
On Fri, 25 Oct 2024 13:32:24 +0100, Sibi Sankar <quic_sibis@quicinc.com> wrote: > > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE > is the speed binned variant of X1E80100 that supports turbo boost up to > 4.3 Ghz. The initial support includes the following: > > -DSPs > -Ethernet (RTL8125BG) over the pcie 5 instance. > -NVme > -Wifi > -USB-C ports > > V3: > * Asked around and looked at the firmware, couldn't find a codename so > will keep it as DEVKIT. Will update it if someone from the community > finds something else. My machine has the following information as part of its DMI tables: Handle 0x0005, DMI type 1, 27 bytes System Information Manufacturer: Qualcomm Product Name: Snapdragon-Devkit Version: 2.1 Serial Number: 5 UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291 Wake-up Type: Power Switch SKU Number: 6 Family: SCP_HAMOA So I guess that Snapdragon-Devkit is another possible name. But given that it is a bit of a mouthful, devkit, Devkit, or any other variation on the case would work for me. > * Update type c roles as reported by ucsi. [Dmitry] > * Update THUNDERCOMM to Thundercomm. [Dmitry] > * Update regulator names and sort Order. [Dmitry] > * Add x1e001DE devkit to the safe list. > * Mark regulator-nmve as boot enabled. > > > V2: > * Fix Ghz -> GHz [Jeff] > * Pick up Ab tag from Rob. > * Use Vendor in ADSP/CDSP firmware path [Dmitry] > * Fix reserved gpios [Dmitry] > * Only port0 supports DRD update the dt accordingly [Dmitry] > > Sibi Sankar (3): > dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows > firmware: qcom: uefisecapp: Allow X1E Devkit devices > arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows > > .../devicetree/bindings/arm/qcom.yaml | 6 + > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 814 ++++++++++++++++++ > drivers/firmware/qcom/qcom_scm.c | 1 + > 4 files changed, 822 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts FWIW, I'm running this as part of my KVM test rig with minor changes to expose the SMMU and allow the ITS on pcie5, and things work as well as you can expect. FWIW: Acked-by: Marc Zyngier <maz@kernel.org> Tested-by: Marc Zyngier <maz@kernel.org> M.
On 24-10-30 17:02:32, Marc Zyngier wrote: > On Fri, 25 Oct 2024 13:32:24 +0100, > Sibi Sankar <quic_sibis@quicinc.com> wrote: > > > > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE > > is the speed binned variant of X1E80100 that supports turbo boost up to > > 4.3 Ghz. The initial support includes the following: > > > > -DSPs > > -Ethernet (RTL8125BG) over the pcie 5 instance. > > -NVme > > -Wifi > > -USB-C ports > > > > V3: > > * Asked around and looked at the firmware, couldn't find a codename so > > will keep it as DEVKIT. Will update it if someone from the community > > finds something else. > > My machine has the following information as part of its DMI tables: > > Handle 0x0005, DMI type 1, 27 bytes > System Information > Manufacturer: Qualcomm > Product Name: Snapdragon-Devkit > Version: 2.1 > Serial Number: 5 > UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291 > Wake-up Type: Power Switch > SKU Number: 6 > Family: SCP_HAMOA > > So I guess that Snapdragon-Devkit is another possible name. But given > that it is a bit of a mouthful, devkit, Devkit, or any other variation > on the case would work for me. The point was to have something unique A codename would be unique. Naming it Snapdragon-Devkit (or just devkit) will be confusing since there was already a 2023 devkit (from Microsoft) with the Snapdragon 8cx Gen 3, and probably the next compute platform will also have a devkit as well. So probably "X Elite devkit" could be the right option.. > > > * Update type c roles as reported by ucsi. [Dmitry] > > * Update THUNDERCOMM to Thundercomm. [Dmitry] > > * Update regulator names and sort Order. [Dmitry] > > * Add x1e001DE devkit to the safe list. > > * Mark regulator-nmve as boot enabled. > > > > > > V2: > > * Fix Ghz -> GHz [Jeff] > > * Pick up Ab tag from Rob. > > * Use Vendor in ADSP/CDSP firmware path [Dmitry] > > * Fix reserved gpios [Dmitry] > > * Only port0 supports DRD update the dt accordingly [Dmitry] > > > > Sibi Sankar (3): > > dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows > > firmware: qcom: uefisecapp: Allow X1E Devkit devices > > arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows > > > > .../devicetree/bindings/arm/qcom.yaml | 6 + > > arch/arm64/boot/dts/qcom/Makefile | 1 + > > arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 814 ++++++++++++++++++ > > drivers/firmware/qcom/qcom_scm.c | 1 + > > 4 files changed, 822 insertions(+) > > create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts > > FWIW, I'm running this as part of my KVM test rig with minor changes > to expose the SMMU and allow the ITS on pcie5, and things work as well > as you can expect. FWIW: > > Acked-by: Marc Zyngier <maz@kernel.org> > Tested-by: Marc Zyngier <maz@kernel.org> > > M. > > -- > Without deviation from the norm, progress is not possible.
On 31.10.24 10:46, Abel Vesa wrote: > On 24-10-30 17:02:32, Marc Zyngier wrote: >> On Fri, 25 Oct 2024 13:32:24 +0100, >> Sibi Sankar <quic_sibis@quicinc.com> wrote: >>> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE >>> is the speed binned variant of X1E80100 that supports turbo boost up to >>> 4.3 Ghz. The initial support includes the following: >>> >>> -DSPs >>> -Ethernet (RTL8125BG) over the pcie 5 instance. >>> -NVme >>> -Wifi >>> -USB-C ports >>> >>> V3: >>> * Asked around and looked at the firmware, couldn't find a codename so >>> will keep it as DEVKIT. Will update it if someone from the community >>> finds something else. >> My machine has the following information as part of its DMI tables: >> >> Handle 0x0005, DMI type 1, 27 bytes >> System Information >> Manufacturer: Qualcomm >> Product Name: Snapdragon-Devkit >> Version: 2.1 >> Serial Number: 5 >> UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291 >> Wake-up Type: Power Switch >> SKU Number: 6 >> Family: SCP_HAMOA >> >> So I guess that Snapdragon-Devkit is another possible name. But given >> that it is a bit of a mouthful, devkit, Devkit, or any other variation >> on the case would work for me. > The point was to have something unique A codename would be unique. > Naming it Snapdragon-Devkit (or just devkit) will be confusing since > there was already a 2023 devkit (from Microsoft) with the Snapdragon > 8cx Gen 3, and probably the next compute platform will also have a devkit > as well. So probably "X Elite devkit" could be the right option.. As for The Windows Dev Kit 2023, dmidecode says this: Handle 0x0009, DMI type 1, 27 bytes System Information Manufacturer: Microsoft Corporation Product Name: Windows Dev Kit 2023 Version: 124I:00097T:000M:0200000B:07 Serial Number: 0F01C4F22373F6 UUID: e4a4662c-8367-75d0-a54f-1d04bd404860 Wake-up Type: Unknown SKU Number: 2043 Family: Surface That's also really a mouthful. In my patchset for it there were some name / path changes, microsoft/blackrock it is now. Would be cool to have short and unique names. In the end, whatever works and is unique. Like those UUIDs? >>> * Update type c roles as reported by ucsi. [Dmitry] >>> * Update THUNDERCOMM to Thundercomm. [Dmitry] >>> * Update regulator names and sort Order. [Dmitry] >>> * Add x1e001DE devkit to the safe list. >>> * Mark regulator-nmve as boot enabled. >>> >>> >>> V2: >>> * Fix Ghz -> GHz [Jeff] >>> * Pick up Ab tag from Rob. >>> * Use Vendor in ADSP/CDSP firmware path [Dmitry] >>> * Fix reserved gpios [Dmitry] >>> * Only port0 supports DRD update the dt accordingly [Dmitry] >>> >>> Sibi Sankar (3): >>> dt-bindings: arm: qcom: Add Snapdragon Devkit for Windows >>> firmware: qcom: uefisecapp: Allow X1E Devkit devices >>> arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows >>> >>> .../devicetree/bindings/arm/qcom.yaml | 6 + >>> arch/arm64/boot/dts/qcom/Makefile | 1 + >>> arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 814 ++++++++++++++++++ >>> drivers/firmware/qcom/qcom_scm.c | 1 + >>> 4 files changed, 822 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts >> FWIW, I'm running this as part of my KVM test rig with minor changes >> to expose the SMMU and allow the ITS on pcie5, and things work as well >> as you can expect. FWIW: >> >> Acked-by: Marc Zyngier <maz@kernel.org> >> Tested-by: Marc Zyngier <maz@kernel.org> >> >> M. >> >> -- >> Without deviation from the norm, progress is not possible.
On Thu, 31 Oct 2024 10:00:40 +0000, Jens Glathe <jens.glathe@oldschoolsolutions.biz> wrote: > > On 31.10.24 10:46, Abel Vesa wrote: > > On 24-10-30 17:02:32, Marc Zyngier wrote: > >> On Fri, 25 Oct 2024 13:32:24 +0100, > >> Sibi Sankar <quic_sibis@quicinc.com> wrote: > >>> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE > >>> is the speed binned variant of X1E80100 that supports turbo boost up to > >>> 4.3 Ghz. The initial support includes the following: > >>> > >>> -DSPs > >>> -Ethernet (RTL8125BG) over the pcie 5 instance. > >>> -NVme > >>> -Wifi > >>> -USB-C ports > >>> > >>> V3: > >>> * Asked around and looked at the firmware, couldn't find a codename so > >>> will keep it as DEVKIT. Will update it if someone from the community > >>> finds something else. > >> My machine has the following information as part of its DMI tables: > >> > >> Handle 0x0005, DMI type 1, 27 bytes > >> System Information > >> Manufacturer: Qualcomm > >> Product Name: Snapdragon-Devkit > >> Version: 2.1 > >> Serial Number: 5 > >> UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291 > >> Wake-up Type: Power Switch > >> SKU Number: 6 > >> Family: SCP_HAMOA > >> > >> So I guess that Snapdragon-Devkit is another possible name. But given > >> that it is a bit of a mouthful, devkit, Devkit, or any other variation > >> on the case would work for me. > > The point was to have something unique A codename would be unique. > > Naming it Snapdragon-Devkit (or just devkit) will be confusing since > > there was already a 2023 devkit (from Microsoft) with the Snapdragon > > 8cx Gen 3, and probably the next compute platform will also have a devkit > > as well. So probably "X Elite devkit" could be the right option.. Odd, I didn't get that email. My point was the the HW already comes with a full description as part of the existing tables. If you really want something that is truly unique to that platform and that can be used by a tool (be it firmware, kernel or userspace) to understand what it is running on, then you cannot have *less* information. At the very least, you would need Manufacturer, Product Name, Version and Family. But does it really matter? I don't think it is *that* crucial. At the end of the day, this is only used to pick the correct DT out of a set for a given SoC, or worse case a family of SoCs that are closely related. > As for The Windows Dev Kit 2023, dmidecode says this: > > Handle 0x0009, DMI type 1, 27 bytes > System Information > Manufacturer: Microsoft Corporation > Product Name: Windows Dev Kit 2023 > Version: 124I:00097T:000M:0200000B:07 > Serial Number: 0F01C4F22373F6 > UUID: e4a4662c-8367-75d0-a54f-1d04bd404860 > Wake-up Type: Unknown > SKU Number: 2043 > Family: Surface > > That's also really a mouthful. In my patchset for it there were some > name / path changes, microsoft/blackrock it is now. Would be cool to > have short and unique names. In the end, whatever works and is unique. > Like those UUIDs? Are those actually per platform? or per unit? On my box, the serial number is probably a dud. What does the UUID reports on your X1E box? Thanks, M.
On 31.10.24 13:29, Marc Zyngier wrote: > On Thu, 31 Oct 2024 10:00:40 +0000, > Jens Glathe <jens.glathe@oldschoolsolutions.biz> wrote: >> On 31.10.24 10:46, Abel Vesa wrote: >>> On 24-10-30 17:02:32, Marc Zyngier wrote: >>>> On Fri, 25 Oct 2024 13:32:24 +0100, >>>> Sibi Sankar <quic_sibis@quicinc.com> wrote: >>>>> Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE >>>>> is the speed binned variant of X1E80100 that supports turbo boost up to >>>>> 4.3 Ghz. The initial support includes the following: >>>>> >>>>> -DSPs >>>>> -Ethernet (RTL8125BG) over the pcie 5 instance. >>>>> -NVme >>>>> -Wifi >>>>> -USB-C ports >>>>> >>>>> V3: >>>>> * Asked around and looked at the firmware, couldn't find a codename so >>>>> will keep it as DEVKIT. Will update it if someone from the community >>>>> finds something else. >>>> My machine has the following information as part of its DMI tables: >>>> >>>> Handle 0x0005, DMI type 1, 27 bytes >>>> System Information >>>> Manufacturer: Qualcomm >>>> Product Name: Snapdragon-Devkit >>>> Version: 2.1 >>>> Serial Number: 5 >>>> UUID: 63b5fc8b-9c50-89aa-fd0f-3fcef93dc291 >>>> Wake-up Type: Power Switch >>>> SKU Number: 6 >>>> Family: SCP_HAMOA >>>> >>>> So I guess that Snapdragon-Devkit is another possible name. But given >>>> that it is a bit of a mouthful, devkit, Devkit, or any other variation >>>> on the case would work for me. >>> The point was to have something unique A codename would be unique. >>> Naming it Snapdragon-Devkit (or just devkit) will be confusing since >>> there was already a 2023 devkit (from Microsoft) with the Snapdragon >>> 8cx Gen 3, and probably the next compute platform will also have a devkit >>> as well. So probably "X Elite devkit" could be the right option.. > Odd, I didn't get that email. > > My point was the the HW already comes with a full description as part > of the existing tables. If you really want something that is truly > unique to that platform and that can be used by a tool (be it > firmware, kernel or userspace) to understand what it is running on, > then you cannot have *less* information. > > At the very least, you would need Manufacturer, Product Name, Version > and Family. > > But does it really matter? I don't think it is *that* crucial. At the > end of the day, this is only used to pick the correct DT out of a set > for a given SoC, or worse case a family of SoCs that are closely > related. > >> As for The Windows Dev Kit 2023, dmidecode says this: >> >> Handle 0x0009, DMI type 1, 27 bytes >> System Information >> Manufacturer: Microsoft Corporation >> Product Name: Windows Dev Kit 2023 >> Version: 124I:00097T:000M:0200000B:07 >> Serial Number: 0F01C4F22373F6 >> UUID: e4a4662c-8367-75d0-a54f-1d04bd404860 >> Wake-up Type: Unknown >> SKU Number: 2043 >> Family: Surface >> >> That's also really a mouthful. In my patchset for it there were some >> name / path changes, microsoft/blackrock it is now. Would be cool to >> have short and unique names. In the end, whatever works and is unique. >> Like those UUIDs? > Are those actually per platform? or per unit? On my box, the serial > number is probably a dud. What does the UUID reports on your X1E box? > > Thanks, > > M. > Looks like the UUIDs are System UUIDs (unique). They are not the same as /etc/machine-id either. X1E DevKit: Handle 0x0005, DMI type 1, 27 bytes System Information Manufacturer: Qualcomm Product Name: Snapdragon-Devkit Version: 2.1 Serial Number: 5 UUID: eadc72c0-a0bd-cced-025c-c3a1494d433c Wake-up Type: Power Switch SKU Number: 6 Family: SCP_HAMOA Second Windows Dev Kit 2023: Handle 0x0009, DMI type 1, 27 bytes System Information Manufacturer: Microsoft Corporation Product Name: Windows Dev Kit 2023 Version: 124I:00097T:000M:0200000B:07 Serial Number: 0F004PD22363F6 UUID: 35b94307-ddb5-e0c5-1c9a-ffc43fdf60ba Wake-up Type: Unknown SKU Number: 2043 Family: Surface Looks like maybe using the manufacturer for directory and product name for subdirectory could do. But that long name everywhere? with best regards Jens
On Fri, 25 Oct 2024 18:02:24 +0530, Sibi Sankar wrote: > Add initial support for X1E001DE Snapdragon Devkit for Windows. X1E001DE > is the speed binned variant of X1E80100 that supports turbo boost up to > 4.3 Ghz. The initial support includes the following: > > -DSPs > -Ethernet (RTL8125BG) over the pcie 5 instance. > -NVme > -Wifi > -USB-C ports > > [...] Applied, thanks! [2/3] firmware: qcom: uefisecapp: Allow X1E Devkit devices commit: 75837f0b2bc61c62c8326fe3a1eb9a100714cfd7 Best regards,