From patchwork Tue Dec 17 14:06:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vikram Sharma X-Patchwork-Id: 13911864 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F0701F4732; Tue, 17 Dec 2024 14:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734444454; cv=none; b=kQcydxllFn336b2Pzij57Yd+lu8PnrD4G23xc47m4jL4ugTQeBanaXaaigqESPuwEooyqoRAsF0U/vWM0ziwjrs5LEoWb+xyM40dJmnVZ4uxCKm9Qpd9Sy76QJZcDeYICXRoM9RfnZ5ITXAOo5ipRYzgI1xDa9yWENw9GoPudik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734444454; c=relaxed/simple; bh=gJlp5eOswZXwXBBEXzHGyxSEJMz+jme6RIIytWiHffw=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=MtUioMqvJc5do1LImccTDvwtGMmyQmm1VT88pkbiY0q92SMw9qJlncQYCnnXTrLH1JESe9g6FdxjvNbMcuZzohrY12kX5go2w2m7ANq2DU+sOqMXKZ9OrVzzqFK90+gw377xZLutbK0sgF9nOyb/ZKEMgNHB23aioTfWuN4hH1Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=X86oGhXY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="X86oGhXY" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BH82ZSO002889; Tue, 17 Dec 2024 14:07:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=NvyglwNc8Ba+fJbAEZ4sd6 /GlEP3Bpd5lQ3UhO5E5i0=; b=X86oGhXY2oFBHfKNFW7E0ZPd6BC2EXq9VfulSb xpDHJ6nMz4npm+YleLQO0Cuouo59e/GXAO/DOI/i4a4qYhc6RN/LpT4X4TJFLyJf l1wkIZEk6vbxL/mC5yDXoSmSL9zSQMR3ZKZnI+URS7inekucacynk9H4J7iSbbRk vjAFRgaxbfDHJqpOyDaK9hGziSpr2mYs5SwGPSGlUC4E+mZFTBg9T8NpzWydyA50 fPFkFW4uqFu9hZ6qB/P2ZMfcB0keCJhXC4Yad/yngg9CecopmOpBktqo3DG5Up1w ZkvoGWwSRVRYowWPzUzaEj1GTel1YHkGt6cQHRJqIPKXoSMw== Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43k5ek0ymx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Dec 2024 14:07:22 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4BHE7Mro005703 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Dec 2024 14:07:22 GMT Received: from hu-vikramsa-hyd.qualcomm.com (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 17 Dec 2024 06:07:12 -0800 From: Vikram Sharma To: , , , , , , , , , , , , , , CC: , , , , , , Subject: [PATCH v10 0/4] media: qcom: camss: Add sc7280 support Date: Tue, 17 Dec 2024 19:36:52 +0530 Message-ID: <20241217140656.965235-1-quic_vikramsa@quicinc.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 7B_4aTpOmDTg48Y7PaGQm_B0AxVyHHTI X-Proofpoint-ORIG-GUID: 7B_4aTpOmDTg48Y7PaGQm_B0AxVyHHTI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 phishscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412170112 SC7280 is a Qualcomm SoC. This series adds support to bring up the CSIPHY, CSID, VFE/RDI interfaces in SC7280. SC7280 provides - 3 x VFE, 3 RDI per VFE - 2 x VFE Lite, 4 RDI per VFE - 3 x CSID - 2 x CSID Lite - 5 x CSI PHY We have tested this on qcs6490-rb3gen2-vision-mezzanine board having IMX577 sensor. Verified both TPG and IMX577 sensor. Used following tools for the sanity check of these changes. - make CHECK_DTBS=y W=1 DT_SCHEMA_FILES=media/qcom,sc7280-camss.yaml qcom/qcs6490-rb3gen2-vision-mezzanine.dtb - make DT_CHECKER_FLAGS=-m W=1 DT_SCHEMA_FILES=media/qcom,sc7280-camss.yaml dt_binding_check - Smatch: make CHECK="smatch --full-path" M=drivers/media/platform/qcom/camss/ - Sparse: make C=2 M=drivers/media/platform/qcom/camss/ - coccicheck : make coccicheck M=drivers/media/platform/qcom/camss/ - make -j32 W=1 - ./scripts/checkpatch.pl Changes in V10: - Updated cover letter to add link for v8 under changes in v9. - No change in the patches w.r.t V9 - Link to v9: https://lore.kernel.org/linux-arm-msm/20241217133955.946426-1-quic_vikramsa@quicinc.com/ Changes in V9: - Removed GCC_CAMERA_AHB_CLK as its always enabled. - Added GCC_CAMERA_SF_AXI_CLK. - Renamed gcc_cam_hf_axi to gcc_axi_hf. - V8 had 5 patches and V9 have 4 patches. - First 3 patches of V8 are already promoted to linux-next i.e media: dt-bindings: Add qcom,sc7280-camss media: qcom: camss: Sort camss version enums and compatible strings media: qcom: camss: Add support for camss driver on sc7280 - 2 new patches are added to handle new comments from Konrad on "Patch v8 4/5 arm64: dts: qcom: sc7280: Add support for camss" 1 of the 2 new patches make changes in yaml and other one is making change in camss driver to handle new comments in dtsi. - for "Patch v8 4/5 arm64: dts: qcom: sc7280: Add support for camss" I got comments from Konrad to make changes for clock names so I had to make respective changes in "bindings/media/qcom,sc7280-camss.yaml". As dtsi changes are not merged yet, so there is no issues with backward compatibility and I am assuming this should be acceptable. - Link to v8: https://lore.kernel.org/linux-arm-msm/20241206191900.2545069-1-quic_vikramsa@quicinc.com/ Changes in V8: - Changed node name from camss to isp. - Added QCOM_ICC_TAG_ACTIVE_ONLY and QCOM_ICC_TAG_ALWAYS tags for interconnects. - Added blank lines when required. - Modified power-domain-names from horizontal to vertical list. - Sorted pinctrl nodes based on gpio index. - Link to v7: https://lore.kernel.org/linux-arm-msm/20241204100003.300123-1-quic_vikramsa@quicinc.com/ Changes in V7: - Changed unit address for camss in documention and dts. - Added avdd-supply and dvdd-supply for sensor. - Changed reg/clocks/interrupts name for vfe_lite and csid_lite. - Link to v6: https://lore.kernel.org/linux-arm-msm/20241127100421.3447601-1-quic_vikramsa@quicinc.com/ Changes in V6: - Changed order of properties in Documentation [PATCH 1/5]. - Updated description for ports in Documentaion [PATCH 1/5]. - Moved regulators from csid to csiphy [PATCH 3/5]. - Link to v5: https://lore.kernel.org/linux-arm-msm/20241112173032.2740119-1-quic_vikramsa@quicinc.com/ Changes in V5: - Updated Commit text for [PATCH v5 1/6]. - Moved reg after compatible string. - Renamed csi'x' clocks to vfe'x'_csid - Removed [PATCH v4 4/6] and raised a seprate series for this one. - Moved gpio states to mezzanine dtso. - Added more clock levels to address TPG related issues. - Renamed power-domains-names -> power-domain-names. - Link to v4: https://lore.kernel.org/linux-arm-msm/20241030105347.2117034-1-quic_vikramsa@quicinc.com/ Changes in V4: - V3 had 8 patches and V4 is reduced to 6. - Removed [Patch v3 2/8] as binding change is not required for dtso. - Removed [Patch v3 3/8] as the fix is already taken care in latest kernel tip. - Updated alignment for dtsi and dt-bindings. - Adding qcs6490-rb3gen2-vision-mezzanine as overlay. - Link to v3: https://lore.kernel.org/linux-arm-msm/20241011140932.1744124-1-quic_vikramsa@quicinc.com/ Changes in V3: - Added missed subject line for cover letter of V2. - Updated Alignment, indentation and properties order. - edit commit text for [PATCH 02/10] and [PATCH 03/10]. - Refactor camss_link_entities. - Removed camcc enablement changes as it already done. - Link to v2: https://lore.kernel.org/linux-arm-msm/20240904-camss_on_sc7280_rb3gen2_vision_v2_patches-v1-0-b18ddcd7d9df@quicinc.com/ Changes in V2: - Improved indentation/formatting. - Removed _src clocks and misleading code comments. - Added name fields for power domains and csid register offset in DTSI. - Dropped minItems field from YAML file. - Listed changes in alphabetical order. - Updated description and commit text to reflect changes - Changed the compatible string from imx412 to imx577. - Added board-specific enablement changes in the newly created vision board DTSI file. - Fixed bug encountered during testing. - Moved logically independent changes to a new/seprate patch. - Removed cci0 as no sensor is on this port and MCLK2, which was a copy-paste error from the RB5 board reference. - Added power rails, referencing the RB5 board. - Discarded Patch 5/6 completely (not required). - Removed unused enums. - Link to v1: https://lore.kernel.org/linux-arm-msm/20240629-camss_first_post_linux_next-v1-0-bc798edabc3a@quicinc.com/ Signed-off-by: Vikram Sharma Vikram Sharma (4): media: dt-bindings: update clocks for sc7280-camss media: qcom: camss: update clock names for sc7280 arm64: dts: qcom: sc7280: Add support for camss arm64: dts: qcom: qcs6490-rb3gen2-vision-mezzanine: Add vision mezzanine .../bindings/media/qcom,sc7280-camss.yaml | 10 +- arch/arm64/boot/dts/qcom/Makefile | 4 + .../qcs6490-rb3gen2-vision-mezzanine.dtso | 109 +++++++++++ arch/arm64/boot/dts/qcom/sc7280.dtsi | 178 ++++++++++++++++++ drivers/media/platform/qcom/camss/camss.c | 15 +- 5 files changed, 306 insertions(+), 10 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-vision-mezzanine.dtso