mbox series

[v4,00/17] Disable USB U1/U2 entry for QC ARM64 targets

Message ID 20241231081115.3149850-1-quic_prashk@quicinc.com (mailing list archive)
Headers show
Series Disable USB U1/U2 entry for QC ARM64 targets | expand

Message

Prashanth K Dec. 31, 2024, 8:10 a.m. UTC 
Enabling U1 and U2 power-saving states can lead to stability and
performance issues, particularly for latency-sensitive or high-
throughput applications. These low-power link states are intended
to reduce power consumption by allowing the device to enter partial
low-power modes during idle periods. However, they can sometimes
result in unexpected behavior. Over the years, some of the issues
seen are as follows:

1. In device mode of operation, when UVC is active, enabling U1/U2
is sometimes causing packets drops due to delay in entry/exit of
intermittent low power states. These packet drops are often reflected
as Missed Isochronous transfers as the controller was not able to
send the packet in that microframe interval and hence glitches are
seen on the final transmitted video output.

2. On QCS6490-Rb3Gen2 Vision kit, ADB connection is heavily unstable
when U1/U2 is enabled. Often when link enters U2, there is a re-
enumeration seen and device is unusable for many use cases.

3. On QCS8300/QCS9100, it is observed that when Link enters U2, when
the cable is disconnected and reconnected to host PC in HS, there
is no link status change interrupt seen and the plug-in in HS doesn't
show up a bus reset and enumeration failure happens.

4. On older targets like SM8150/SM8250/SM8350, there have been
throughput issues seen during tethering use cases.

5. On targets like SDX75, intermittent disconnects were observed
with certain cables due to impedence variations.

To avoid such issues, the USB team at Qualcomm added these quirks
to all targets in the past 4-5 years and extensive testing was done.
Although these are intermittent power states, disabling them didn't
cause any major increase in power numbers.

This series was earlier started by Krishna Kurapati where he disabled
U1/U2 on some SM targets. I'm extending this to more devices including
Auto, Compute and IOT platforms. On a side note, this quirk has been
already included on some mobile targets like SM8550/8650.

Changes in v4:
- Updated prefix in the subject of all patches.
- Split into 2 series for arm and arm64 targets.
- Link to v3:
https://lore.kernel.org/all/20241218102707.76272-1-quic_prashk@quicinc.com/

Changes in v3:
- Removed wrongly added quirks from tcsr_mutex node.
- Link to v2:
https://lore.kernel.org/all/20241213095237.1409174-1-quic_prashk@quicinc.com/

Changes in v2:
- RFC patch was split into series of per-file commits.
- Added the quirks to more targets (Auto, IoT, Mobile, Compute).
- Link to RFC:
https://lore.kernel.org/all/20241107073650.13473-1-quic_kriskura@quicinc.com/#Z31arch:arm64:boot:dts:qcom:sm8250.dtsi

Krishna Kurapati (8):
  arm64: dts: qcom: sm8350: Disable USB U1/U2 entry
  arm64: dts: qcom: sm8450: Disable USB U1/U2 entry
  arm64: dts: qcom: sm8150: Disable USB U1/U2 entry
  arm64: dts: qcom: sm6125: Disable USB U1/U2 entry
  arm64: dts: qcom: sm8250: Disable USB U1/U2 entry
  arm64: dts: qcom: sm6350: Disable USB U1/U2 entry
  arm64: dts: qcom: sc7280: Disable USB U1/U2 entry
  arm64: dts: qcom: sa8775p: Disable USB U1/U2 entry

Prashanth K (9):
  arm64: dts: qcom: sdm630: Disable USB U1/U2 entry
  arm64: dts: qcom: sdm845: Disable USB U1/U2 entry
  arm64: dts: qcom: sdx75: Disable USB U1/U2 entry
  arm64: dts: qcom: qcs404: Disable USB U1/U2 entry
  arm64: dts: qcom: sc7180: Disable USB U1/U2 entry
  arm64: dts: qcom: x1e80100: Disable USB U1/U2 entry
  arm64: dts: qcom: qdu1000: Disable USB U1/U2 entry
  arm64: dts: qcom: sc8280xp: Disable USB U1/U2 entry
  arm64: dts: qcom: sc8180x: Disable USB U1/U2 entry

 arch/arm64/boot/dts/qcom/qcs404.dtsi   |  4 ++++
 arch/arm64/boot/dts/qcom/qdu1000.dtsi  |  2 ++
 arch/arm64/boot/dts/qcom/sa8775p.dtsi  |  6 ++++++
 arch/arm64/boot/dts/qcom/sc7180.dtsi   |  2 ++
 arch/arm64/boot/dts/qcom/sc7280.dtsi   |  4 ++++
 arch/arm64/boot/dts/qcom/sc8180x.dtsi  |  6 ++++++
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi |  6 ++++++
 arch/arm64/boot/dts/qcom/sdm630.dtsi   |  4 ++++
 arch/arm64/boot/dts/qcom/sdm845.dtsi   |  4 ++++
 arch/arm64/boot/dts/qcom/sdx75.dtsi    |  2 ++
 arch/arm64/boot/dts/qcom/sm6125.dtsi   |  2 ++
 arch/arm64/boot/dts/qcom/sm6350.dtsi   |  2 ++
 arch/arm64/boot/dts/qcom/sm8150.dtsi   |  4 ++++
 arch/arm64/boot/dts/qcom/sm8250.dtsi   |  4 ++++
 arch/arm64/boot/dts/qcom/sm8350.dtsi   |  4 ++++
 arch/arm64/boot/dts/qcom/sm8450.dtsi   |  2 ++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 10 ++++++++++
 17 files changed, 68 insertions(+)

Comments

Bjorn Andersson Jan. 6, 2025, 11:20 p.m. UTC | #1 
On Tue, 31 Dec 2024 13:40:58 +0530, Prashanth K wrote:
> Enabling U1 and U2 power-saving states can lead to stability and
> performance issues, particularly for latency-sensitive or high-
> throughput applications. These low-power link states are intended
> to reduce power consumption by allowing the device to enter partial
> low-power modes during idle periods. However, they can sometimes
> result in unexpected behavior. Over the years, some of the issues
> seen are as follows:
> 
> [...]

Applied, thanks!

[01/17] arm64: dts: qcom: sm8350: Disable USB U1/U2 entry
        commit: 8582f8cee2f015ff4b8c5df3221917f3878f4c2a
[02/17] arm64: dts: qcom: sm8450: Disable USB U1/U2 entry
        commit: f9a963fc2510d32916e2e730c1b326c2ab3d312e
[03/17] arm64: dts: qcom: sm8150: Disable USB U1/U2 entry
        commit: 20f36ce4db5b544de640b5e47ac656fdd97b4896
[04/17] arm64: dts: qcom: sm6125: Disable USB U1/U2 entry
        commit: 2c1cf4b8cd8b4c574f1e367fd7f4fd44c1a1169a
[05/17] arm64: dts: qcom: sm8250: Disable USB U1/U2 entry
        commit: 06fcb653237b91e4befed93254b7c53e0d6139dc
[06/17] arm64: dts: qcom: sm6350: Disable USB U1/U2 entry
        commit: 8e252c3e4500eb8708de1d6e9ebead55a78a5d5d
[07/17] arm64: dts: qcom: sc7280: Disable USB U1/U2 entry
        commit: 0a13ba449afd4158cc981ff8b53d5c62aa34b377
[08/17] arm64: dts: qcom: sa8775p: Disable USB U1/U2 entry
        commit: 1052c4c63639ade18bfa2902371fd5e6c44b01e4
[09/17] arm64: dts: qcom: sdm630: Disable USB U1/U2 entry
        commit: 10b4593ba0f8b410d946d587828e6cae8f7cc78b
[10/17] arm64: dts: qcom: sdm845: Disable USB U1/U2 entry
        commit: c6b3c16f2c627a487653bc52d99b05a2bc453dc0
[11/17] arm64: dts: qcom: sdx75: Disable USB U1/U2 entry
        commit: cd2a6747583b441ad898834d3dd246ed271ad35d
[12/17] arm64: dts: qcom: qcs404: Disable USB U1/U2 entry
        commit: fc492c79faac5b44cb548578e35467873391094c
[13/17] arm64: dts: qcom: sc7180: Disable USB U1/U2 entry
        commit: 69336441c3c2dec512ed9c46d977c6587ebc795a
[14/17] arm64: dts: qcom: x1e80100: Disable USB U1/U2 entry
        commit: 9555a30e5f5d6fe97eed96907e867dc7543e1ccf
[15/17] arm64: dts: qcom: qdu1000: Disable USB U1/U2 entry
        commit: f70a41cefdd457d21198aeb5a062b98fddf780b3
[16/17] arm64: dts: qcom: sc8280xp: Disable USB U1/U2 entry
        commit: 49cfd97a335acbbdc9737e471a8ea3cbcea6c476
[17/17] arm64: dts: qcom: sc8180x: Disable USB U1/U2 entry
        commit: b7fdfac3f372b9d633cca6c1c54878118c8a5932

Best regards,