From patchwork Fri Feb 14 10:45:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenbin Yao X-Patchwork-Id: 13974726 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8134720A5FC; Fri, 14 Feb 2025 10:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739529958; cv=none; b=DdNAvoLiwN4XHFlu6BwhrXIaqmR6UQODVUQJwZg8xXZ9c9CQPfiHx6pM1KXyFhLzoG+4OFYdkmvUeW2BnfPi+MgSJa9t20cKg5BxX9foDLqBePsv5tidcjroJVHhbbrfpn/rUk8+9nWqxl53EBBCc2R0+RA9R/13wYXTuaDuJSQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739529958; c=relaxed/simple; bh=+iHC4MGSu5T0avjokdxOiYMYJ/l/fXBugbDK8GJSNGA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=VLafxcIxZK0k2oDNQ1H1iTcdkj0dQ0N242S8NhUn2GIIuRQCTxoXZ8kgkWZnlLWZFfxQ2V/XAs5Y+2G1OvLp9fILPwyEb71c2uLWKeqeIXuRLMkjYEd7SIYNPhuURBkcSi9Sg35z09r/ZKdLJHpC7Xy+slhy7erQMd57UlPDvLo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=qualcomm.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=NXp5D6qh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="NXp5D6qh" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51E9dDKg002731; Fri, 14 Feb 2025 10:45:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=rcKNt6rVY+kHP6dSWsyhVK9ewhfyy3goRu8 GUZrnS54=; b=NXp5D6qhGznLLz1h4zd+cgR6PDi0OHYnJ/TIc0cN25yHy5AtcAe FWqOyuGM01aXLs4SIkcgXr6SceZN9SRiMjO0SnO/i5pla9Njc9zAzJu55BiN6ZmH uhPKChl2xP7RCMrt76Ug8Qw2SXIoO2AWAVGGxhwbc5jb02n4KT7OVQanSld1AJ3b zDE7pOKTvZYBtQKQF1mQt7nwX1XiDzgRTUpgNd+/pDCz1qVl54SOyRM0qieTIQEC tzvz7T3M8sE6xPS9fQkNs8gRRg6M5t2uQQUzsY3Bro+IdvRD8lzfDLrynjrWhk0e RauQUUVwDqEmzL3uNUrQsYCULf73LSH4Xog== Received: from aptaippmta01.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com [103.229.16.4]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44s5w4cp9y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Feb 2025 10:45:47 +0000 (GMT) Received: from pps.filterd (APTAIPPMTA01.qualcomm.com [127.0.0.1]) by APTAIPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTP id 51EAjjqe010489; Fri, 14 Feb 2025 10:45:45 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APTAIPPMTA01.qualcomm.com (PPS) with ESMTPS id 44p0bm4h34-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Feb 2025 10:45:45 +0000 Received: from APTAIPPMTA01.qualcomm.com (APTAIPPMTA01.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 51EAjjC6010482; Fri, 14 Feb 2025 10:45:45 GMT Received: from cbsp-sh-gv.ap.qualcomm.com (CBSP-SH-gv.ap.qualcomm.com [10.231.249.68]) by APTAIPPMTA01.qualcomm.com (PPS) with ESMTPS id 51EAjiqF010480 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Feb 2025 10:45:45 +0000 Received: by cbsp-sh-gv.ap.qualcomm.com (Postfix, from userid 4635958) id 7357B40BE6; Fri, 14 Feb 2025 18:45:43 +0800 (CST) From: Wenbin Yao To: vkoul@kernel.org, kishon@kernel.org, p.zabel@pengutronix.de, dmitry.baryshkov@linaro.org, abel.vesa@linaro.org, quic_qianyu@quicinc.com, neil.armstrong@linaro.org, manivannan.sadhasivam@linaro.org, quic_devipriy@quicinc.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Wenbin Yao Subject: [PATCH v3 0/2] phy: qcom: qmp-pcie: Add PCIe PHY no_csr reset support Date: Fri, 14 Feb 2025 18:45:37 +0800 Message-Id: <20250214104539.281846-1-quic_wenbyao@quicinc.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 3SCmvXt0MfeKsmlQCMbwqjt3aQBkhBti X-Proofpoint-ORIG-GUID: 3SCmvXt0MfeKsmlQCMbwqjt3aQBkhBti X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-14_04,2025-02-13_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 mlxlogscore=999 priorityscore=1501 adultscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502140078 The series aims to skip phy register programming and drive PCIe PHY with register setting programmed in bootloader by simply toggling no_csr reset, which once togglled, PHY hardware will be reset while PHY registers are retained. First, determine whether PHY setting can be skipped by checking QPHY_START_CTRL register and the existence of nocsr reset. If it is programmed and no_csr reset is supported, do no_csr reset and skip BCR reset which will reset entire PHY. This series also remove has_nocsr_reset flag in qmp_phy_cfg structure and decide whether the PHY supports nocsr reset by checking the existence of nocsr reset in device tree. The series are tested on X1E80100-QCP and HDK8550. The commit messages of this patchset have been modified based on comments and suggestions. Changes in v3: - Replace devm_reset_control_get_exclusive with devm_reset_control_get_optional_exclusive when get phy_nocsr reset control in Patch 1/2. - Do not ignore -EINVAL when get phy_nocsr reset control in Patch 1/2. - Replace phy_initialized with skip_init in struct qmp_pcie in Patch 2/2. - Add a comment to why not check qmp->skip_init in function qmp_pcie_power_off in Patch 2/2. - Link to v2: https://lore.kernel.org/all/20250211094231.1813558-1-quic_wenbyao@quicinc.com/ Changes in v2: - Add Abel's and Manivannan's Reviewed-by tag to Patch 1/2. - Refine commit msg of Patch 2/2. - Link to v1: https://lore.kernel.org/all/20250121094140.4006801-1-quic_wenbyao@quicinc.com/ Konrad Dybcio (1): phy: qcom: pcie: Determine has_nocsr_reset dynamically Qiang Yu (1): phy: qcom: qmp-pcie: Add PHY register retention support drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 113 ++++++++++++++--------- 1 file changed, 67 insertions(+), 46 deletions(-) base-commit: bcf2acd8f64b0a5783deeeb5fd70c6163ec5acd7