From patchwork Wed Jan 16 10:50:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Gonzalez X-Patchwork-Id: 10765725 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 666B16C2 for ; Wed, 16 Jan 2019 11:01:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 53C852D4D8 for ; Wed, 16 Jan 2019 11:01:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 47A982D6E9; Wed, 16 Jan 2019 11:01:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F28BF2D4D8 for ; Wed, 16 Jan 2019 11:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389499AbfAPLBT (ORCPT ); Wed, 16 Jan 2019 06:01:19 -0500 Received: from smtp3-g21.free.fr ([212.27.42.3]:23960 "EHLO smtp3-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731772AbfAPLBT (ORCPT ); Wed, 16 Jan 2019 06:01:19 -0500 Received: from [192.168.108.68] (unknown [213.36.7.13]) (Authenticated sender: marc.w.gonzalez) by smtp3-g21.free.fr (Postfix) with ESMTPSA id CDA2F13F8E8; Wed, 16 Jan 2019 12:01:06 +0100 (CET) To: MSM Cc: LKML , Jeffrey Hugo , Bjorn Andersson , Andy Gross From: Marc Gonzalez Subject: [RFC PATCH v2 0/4] UFS on APQ8098 Message-ID: <88e04336-723f-c157-0384-c5054a73e0a4@free.fr> Date: Wed, 16 Jan 2019 11:50:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, After weeks (literally!) of poking the system at random, Jeffrey found why UFS refused to work on APQ8098: we were not setting the load on the vregs. Difference between v1 and v2: - New patch to add 'regulator-allow-set-load' prop to all vreg nodes - Rename rpmcc node to 'clock-controller' + Add Review tags - Drop UFS pinctrl gymnastics (not required, probably left enabled in bootloader) - Delete GCC_UFS_ICE_CORE_CLK (ICE not used upstream, I think) - Fix sizes of ufsphy register areas based on Jeffrey's feedback - Hack ufshcd_set_vccq_rail_unused into a NOP to work around lock up + reboot Marc Gonzalez (4): arm64: dts: qcom: msm8998: Add rpmcc node arm64: dts: qcom: msm8998: Add UFS nodes Add regulator-allow-set-load ufshcd_set_vccq_rail_unused locks up the board arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 52 +++++++++++++++++ arch/arm64/boot/dts/qcom/msm8998.dtsi | 69 +++++++++++++++++++++++ drivers/scsi/ufs/ufshcd.c | 1 + 3 files changed, 122 insertions(+)