| Message ID | 1392729681-21022-2-git-send-email-iivanov@mm-sol.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Tue, Feb 18, 2014 at 03:21:19PM +0200, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" <iivanov@mm-sol.com> > > Document device tree binding information as required by > the Qualcomm USB controller. > > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> > --- > .../devicetree/bindings/usb/msm-hsusb.txt | 17 +++++++++++++++++ Is this really the appropriate place to document this? It seems like this binding doc should be merged with the i.MX ci13xxx binding in a common ci13xxx doc.
Hi, On Tue, 2014-02-18 at 10:13 -0600, Josh Cartwright wrote: > On Tue, Feb 18, 2014 at 03:21:19PM +0200, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" <iivanov@mm-sol.com> > > > > Document device tree binding information as required by > > the Qualcomm USB controller. > > > > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> > > --- > > .../devicetree/bindings/usb/msm-hsusb.txt | 17 +++++++++++++++++ > > Is this really the appropriate place to document this? It seems like > this binding doc should be merged with the i.MX ci13xxx binding in a > common ci13xxx doc. > This driver is a "glue" layer driver which control Qualcomm specific logic around Chipidea IP core. It is supposed to hold "non standard" Chipidea properties, but I suppose that ci-hdrc-qcom.txt will be better name and will be similar to i.MX chosen name. What do you think? Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 18, 2014 at 07:27:00PM +0200, Ivan T. Ivanov wrote: > On Tue, 2014-02-18 at 10:13 -0600, Josh Cartwright wrote: > > On Tue, Feb 18, 2014 at 03:21:19PM +0200, Ivan T. Ivanov wrote: > > > .../devicetree/bindings/usb/msm-hsusb.txt | 17 +++++++++++++++++ > > > > Is this really the appropriate place to document this? It seems like > > this binding doc should be merged with the i.MX ci13xxx binding in a > > common ci13xxx doc. > > > > This driver is a "glue" layer driver which control Qualcomm > specific logic around Chipidea IP core. It is supposed to > hold "non standard" Chipidea properties, but I suppose that > ci-hdrc-qcom.txt will be better name and will be similar to > i.MX chosen name. > > What do you think? Sounds like an improvement to me.
On Tue, Feb 18, 2014 at 02:21:19PM +0100, Ivan T. Ivanov wrote: > From: "Ivan T. Ivanov" <iivanov@mm-sol.com> > > Document device tree binding information as required by > the Qualcomm USB controller. > > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> > --- > .../devicetree/bindings/usb/msm-hsusb.txt | 17 +++++++++++++++++ Although you mentioned to Josh that this is intended for "non-standard" Chipidea properties, I don't see any other than requiring that 'dr_mode' must be "peripheral". It would seem that this should all be integrated into a ci3xxx.txt. > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree/bindings/usb/msm-hsusb.txt > index 5ea26c6..d4e7e41 100644 > --- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt > +++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt > @@ -15,3 +15,20 @@ Example EHCI controller device node: > usb-phy = <&usb_otg>; > }; > > +CI13xxx (Chipidea) USB controllers > + > +Required properties: > +- compatible: should contain "qcom,ci-hdrc" Is there nothing more specific you could put here? Maybe a hardware revision, or something? > +- reg: offset and length of the register set in the memory map > +- interrupts: interrupt-specifier for the controller interrupt. > +- usb-phy: phandle for the PHY device > +- dr_mode: Sould be "peripheral" s/Sould/should/ -Courtney -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Tue, 2014-02-18 at 13:26 -0800, Courtney Cavin wrote: > On Tue, Feb 18, 2014 at 02:21:19PM +0100, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" <iivanov@mm-sol.com> > > > > Document device tree binding information as required by > > the Qualcomm USB controller. > > > > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> > > --- > > .../devicetree/bindings/usb/msm-hsusb.txt | 17 +++++++++++++++++ > > Although you mentioned to Josh that this is intended for "non-standard" > Chipidea properties, I don't see any other than requiring that 'dr_mode' > must be "peripheral". It would seem that this should all be integrated > into a ci3xxx.txt. Hm, there is no ci3xxx.txt. The closest match is ci-hdrc-imx.txt. So it could be ci-hdrc-qcom.txt or my preferred name qcom,ci-hdrc.txt? > > +CI13xxx (Chipidea) USB controllers > > + > > +Required properties: > > +- compatible: should contain "qcom,ci-hdrc" > > Is there nothing more specific you could put here? Maybe a hardware > revision, or something? > I am not aware of any version numbers here, sorry. > > +- reg: offset and length of the register set in the memory map > > +- interrupts: interrupt-specifier for the controller interrupt. > > +- usb-phy: phandle for the PHY device > > +- dr_mode: Sould be "peripheral" > > s/Sould/should/ Thanks, Ivan > > -Courtney -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Feb 19, 2014 at 04:43:22PM +0100, Ivan T. Ivanov wrote: > > Hi, > > On Tue, 2014-02-18 at 13:26 -0800, Courtney Cavin wrote: > > On Tue, Feb 18, 2014 at 02:21:19PM +0100, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" <iivanov@mm-sol.com> > > > > > > Document device tree binding information as required by > > > the Qualcomm USB controller. > > > > > > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> > > > --- > > > .../devicetree/bindings/usb/msm-hsusb.txt | 17 +++++++++++++++++ > > > > Although you mentioned to Josh that this is intended for "non-standard" > > Chipidea properties, I don't see any other than requiring that 'dr_mode' > > must be "peripheral". It would seem that this should all be integrated > > into a ci3xxx.txt. > > Hm, there is no ci3xxx.txt. The closest match is ci-hdrc-imx.txt. > So it could be ci-hdrc-qcom.txt or my preferred name qcom,ci-hdrc.txt? Sorry, I was referring to ci13xxx-imx.txt, which was apparently moved to ci-hdrc-imx.txt. I was recommending to merge the two into one 'ci13xxx.txt', as this binding seems to be a new compatible for the same basic chip. Now perhaps 'ci-hdrc.txt'. Although I agree with Josh that this name should be changed, and I think either of your two suggestions would be acceptable, I would like to at least discuss the possibility of actually merging the two in this series. Comments? -Courtney -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, 2014-02-19 at 09:46 -0800, Courtney Cavin wrote: > On Wed, Feb 19, 2014 at 04:43:22PM +0100, Ivan T. Ivanov wrote: > > > > Hi, > > > > On Tue, 2014-02-18 at 13:26 -0800, Courtney Cavin wrote: > > > On Tue, Feb 18, 2014 at 02:21:19PM +0100, Ivan T. Ivanov wrote: > > > > From: "Ivan T. Ivanov" <iivanov@mm-sol.com> > > > > > > > > Document device tree binding information as required by > > > > the Qualcomm USB controller. > > > > > > > > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> > > > > --- > > > > .../devicetree/bindings/usb/msm-hsusb.txt | 17 +++++++++++++++++ > > > > > > Although you mentioned to Josh that this is intended for "non-standard" > > > Chipidea properties, I don't see any other than requiring that 'dr_mode' > > > must be "peripheral". It would seem that this should all be integrated > > > into a ci3xxx.txt. > > > > Hm, there is no ci3xxx.txt. The closest match is ci-hdrc-imx.txt. > > So it could be ci-hdrc-qcom.txt or my preferred name qcom,ci-hdrc.txt? > > Sorry, I was referring to ci13xxx-imx.txt, which was apparently moved to > ci-hdrc-imx.txt. I was recommending to merge the two into one > 'ci13xxx.txt', as this binding seems to be a new compatible for the same > basic chip. Now perhaps 'ci-hdrc.txt'. > > Although I agree with Josh that this name should be changed, and I think > either of your two suggestions would be acceptable, I would like to at > least discuss the possibility of actually merging the two in this > series. > > Comments? iMX version have required and recommender properties which are not meaningful for QCOM variant. I will prefer separate file. It depends on Freescale engineers (now in Cc:) Regards, Ivan > > -Courtney -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Hi, > > On Wed, 2014-02-19 at 09:46 -0800, Courtney Cavin wrote: > > On Wed, Feb 19, 2014 at 04:43:22PM +0100, Ivan T. Ivanov wrote: > > > > > > Hi, > > > > > > On Tue, 2014-02-18 at 13:26 -0800, Courtney Cavin wrote: > > > > On Tue, Feb 18, 2014 at 02:21:19PM +0100, Ivan T. Ivanov wrote: > > > > > From: "Ivan T. Ivanov" <iivanov@mm-sol.com> > > > > > > > > > > Document device tree binding information as required by the > > > > > Qualcomm USB controller. > > > > > > > > > > Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com> > > > > > --- > > > > > .../devicetree/bindings/usb/msm-hsusb.txt | 17 > +++++++++++++++++ > > > > > > > > Although you mentioned to Josh that this is intended for "non- > standard" > > > > Chipidea properties, I don't see any other than requiring that > 'dr_mode' > > > > must be "peripheral". It would seem that this should all be > > > > integrated into a ci3xxx.txt. > > > > > > Hm, there is no ci3xxx.txt. The closest match is ci-hdrc-imx.txt. > > > So it could be ci-hdrc-qcom.txt or my preferred name qcom,ci-hdrc.txt? > > > > Sorry, I was referring to ci13xxx-imx.txt, which was apparently moved > > to ci-hdrc-imx.txt. I was recommending to merge the two into one > > 'ci13xxx.txt', as this binding seems to be a new compatible for the > > same basic chip. Now perhaps 'ci-hdrc.txt'. > > > > Although I agree with Josh that this name should be changed, and I > > think either of your two suggestions would be acceptable, I would like > > to at least discuss the possibility of actually merging the two in > > this series. > > > > Comments? > > > iMX version have required and recommender properties which are not > meaningful for QCOM variant. I will prefer separate file. It depends on > Freescale engineers (now in Cc:) > > Unlike dwc3, there is no common dts entry for chipidea core, every platform uses its own dts to cover both common and platform-specific properties. I also have plan to use dwc3 style way for dts, but msm platform has still not used dts, I don't know how many msm platforms need to change, once you finish transferring msm to dts, I will split common and platform specific entry. Peter -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/usb/msm-hsusb.txt b/Documentation/devicetree/bindings/usb/msm-hsusb.txt index 5ea26c6..d4e7e41 100644 --- a/Documentation/devicetree/bindings/usb/msm-hsusb.txt +++ b/Documentation/devicetree/bindings/usb/msm-hsusb.txt @@ -15,3 +15,20 @@ Example EHCI controller device node: usb-phy = <&usb_otg>; }; +CI13xxx (Chipidea) USB controllers + +Required properties: +- compatible: should contain "qcom,ci-hdrc" +- reg: offset and length of the register set in the memory map +- interrupts: interrupt-specifier for the controller interrupt. +- usb-phy: phandle for the PHY device +- dr_mode: Sould be "peripheral" + + gadget@f9a55000 { + compatible = "qcom,ci-hdrc"; + reg = <0xf9a55000 0x400>; + dr_mode = "peripheral"; + interrupts = <0 134 0>; + usb-phy = <&usb_otg>; + }; +