From patchwork Wed Jul 16 11:39:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: pramod.gurav.etc@gmail.com X-Patchwork-Id: 4566591 Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 85C1EC0515 for ; Wed, 16 Jul 2014 11:36:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B61FD2017D for ; Wed, 16 Jul 2014 11:36:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB95E201BA for ; Wed, 16 Jul 2014 11:36:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756244AbaGPLgg (ORCPT ); Wed, 16 Jul 2014 07:36:36 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:51334 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757134AbaGPLgf (ORCPT ); Wed, 16 Jul 2014 07:36:35 -0400 Received: by mail-pa0-f51.google.com with SMTP id ey11so1147752pad.24 for ; Wed, 16 Jul 2014 04:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=YIR2IkdlUSuXhbk4WCpenSBOAQnsi69nmr+TQFGURpc=; b=bOJAbQNK0do/SBx6KT4NLahSap8OVxdfvE4GeN96E+JgTcLwzZG0aY4VaJjtRmwoVj 3PSNVJ2Ggqy2RUst6pDNyCI5MNTu9zfLm7hvnk/V1mM0O2i5DOaLXZvHSWfTnZVIlRKc vc893EOhtUwmx8TVGWkREu87SsEwmYnxPz+Vo+tm/ry3xDBDGAI+Y5m/VmLkqturU9Hz 4Jv64sMtJLUmHzCikUNZMghjFCKCW/Q+rEfbhuGMUyPqk2gq/jHy7FFHgvesuwGTMBO2 KXX9B65bqYnzH/Oh5ABpu1mP33tr1RYtogUNg2SI9HIHltr2iedT88CVa/9AP69TXBMk dmTw== X-Received: by 10.68.106.194 with SMTP id gw2mr29131935pbb.85.1405510594811; Wed, 16 Jul 2014 04:36:34 -0700 (PDT) Received: from SPINITLTDL00278.smartplayin.local ([220.227.185.53]) by mx.google.com with ESMTPSA id ga1sm16784089pbb.82.2014.07.16.04.36.31 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 16 Jul 2014 04:36:33 -0700 (PDT) From: pramod.gurav.etc@gmail.com To: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: Pramod Gurav , Josh Cartwright , Mark Brown Subject: [PATCH] regmap: Kconfig: Select SPMI when REGMAP_SPMI is selected Date: Wed, 16 Jul 2014 17:09:57 +0530 Message-Id: <1405510797-755-1-git-send-email-pramod.gurav.etc@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Pramod Gurav REGMAP_SPMI module calls some functions from SPMI hence build breaks when SPMI is not enabled while compiling REGMAP_SPMI with below linker errors: drivers/built-in.o: In function `regmap_spmi_ext_read': :(.text+0x1143ec): undefined reference to `spmi_ext_register_read' :(.text+0x11443c): undefined reference to `spmi_ext_register_readl' drivers/built-in.o: In function `regmap_spmi_ext_gather_write': :(.text+0x1144c4): undefined reference to `spmi_ext_register_write' :(.text+0x114520): undefined reference to `spmi_ext_register_writel' drivers/built-in.o: In function `regmap_spmi_base_read': :(.text+0x1145b8): undefined reference to `spmi_register_read' drivers/built-in.o: In function `regmap_spmi_base_gather_write': :(.text+0x114630): undefined reference to `spmi_register_write' :(.text+0x11465c): undefined reference to `spmi_register_zero_write' Signed-off-by: Pramod Gurav CC: Josh Cartwright CC: Mark Brown --- This was found when I enabled support for Qualcomm QPNP PMICs and was compiling it. It selects REGMAP_SPMI and hence the crash. drivers/base/regmap/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig index 4251570..1aa9d71 100644 --- a/drivers/base/regmap/Kconfig +++ b/drivers/base/regmap/Kconfig @@ -16,6 +16,7 @@ config REGMAP_SPI tristate config REGMAP_SPMI + select SPMI tristate config REGMAP_MMIO