From patchwork Mon Sep 29 10:32:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dolev Raviv X-Patchwork-Id: 4995341 Return-Path: X-Original-To: patchwork-linux-arm-msm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6D8B29F2BA for ; Mon, 29 Sep 2014 10:33:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9642A202E5 for ; Mon, 29 Sep 2014 10:33:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBE8B20274 for ; Mon, 29 Sep 2014 10:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514AbaI2Kds (ORCPT ); Mon, 29 Sep 2014 06:33:48 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:50417 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507AbaI2Kds (ORCPT ); Mon, 29 Sep 2014 06:33:48 -0400 Received: from smtp.codeaurora.org (localhost [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id DC8F2140C2A; Mon, 29 Sep 2014 10:33:47 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 486) id D0057140C29; Mon, 29 Sep 2014 10:33:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lx-draviv2.mea.qualcomm.com (unknown [185.23.60.4]) (using TLSv1.1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: draviv@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id DFE8F140C26; Mon, 29 Sep 2014 10:33:45 +0000 (UTC) From: Dolev Raviv To: James.Bottomley@HansenPartnership.com, hch@infradead.org Cc: linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, santoshsy@gmail.com, merez@codeaurora.org, Dolev Raviv Subject: [PATCH 2/2] scsi: ufs: fix sparse warning Date: Mon, 29 Sep 2014 13:32:43 +0300 Message-Id: <1411986763-7389-2-git-send-email-draviv@codeaurora.org> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1411986763-7389-1-git-send-email-draviv@codeaurora.org> References: <1411986763-7389-1-git-send-email-draviv@codeaurora.org> X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes newly introduced sparse warning, introduced by UFS power management series. Sparse warning: >> drivers/scsi/ufs/ufshcd.c:1867:5: sparse: symbol 'ufshcd_uic_pwr_ctrl' was not declared. Should it be static? >> drivers/scsi/ufs/ufshcd.c:2025:5: sparse: symbol 'ufshcd_change_power_mode' was not declared. Should it be static? Signed-off-by: Dolev Raviv diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 5c78c3d..497c38a 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -2146,7 +2146,7 @@ EXPORT_SYMBOL_GPL(ufshcd_dme_get_attr); * * Returns 0 on success, non-zero value on failure */ -int ufshcd_uic_pwr_ctrl(struct ufs_hba *hba, struct uic_command *cmd) +static int ufshcd_uic_pwr_ctrl(struct ufs_hba *hba, struct uic_command *cmd) { struct completion uic_async_done; unsigned long flags; @@ -2309,7 +2309,7 @@ static int ufshcd_get_max_pwr_mode(struct ufs_hba *hba) return 0; } -int ufshcd_change_power_mode(struct ufs_hba *hba, +static int ufshcd_change_power_mode(struct ufs_hba *hba, struct ufs_pa_layer_attr *pwr_mode) { int ret;