diff mbox

[1/7] ARM: dts: qcom: Add PM8841 functions device nodes

Message ID 1427900715-26273-2-git-send-email-ivan.ivanov@linaro.org (mailing list archive)
State Superseded, archived
Headers show

Commit Message

Ivan T. Ivanov April 1, 2015, 3:05 p.m. UTC
Add configuration nodes for multi purpose pins and
thermal sensor devices. Thermal sensor will report
PMIC die temperature.

Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
---
 arch/arm/boot/dts/qcom-pm8841.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Kumar Gala April 1, 2015, 7:54 p.m. UTC | #1
On Apr 1, 2015, at 10:05 AM, Ivan T. Ivanov <ivan.ivanov@linaro.org> wrote:

> Add configuration nodes for multi purpose pins and
> thermal sensor devices. Thermal sensor will report
> PMIC die temperature.
> 
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> ---
> arch/arm/boot/dts/qcom-pm8841.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-pm8841.dtsi b/arch/arm/boot/dts/qcom-pm8841.dtsi
> index 73813cc..5c109bd 100644
> --- a/arch/arm/boot/dts/qcom-pm8841.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8841.dtsi
> @@ -7,6 +7,20 @@
> 		reg = <0x4 SPMI_USID>;
> 		#address-cells = <1>;
> 		#size-cells = <0>;
> +
> +		pm8841_mpps: mpps@a000 {
> +			compatible = "qcom,pm8841-mpp";
> +			reg = <0xa000 0x400>;
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			interrupts = <4 0xa0 0 0>, <4 0xa1 0 0>, <4 0xa2 0 0>, <4 0xa3 0 0>;

What’s the interrupt parent here with 4 cells? Can we cleanup the last cell to use proper define for level/edge etc.

> +		};
> +
> +		temp-alarm@2400 {
> +			compatible = "qcom,spmi-temp-alarm";
> +			reg = <0x2400 0x100>;
> +			interrupts = <4 0x24 0 IRQ_TYPE_EDGE_RISING>;
> +		};
> 	};
> 
> 	usid5: pm8841@5 {
> --
> 1.9.1
>
Ivan T. Ivanov April 8, 2015, 7:07 a.m. UTC | #2
On Wed, 2015-04-01 at 14:54 -0500, Kumar Gala wrote:
> On Apr 1, 2015, at 10:05 AM, Ivan T. Ivanov ivanov@linaro.org> wrote:
> 
> > Add configuration nodes for multi purpose pins and
> > thermal sensor devices. Thermal sensor will report
> > PMIC die temperature.
> > 
> > Signed-off-by: Ivan T. Ivanov ivanov@linaro.org>
> > ---
> > arch/arm/boot/dts/qcom-pm8841.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-pm8841.dtsi b/arch/arm/boot/dts/qcom-pm8841.dtsi
> > index 73813cc..5c109bd 100644
> > --- a/arch/arm/boot/dts/qcom-pm8841.dtsi
> > +++ b/arch/arm/boot/dts/qcom-pm8841.dtsi
> > @@ -7,6 +7,20 @@
> >                 reg = <0x4 SPMI_USID>;
> >                 #address-cells = <1>;
> >                 #size-cells = <0>;
> > +
> > +               pm8841_mpps: mpps@a000 {
> > +                       compatible = "qcom,pm8841-mpp";
> > +                       reg = <0xa000 0x400>;
> > +                       gpio-controller;
> > +                       #gpio-cells = <2>;
> > +                       interrupts = <4 0xa0 0 0>, <4 0xa1 0 0>, <4 0xa2 0 0>, <4 0xa3 0 0>;
> 
> What’s the interrupt parent here with 4 cells? 

SPMI PMIC Arbiter controller.

Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/qcom-pm8841.dtsi b/arch/arm/boot/dts/qcom-pm8841.dtsi
index 73813cc..5c109bd 100644
--- a/arch/arm/boot/dts/qcom-pm8841.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8841.dtsi
@@ -7,6 +7,20 @@ 
 		reg = <0x4 SPMI_USID>;
 		#address-cells = <1>;
 		#size-cells = <0>;
+
+		pm8841_mpps: mpps@a000 {
+			compatible = "qcom,pm8841-mpp";
+			reg = <0xa000 0x400>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupts = <4 0xa0 0 0>, <4 0xa1 0 0>, <4 0xa2 0 0>, <4 0xa3 0 0>;
+		};
+
+		temp-alarm@2400 {
+			compatible = "qcom,spmi-temp-alarm";
+			reg = <0x2400 0x100>;
+			interrupts = <4 0x24 0 IRQ_TYPE_EDGE_RISING>;
+		};
 	};

 	usid5: pm8841@5 {