diff mbox

[v3,2/5] regulator: qcom: Don't enable DRMS in driver

Message ID 1428363240-2027-3-git-send-email-bjorn.andersson@sonymobile.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Bjorn Andersson April 6, 2015, 11:33 p.m. UTC 
The driver itself should not flag regulators as being DRMS compatible,
this should come from board or dt files.

Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---

No changes since v2

 drivers/regulator/qcom_rpm-regulator.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Mark Brown April 7, 2015, 11:11 a.m. UTC | #1 
On Mon, Apr 06, 2015 at 04:33:57PM -0700, Bjorn Andersson wrote:
> The driver itself should not flag regulators as being DRMS compatible,
> this should come from board or dt files.

I'm missing patch 1, please check and resend.
Bjorn Andersson April 7, 2015, 1:45 p.m. UTC | #2 
On Tue, Apr 7, 2015 at 4:11 AM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Apr 06, 2015 at 04:33:57PM -0700, Bjorn Andersson wrote:
>> The driver itself should not flag regulators as being DRMS compatible,
>> this should come from board or dt files.
>
> I'm missing patch 1, please check and resend.

Looks like I forgot to add you as a recipient, sorry about that...
Lee answered earlier today that he applied the patch, as you can see here [1].

[1] https://patchwork.kernel.org/patch/6166461/

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
index 15e07c2..ddca8cb 100644
--- a/drivers/regulator/qcom_rpm-regulator.c
+++ b/drivers/regulator/qcom_rpm-regulator.c
@@ -732,10 +732,6 @@  static int rpm_reg_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-	/* Regulators with ia property suppports drms */
-	if (vreg->parts->ia.mask)
-		initdata->constraints.valid_ops_mask |= REGULATOR_CHANGE_DRMS;
-
 	key = "bias-pull-down";
 	if (of_property_read_bool(pdev->dev.of_node, key)) {
 		ret = rpm_reg_set(vreg, &vreg->parts->pd, 1);