| Message ID | 1446156594-25200-1-git-send-email-bjorn.andersson@sonymobile.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On 10/29/2015 03:09 PM, Bjorn Andersson wrote: > With the removal of VLAIS the size was incorrectly changed to only cover > the headers of the packet, resulting in "empty" requests being sent to > the RPM. Correct this so the entire message is transfered. > > Fixes: 50e1b29b4438 ("soc: qcom: smd: Remove use of VLAIS") > Cc: Stephen Boyd <sboyd@codeaurora.org> > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> I thought this was already merged though.
On Thu, Oct 29, 2015 at 03:50:09PM -0700, Stephen Boyd wrote: > On 10/29/2015 03:09 PM, Bjorn Andersson wrote: > > With the removal of VLAIS the size was incorrectly changed to only cover > > the headers of the packet, resulting in "empty" requests being sent to > > the RPM. Correct this so the entire message is transfered. > > > > Fixes: 50e1b29b4438 ("soc: qcom: smd: Remove use of VLAIS") > > Cc: Stephen Boyd <sboyd@codeaurora.org> > > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> > > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> > > I thought this was already merged though. I accidentally dropped my fixup for this during one of the rebases.
diff --git a/drivers/soc/qcom/smd-rpm.c b/drivers/soc/qcom/smd-rpm.c index 1ee02d2587b2..2969321e1b09 100644 --- a/drivers/soc/qcom/smd-rpm.c +++ b/drivers/soc/qcom/smd-rpm.c @@ -132,7 +132,7 @@ int qcom_rpm_smd_write(struct qcom_smd_rpm *rpm, pkt->req.data_len = cpu_to_le32(count); memcpy(pkt->payload, buf, count); - ret = qcom_smd_send(rpm->rpm_channel, pkt, sizeof(*pkt)); + ret = qcom_smd_send(rpm->rpm_channel, pkt, size); if (ret) goto out;
With the removal of VLAIS the size was incorrectly changed to only cover the headers of the packet, resulting in "empty" requests being sent to the RPM. Correct this so the entire message is transfered. Fixes: 50e1b29b4438 ("soc: qcom: smd: Remove use of VLAIS") Cc: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> --- drivers/soc/qcom/smd-rpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)