| Message ID | 1475375919-618-4-git-send-email-jmcnicol@redhat.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On Sat, Oct 01, 2016 at 07:38:30PM -0700, Jeremy McNicoll wrote: > The paren_map is used for looking up which value to write into > and the cmd_rcgr is for configuring the parent muxing so a change > 2 to 5 means that the 3rd parent should be mux #5 rather than #2. > > Signed-off-by: Jeremy McNicoll <jeremymc@redhat.com> > --- > drivers/clk/qcom/gcc-msm8994.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This should be squashed. > > diff --git a/drivers/clk/qcom/gcc-msm8994.c b/drivers/clk/qcom/gcc-msm8994.c > index 3897cfd..39b40d4 100644 > --- a/drivers/clk/qcom/gcc-msm8994.c > +++ b/drivers/clk/qcom/gcc-msm8994.c > @@ -50,7 +50,7 @@ static const char * const gcc_xo_gpll0[] = { > static const struct parent_map gcc_xo_gpll0_gpll4_map[] = { > { P_XO, 0 }, > { P_GPLL0, 1 }, > - { P_GPLL4, 2 }, > + { P_GPLL4, 5 }, > }; > > static const char * const gcc_xo_gpll0_gpll4[] = { > -- > 2.6.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2016-10-08 6:28 PM, Rob Herring wrote: > On Sat, Oct 01, 2016 at 07:38:30PM -0700, Jeremy McNicoll wrote: >> The paren_map is used for looking up which value to write into >> and the cmd_rcgr is for configuring the parent muxing so a change >> 2 to 5 means that the 3rd parent should be mux #5 rather than #2. >> >> Signed-off-by: Jeremy McNicoll <jeremymc@redhat.com> >> --- >> drivers/clk/qcom/gcc-msm8994.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > This should be squashed. > It was done this way explicitly as I am not the original author and felt it was important that the description / explanation was properly captured. -jeremy >> >> diff --git a/drivers/clk/qcom/gcc-msm8994.c b/drivers/clk/qcom/gcc-msm8994.c >> index 3897cfd..39b40d4 100644 >> --- a/drivers/clk/qcom/gcc-msm8994.c >> +++ b/drivers/clk/qcom/gcc-msm8994.c >> @@ -50,7 +50,7 @@ static const char * const gcc_xo_gpll0[] = { >> static const struct parent_map gcc_xo_gpll0_gpll4_map[] = { >> { P_XO, 0 }, >> { P_GPLL0, 1 }, >> - { P_GPLL4, 2 }, >> + { P_GPLL4, 5 }, >> }; >> >> static const char * const gcc_xo_gpll0_gpll4[] = { >> -- >> 2.6.1 >> -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2016-10-10 3:04 PM, Jeremy McNicoll wrote: > On 2016-10-08 6:28 PM, Rob Herring wrote: >> On Sat, Oct 01, 2016 at 07:38:30PM -0700, Jeremy McNicoll wrote: >>> The paren_map is used for looking up which value to write into >>> and the cmd_rcgr is for configuring the parent muxing so a change >>> 2 to 5 means that the 3rd parent should be mux #5 rather than #2. >>> >>> Signed-off-by: Jeremy McNicoll <jeremymc@redhat.com> >>> --- >>> drivers/clk/qcom/gcc-msm8994.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> This should be squashed. >> > > It was done this way explicitly as I am not the original author and Just to make sure its clear. I am not the original author of this patch: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-July/442801.html -jeremy > felt it was important that the description / explanation was properly > captured. > > -jeremy > >>> >>> diff --git a/drivers/clk/qcom/gcc-msm8994.c >>> b/drivers/clk/qcom/gcc-msm8994.c >>> index 3897cfd..39b40d4 100644 >>> --- a/drivers/clk/qcom/gcc-msm8994.c >>> +++ b/drivers/clk/qcom/gcc-msm8994.c >>> @@ -50,7 +50,7 @@ static const char * const gcc_xo_gpll0[] = { >>> static const struct parent_map gcc_xo_gpll0_gpll4_map[] = { >>> { P_XO, 0 }, >>> { P_GPLL0, 1 }, >>> - { P_GPLL4, 2 }, >>> + { P_GPLL4, 5 }, >>> }; >>> >>> static const char * const gcc_xo_gpll0_gpll4[] = { >>> -- >>> 2.6.1 >>> > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/clk/qcom/gcc-msm8994.c b/drivers/clk/qcom/gcc-msm8994.c index 3897cfd..39b40d4 100644 --- a/drivers/clk/qcom/gcc-msm8994.c +++ b/drivers/clk/qcom/gcc-msm8994.c @@ -50,7 +50,7 @@ static const char * const gcc_xo_gpll0[] = { static const struct parent_map gcc_xo_gpll0_gpll4_map[] = { { P_XO, 0 }, { P_GPLL0, 1 }, - { P_GPLL4, 2 }, + { P_GPLL4, 5 }, }; static const char * const gcc_xo_gpll0_gpll4[] = {
The paren_map is used for looking up which value to write into and the cmd_rcgr is for configuring the parent muxing so a change 2 to 5 means that the 3rd parent should be mux #5 rather than #2. Signed-off-by: Jeremy McNicoll <jeremymc@redhat.com> --- drivers/clk/qcom/gcc-msm8994.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)