From patchwork Wed Nov 16 01:19:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sarangdhar Joshi X-Patchwork-Id: 9430755 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0AF1160755 for ; Wed, 16 Nov 2016 01:20:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EC99D28725 for ; Wed, 16 Nov 2016 01:20:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E0F2F28D19; Wed, 16 Nov 2016 01:20:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 51EFA28736 for ; Wed, 16 Nov 2016 01:20:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932203AbcKPBTx (ORCPT ); Tue, 15 Nov 2016 20:19:53 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:40584 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754598AbcKPBTp (ORCPT ); Tue, 15 Nov 2016 20:19:45 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 3E38C61616; Wed, 16 Nov 2016 01:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1479259184; bh=P73d43E61hiy+NF5F6zUEpE0SDhABY/qJOR7E6sihnM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bkYXhbve6DLQxy0G/ShVH9ShZ88N7c52df7hy5hI0iAMh15Dg8fnOPfObMHqvV0Rq 7nejntJC+z+rxLQcDNLjlZP7ePKRgHdV+I84XMYAOIOF+me6tEshpc+Q8os/cSYwez YMRyWaT9uGtOe3HGy/HgMpy++4/xl8tkV8o3Rq6k= Received: from spjoshi-linux.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: spjoshi@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8A6E761615; Wed, 16 Nov 2016 01:19:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1479259183; bh=P73d43E61hiy+NF5F6zUEpE0SDhABY/qJOR7E6sihnM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Xo1IyvrH/nIwYHedvOVUQHtPFxgul6did7d3K7QjL2wZ2Kgd8+rhdUkieMiRluz6m 29shmEenicOj/9ty+C5KJVIYoFq2UGwWDWydJ7vkRTqFXsoiAsI0Cqr1l2LgEtW2D0 hDH5kvSBvtFOOpQMGTJwII4ov47suTOlqdl18Qdc= DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 8A6E761615 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=spjoshi@codeaurora.org From: Sarangdhar Joshi To: Andy Gross , David Brown Cc: Sarangdhar Joshi , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Jordan Crouse , Stephen Boyd , Trilok Soni Subject: [PATCH v3 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails Date: Tue, 15 Nov 2016 17:19:25 -0800 Message-Id: <1479259165-1601-4-git-send-email-spjoshi@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1479259165-1601-1-git-send-email-spjoshi@codeaurora.org> References: <1479259165-1601-1-git-send-email-spjoshi@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When devm_clk_get fails for core clock, the failure was ignored and the core_clk was explicitly set to NULL so that other remaining clocks can be queried. However, now that we have a cleaner way of expressing the clock dependency, return failure when devm_clk_get fails for core clock. Signed-off-by: Sarangdhar Joshi Reviewed-by: Stephen Boyd Acked-by: Bjorn Andersson --- drivers/firmware/qcom_scm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index ddf7c8b..0fbf2ea 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -395,10 +395,10 @@ static int qcom_scm_probe(struct platform_device *pdev) if (clks & SCM_HAS_CORE_CLK) { scm->core_clk = devm_clk_get(&pdev->dev, "core"); if (IS_ERR(scm->core_clk)) { - if (PTR_ERR(scm->core_clk) == -EPROBE_DEFER) - return PTR_ERR(scm->core_clk); - - scm->core_clk = NULL; + if (PTR_ERR(scm->core_clk) != -EPROBE_DEFER) + dev_err(&pdev->dev, + "failed to acquire core clk\n"); + return PTR_ERR(scm->core_clk); } }