| Message ID | 1483097531-9991-2-git-send-email-riteshh@codeaurora.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On Fri, Dec 30, 2016 at 05:02:09PM +0530, Ritesh Harjani wrote: > From: Sahitya Tummala <stummala@codeaurora.org> > > Add new host operation ->platform_dumpregs to provide a > mechanism through which host drivers can dump platform > specific registers in addition to SDHC registers > during error conditions. > > Signed-off-by: Sahitya Tummala <stummala@codeaurora.org> > Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org> > --- > drivers/mmc/host/sdhci.c | 3 +++ > drivers/mmc/host/sdhci.h | 1 + > 2 files changed, 4 insertions(+) > This change and 2/3 look like they can be squished together into one patch. At least that is how I did it, https://patchwork.kernel.org/patch/9442449/ -jeremy > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 2390980..73a8918 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -101,6 +101,9 @@ static void sdhci_dumpregs(struct sdhci_host *host) > readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); > } > > + if (host->ops->platform_dumpregs) > + host->ops->platform_dumpregs(host); > + > pr_err(DRIVER_NAME ": ===========================================\n"); > } > > diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > index 0b66f21..400f3a1 100644 > --- a/drivers/mmc/host/sdhci.h > +++ b/drivers/mmc/host/sdhci.h > @@ -564,6 +564,7 @@ struct sdhci_ops { > struct mmc_card *card, > unsigned int max_dtr, int host_drv, > int card_drv, int *drv_type); > + void (*platform_dumpregs)(struct sdhci_host *host); > }; > > #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS > -- > The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project. > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jeremy, Thanks for the review. On 1/14/2017 3:51 AM, Jeremy McNicoll wrote: > On Fri, Dec 30, 2016 at 05:02:09PM +0530, Ritesh Harjani wrote: >> From: Sahitya Tummala <stummala@codeaurora.org> >> >> Add new host operation ->platform_dumpregs to provide a >> mechanism through which host drivers can dump platform >> specific registers in addition to SDHC registers >> during error conditions. >> >> Signed-off-by: Sahitya Tummala <stummala@codeaurora.org> >> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org> >> --- >> drivers/mmc/host/sdhci.c | 3 +++ >> drivers/mmc/host/sdhci.h | 1 + >> 2 files changed, 4 insertions(+) >> > > This change and 2/3 look like they can be squished together into > one patch. At least that is how I did it, I felt it is better this way to keep sdhci and sdhci-msm patches separate. This patch provides mechanism and patch 3/3 provides implementation of ->platform_dumpregs in sdhci-msm. Regards Ritesh > > https://patchwork.kernel.org/patch/9442449/ > > -jeremy > > >> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c >> index 2390980..73a8918 100644 >> --- a/drivers/mmc/host/sdhci.c >> +++ b/drivers/mmc/host/sdhci.c >> @@ -101,6 +101,9 @@ static void sdhci_dumpregs(struct sdhci_host *host) >> readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); >> } >> >> + if (host->ops->platform_dumpregs) >> + host->ops->platform_dumpregs(host); >> + >> pr_err(DRIVER_NAME ": ===========================================\n"); >> } >> >> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h >> index 0b66f21..400f3a1 100644 >> --- a/drivers/mmc/host/sdhci.h >> +++ b/drivers/mmc/host/sdhci.h >> @@ -564,6 +564,7 @@ struct sdhci_ops { >> struct mmc_card *card, >> unsigned int max_dtr, int host_drv, >> int card_drv, int *drv_type); >> + void (*platform_dumpregs)(struct sdhci_host *host); >> }; >> >> #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS >> -- >> The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, >> a Linux Foundation Collaborative Project. >>
On Mon, Jan 16, 2017 at 07:45:48AM +0530, Ritesh Harjani wrote: > Hi Jeremy, > > Thanks for the review. > > On 1/14/2017 3:51 AM, Jeremy McNicoll wrote: > >On Fri, Dec 30, 2016 at 05:02:09PM +0530, Ritesh Harjani wrote: > >>From: Sahitya Tummala <stummala@codeaurora.org> > >> > >>Add new host operation ->platform_dumpregs to provide a > >>mechanism through which host drivers can dump platform > >>specific registers in addition to SDHC registers > >>during error conditions. > >> > >>Signed-off-by: Sahitya Tummala <stummala@codeaurora.org> > >>Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org> > >>--- > >> drivers/mmc/host/sdhci.c | 3 +++ > >> drivers/mmc/host/sdhci.h | 1 + > >> 2 files changed, 4 insertions(+) > >> > > > >This change and 2/3 look like they can be squished together into > >one patch. At least that is how I did it, > > I felt it is better this way to keep sdhci and sdhci-msm patches separate. > This patch provides mechanism and patch 3/3 provides > implementation of ->platform_dumpregs in sdhci-msm. > Alright, lets go with that approach. -jeremy > Regards > Ritesh > > > > > >https://patchwork.kernel.org/patch/9442449/ > > > >-jeremy > > > > > >>diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > >>index 2390980..73a8918 100644 > >>--- a/drivers/mmc/host/sdhci.c > >>+++ b/drivers/mmc/host/sdhci.c > >>@@ -101,6 +101,9 @@ static void sdhci_dumpregs(struct sdhci_host *host) > >> readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); > >> } > >> > >>+ if (host->ops->platform_dumpregs) > >>+ host->ops->platform_dumpregs(host); > >>+ > >> pr_err(DRIVER_NAME ": ===========================================\n"); > >> } > >> > >>diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h > >>index 0b66f21..400f3a1 100644 > >>--- a/drivers/mmc/host/sdhci.h > >>+++ b/drivers/mmc/host/sdhci.h > >>@@ -564,6 +564,7 @@ struct sdhci_ops { > >> struct mmc_card *card, > >> unsigned int max_dtr, int host_drv, > >> int card_drv, int *drv_type); > >>+ void (*platform_dumpregs)(struct sdhci_host *host); > >> }; > >> > >> #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS > >>-- > >>The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > >>a Linux Foundation Collaborative Project. > >> > > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 2390980..73a8918 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -101,6 +101,9 @@ static void sdhci_dumpregs(struct sdhci_host *host) readl(host->ioaddr + SDHCI_ADMA_ADDRESS)); } + if (host->ops->platform_dumpregs) + host->ops->platform_dumpregs(host); + pr_err(DRIVER_NAME ": ===========================================\n"); } diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index 0b66f21..400f3a1 100644 --- a/drivers/mmc/host/sdhci.h +++ b/drivers/mmc/host/sdhci.h @@ -564,6 +564,7 @@ struct sdhci_ops { struct mmc_card *card, unsigned int max_dtr, int host_drv, int card_drv, int *drv_type); + void (*platform_dumpregs)(struct sdhci_host *host); }; #ifdef CONFIG_MMC_SDHCI_IO_ACCESSORS