| Message ID | 1484030515-16722-4-git-send-email-riteshh@codeaurora.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On 10/01/17 08:41, Ritesh Harjani wrote: > print error log message and dump sdhc registers for debugging > purpose in case of data errors (except when tuning commands > generate CRC/timeout/end bit errors). It is a bit ugly and probably only useful during driver development, so I am not at all enthusiastic about this. > > Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org> > Signed-off-by: Asutosh Das <asutoshd@codeaurora.org> > --- > drivers/mmc/host/sdhci.c | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 73a8918..2e51e49 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -2616,9 +2616,26 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask) > host->ops->adma_workaround(host, intmask); > } > > - if (host->data->error) > + if (host->data->error) { > + bool pr_msg = true; > + > + if (intmask & (SDHCI_INT_DATA_CRC | SDHCI_INT_DATA_TIMEOUT | > + SDHCI_INT_DATA_END_BIT)) { > + command = SDHCI_GET_CMD(sdhci_readw(host, > + SDHCI_COMMAND)); > + if (command == MMC_SEND_TUNING_BLOCK_HS200 || > + command == MMC_SEND_TUNING_BLOCK) > + pr_msg = false; > + } > + if (pr_msg) { > + pr_err("%s: data txfr (0x%08x) error: %d\n", > + mmc_hostname(host->mmc), intmask, > + host->data->error); > + sdhci_dumpregs(host); > + } > + > sdhci_finish_data(host); > - else { > + } else { > if (intmask & (SDHCI_INT_DATA_AVAIL | SDHCI_INT_SPACE_AVAIL)) > sdhci_transfer_pio(host); > > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 73a8918..2e51e49 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2616,9 +2616,26 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask) host->ops->adma_workaround(host, intmask); } - if (host->data->error) + if (host->data->error) { + bool pr_msg = true; + + if (intmask & (SDHCI_INT_DATA_CRC | SDHCI_INT_DATA_TIMEOUT | + SDHCI_INT_DATA_END_BIT)) { + command = SDHCI_GET_CMD(sdhci_readw(host, + SDHCI_COMMAND)); + if (command == MMC_SEND_TUNING_BLOCK_HS200 || + command == MMC_SEND_TUNING_BLOCK) + pr_msg = false; + } + if (pr_msg) { + pr_err("%s: data txfr (0x%08x) error: %d\n", + mmc_hostname(host->mmc), intmask, + host->data->error); + sdhci_dumpregs(host); + } + sdhci_finish_data(host); - else { + } else { if (intmask & (SDHCI_INT_DATA_AVAIL | SDHCI_INT_SPACE_AVAIL)) sdhci_transfer_pio(host);