From patchwork Mon Jul 24 07:47:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varadarajan Narayanan X-Patchwork-Id: 9858945 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7256D600F5 for ; Mon, 24 Jul 2017 07:50:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6439128575 for ; Mon, 24 Jul 2017 07:50:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 590E82858A; Mon, 24 Jul 2017 07:50:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E0C2228575 for ; Mon, 24 Jul 2017 07:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752301AbdGXHsN (ORCPT ); Mon, 24 Jul 2017 03:48:13 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59284 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778AbdGXHsC (ORCPT ); Mon, 24 Jul 2017 03:48:02 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 8277C60AD6; Mon, 24 Jul 2017 07:48:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1500882481; bh=6K1odF5bVmJYk7L5UgrgIg4KTQO5xsJ+hsZ2pDb2lRs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O7RlqIbX6OJszmk0x5OF89gh9qJ7za/dtqUML05W1WBcPqvVt6WfZogQRtlQV9Nun uOwk7r3HDdOkxUHkLdAzEPJhtgw0pjPAHyA4s16h1lLR8gSMqnKUFpkjUIL0DuvoYz 9vfKgJmQT9xxDR/ViiH91atn6Xned3l2AG5/TTdM= Received: from varda-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: varada@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D7E7160AD6; Mon, 24 Jul 2017 07:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1500882480; bh=6K1odF5bVmJYk7L5UgrgIg4KTQO5xsJ+hsZ2pDb2lRs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jo17vJoio6nCV6auztsfVLKQbvHbuWZFKnu4nT2xvqZPDGidGfZERqKgcJAA3kTzg 4KECmAAvnsjwiOmmiNKs1AnJIeb8+BxmOJ0p7A8Jr7648wdJc97xld8w5DsNyKf05o VJA5VKMYyUDUASSeP8PBoqm9W5tltjAHF0g9zzjc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D7E7160AD6 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=varada@codeaurora.org From: Varadarajan Narayanan To: broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, andy.gross@linaro.org, david.brown@linaro.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org Cc: Varadarajan Narayanan Subject: [PATCH v5 05/14] spi: qup: Fix error handling in spi_qup_prep_sg Date: Mon, 24 Jul 2017 13:17:16 +0530 Message-Id: <1500882445-29008-6-git-send-email-varada@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1500882445-29008-1-git-send-email-varada@codeaurora.org> References: <1500882445-29008-1-git-send-email-varada@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Varadarajan Narayanan --- drivers/spi/spi-qup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index e6294f8..aa1b7b8 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -311,8 +311,8 @@ static int spi_qup_prep_sg(struct spi_master *master, struct spi_transfer *xfer, } desc = dmaengine_prep_slave_sg(chan, sgl, nents, dir, flags); - if (!desc) - return -EINVAL; + if (IS_ERR_OR_NULL(desc)) + return desc ? PTR_ERR(desc) : -EINVAL; desc->callback = callback; desc->callback_param = qup;