From patchwork Fri Jul 28 06:52:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varadarajan Narayanan X-Patchwork-Id: 9867963 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8568760382 for ; Fri, 28 Jul 2017 06:56:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 78F672888F for ; Fri, 28 Jul 2017 06:56:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6DCB1288A0; Fri, 28 Jul 2017 06:56:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 28EA62888F for ; Fri, 28 Jul 2017 06:56:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751595AbdG1Gxh (ORCPT ); Fri, 28 Jul 2017 02:53:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:35630 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751652AbdG1Gxd (ORCPT ); Fri, 28 Jul 2017 02:53:33 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 38F6A60A82; Fri, 28 Jul 2017 06:53:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1501224813; bh=aWiUWCbOGW11toDCz8Asq9vhMB/abh4TVKYk14ZPj9w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kZWhBFHByAlGqdqQgleificj16dB78MywjN1yPcPAlDh6rXp8/IsFTrEIvl2dySAb 0Hlce7op7TAAp5rZu3zNO4JxXw3HhEfPT7rDYlI78aqAhSwCDLHlJliKEPyudV1AEI oxaQB7wEpRP9rKNcfpDdVzvagot7dop+6AHqKimA= Received: from varda-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: varada@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 557C460A9A; Fri, 28 Jul 2017 06:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1501224812; bh=aWiUWCbOGW11toDCz8Asq9vhMB/abh4TVKYk14ZPj9w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VP2+Np+Qtvl7BEWGQAcSxRfSveijmL8gqiNjEKQHi1KeKJLkjwQheJQJJ3NorEeIv 89Sxp+LJvbr3zYc2muhVUhDinphLOn/kXWbOzSwf2xTbX9gKt+L0ishYSUEIzOKRBz Wyza2ZwFWf7rzdWrHrQYf8bwCb4emkxeJKx0XeTM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 557C460A9A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=varada@codeaurora.org From: Varadarajan Narayanan To: broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, andy.gross@linaro.org, david.brown@linaro.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org Cc: Varadarajan Narayanan Subject: [PATCH v6 05/14] spi: qup: Fix error handling in spi_qup_prep_sg Date: Fri, 28 Jul 2017 12:22:52 +0530 Message-Id: <1501224781-19519-6-git-send-email-varada@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1501224781-19519-1-git-send-email-varada@codeaurora.org> References: <1501224781-19519-1-git-send-email-varada@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Varadarajan Narayanan --- drivers/spi/spi-qup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c index f1aa5c1..ef95294 100644 --- a/drivers/spi/spi-qup.c +++ b/drivers/spi/spi-qup.c @@ -311,8 +311,8 @@ static int spi_qup_prep_sg(struct spi_master *master, struct spi_transfer *xfer, } desc = dmaengine_prep_slave_sg(chan, sgl, nents, dir, flags); - if (!desc) - return -EINVAL; + if (IS_ERR_OR_NULL(desc)) + return desc ? PTR_ERR(desc) : -EINVAL; desc->callback = callback; desc->callback_param = qup;