From patchwork Tue Dec 5 15:52:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loys Ollivier X-Patchwork-Id: 10093301 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1D11F60329 for ; Tue, 5 Dec 2017 15:52:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1728D283CA for ; Tue, 5 Dec 2017 15:52:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0BA082857E; Tue, 5 Dec 2017 15:52:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 67294283CA for ; Tue, 5 Dec 2017 15:52:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752762AbdLEPwr (ORCPT ); Tue, 5 Dec 2017 10:52:47 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34225 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752649AbdLEPwp (ORCPT ); Tue, 5 Dec 2017 10:52:45 -0500 Received: by mail-wr0-f194.google.com with SMTP id y21so819719wrc.1 for ; Tue, 05 Dec 2017 07:52:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=YuRDdFCYlx1zLr3hU5EnIdC0R90oi5ffZEI2QUBlh+w=; b=yxia3xnai5c4BHe3nhQIsO3LcLZYfGh8bfLkbWDCtOtnG9yfjwwHfTpCC1xk2QWOs5 TmX7eNUNczIWX6VQjRE+3VNgDTMbERTlMcsZFCO675q6LjYqgVywTF3jRgEeal7KddC7 We+cpGxAfxqH/REbAp3WICh/P70SnCk6Kp7FPmDGOT+EOvpRrOl25Zrgd250kwAS4fLt BBmFDBQ1Nubh+b9iD/r3/2qq5OmLYBHXUS2zMn7JQs4jk3SWsD1F9YbZ0aN6jqhJwyU0 rITgFGC2cPOlsq/ihmChM0ofrZ13hIrMXO5MDWCu6Q2HSL+FiOZPbqpPQLVfWjaRP+Ix jYGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YuRDdFCYlx1zLr3hU5EnIdC0R90oi5ffZEI2QUBlh+w=; b=h5axbR7VWPHHOtgd9iKke2eXk6YFVgx3fNcKG6+ZVD1hlYUe4ZRs6Cl2p+rZhAfw2X a+yDzWGssq+ZXxQa971klV9MHhT1uNWLHuww6dHHBEMfl/QCxsvEhYvvgMzob2e/D4DQ b3JveKMuky6gjbMHsA+v8IqZf8BVJNXC7or6Y0fDQ0Mdd2Uq7rNq9Ts0jfs9XOVD9dsl QKkZP/eLaznxP9XtcaL0yieToixprgDUqKbo+ExMZkA/NU2pmEdN5ogc1Xi3NHa80JQM gsp7J9ccp9bo1ypTpsAFlErSc/lEr0qXtkJXDd4kzLZr/RupU3ZAJTxivgZ8zBZCTEOH 7J/g== X-Gm-Message-State: AJaThX4IqHbUmzs50ZDRRIR0PIscgYovWssZ3a8sAwu8bTWgsP3mbNl+ 9TdCfH9AlhNM/7zqYGtOSJ1ztw== X-Google-Smtp-Source: AGs4zMYJ6GhxGFD1WBGCtxm13g/z2C7zDQQOtlNe6Z97ViQ+LdJNAi1YLvP+QW8UPBJQVQ34WBEqsQ== X-Received: by 10.223.176.121 with SMTP id g54mr17845469wra.165.1512489163913; Tue, 05 Dec 2017 07:52:43 -0800 (PST) Received: from loys-XPS-13-9360.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id j132sm11278632wmd.2.2017.12.05.07.52.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 05 Dec 2017 07:52:43 -0800 (PST) From: Loys Ollivier To: Andy Gross , David Brown Cc: Loys Ollivier , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Jerome Brunet Subject: [PATCH] firmware: qcom: scm: Fix incorrect of_node_put call in scm_init Date: Tue, 5 Dec 2017 16:52:14 +0100 Message-Id: <1512489134-28220-1-git-send-email-lollivier@baylibre.com> X-Mailer: git-send-email 2.7.4 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When using other platform architectures, in the init of the qcom_scm driver, of_node_put is called on /firmware if no qcom dt is found. This results in a kernel error: Bad of_node_put() on /firmware. The call to of_node_put from the qcom_scm init is unnecessary as of_find_matching_node is calling it automatically. Remove this of_node_put(). Fixes: d0f6fa7ba2d6 ("firmware: qcom: scm: Convert SCM to platform driver") Signed-off-by: Loys Ollivier --- drivers/firmware/qcom_scm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index af4c75217ea6..575930c80fba 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -633,7 +633,6 @@ static int __init qcom_scm_init(void) np = of_find_matching_node(fw_np, qcom_scm_dt_match); if (!np) { - of_node_put(fw_np); return -ENODEV; }