From patchwork Wed Jan 3 11:28:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manu Gautam X-Patchwork-Id: 10142125 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6789A601A1 for ; Wed, 3 Jan 2018 11:33:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5252A28FEC for ; Wed, 3 Jan 2018 11:33:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 46FC42906D; Wed, 3 Jan 2018 11:33:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DBC8228FEC for ; Wed, 3 Jan 2018 11:33:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752424AbeACL3q (ORCPT ); Wed, 3 Jan 2018 06:29:46 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:60330 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbeACL3o (ORCPT ); Wed, 3 Jan 2018 06:29:44 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CD1A66032D; Wed, 3 Jan 2018 11:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1514978983; bh=N8DkZ3j1ELZGew7rvPU0qbhVgQ/ANyXZUNDQeVPRVQ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AvBl912K5t+5yxlHELav/zN+XBMnJOF4R0VvP6WMesfIOWK+dhMgSeGevzZM2Xon5 emOTECbUiVrFleDsH5CF5v1uvZtq2aTVTM/Ho2f7r/yqgAJh3mmQTqkJq+DA0VXgbI ia4hfAVjkQgG7WnDxxFFz1oNdJbQW0LlWHUVYuJ0= Received: from mgautam-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9A10E60250; Wed, 3 Jan 2018 11:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1514978983; bh=N8DkZ3j1ELZGew7rvPU0qbhVgQ/ANyXZUNDQeVPRVQ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AvBl912K5t+5yxlHELav/zN+XBMnJOF4R0VvP6WMesfIOWK+dhMgSeGevzZM2Xon5 emOTECbUiVrFleDsH5CF5v1uvZtq2aTVTM/Ho2f7r/yqgAJh3mmQTqkJq+DA0VXgbI ia4hfAVjkQgG7WnDxxFFz1oNdJbQW0LlWHUVYuJ0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9A10E60250 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mgautam@codeaurora.org From: Manu Gautam To: Kishon Vijay Abraham I Cc: Felipe Balbi , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, Manu Gautam , Vivek Gautam , Varadarajan Narayanan , Wei Yongjun , Fengguang Wu , linux-kernel@vger.kernel.org (open list:GENERIC PHY FRAMEWORK) Subject: [PATCH v4 06/16] phy: qcom-qmp: Move SERDES/PCS START after PHY reset Date: Wed, 3 Jan 2018 16:58:39 +0530 Message-Id: <1514978930-31341-7-git-send-email-mgautam@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1514978930-31341-1-git-send-email-mgautam@codeaurora.org> References: <1514978930-31341-1-git-send-email-mgautam@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Driver is currently performing PHY reset after starting SERDES/PCS. As per hardware datasheet reset must be done before starting PHY. Hence, update the sequence. Signed-off-by: Manu Gautam --- drivers/phy/qualcomm/phy-qcom-qmp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index ecff261..edb6bbe 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -896,12 +896,12 @@ static int qcom_qmp_phy_init(struct phy *phy) if (cfg->has_pwrdn_delay) usleep_range(cfg->pwrdn_delay_min, cfg->pwrdn_delay_max); - /* start SerDes and Phy-Coding-Sublayer */ - qphy_setbits(pcs, cfg->regs[QPHY_START_CTRL], cfg->start_ctrl); - /* Pull PHY out of reset state */ qphy_clrbits(pcs, cfg->regs[QPHY_SW_RESET], SW_RESET); + /* start SerDes and Phy-Coding-Sublayer */ + qphy_setbits(pcs, cfg->regs[QPHY_START_CTRL], cfg->start_ctrl); + status = pcs + cfg->regs[QPHY_PCS_READY_STATUS]; mask = cfg->mask_pcs_ready;