From patchwork Mon Mar 12 13:15:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Abhishek Sahu X-Patchwork-Id: 10276263 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 32341602BD for ; Mon, 12 Mar 2018 13:16:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 225D3286D2 for ; Mon, 12 Mar 2018 13:16:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 169A828DD4; Mon, 12 Mar 2018 13:16:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 79705286D2 for ; Mon, 12 Mar 2018 13:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932407AbeCLNQF (ORCPT ); Mon, 12 Mar 2018 09:16:05 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42400 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932333AbeCLNQC (ORCPT ); Mon, 12 Mar 2018 09:16:02 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C3BDF60817; Mon, 12 Mar 2018 13:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1520860561; bh=w/HfNoLndR6Kxnp/XO8Ax/3l49bbjKgaZ/PL64w0Vh0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BNcoTXTLEvAcXHJat2u2CaDaCJQ5ZIX0NFWukTzbJwDtqi7prJ9WJ0xqRCQcRnkll ZBR1ZuEojQftI9GpdQawcQda/a75uez4wL+QbmgSfu3yKqgw3+K6DOCHsQmlasjXSd buWUruvYQUuhAo8Y6MVYlwqgM7MRe+tzudUI4bb8= Received: from absahu-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: absahu@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6CFA0603AF; Mon, 12 Mar 2018 13:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1520860561; bh=w/HfNoLndR6Kxnp/XO8Ax/3l49bbjKgaZ/PL64w0Vh0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BNcoTXTLEvAcXHJat2u2CaDaCJQ5ZIX0NFWukTzbJwDtqi7prJ9WJ0xqRCQcRnkll ZBR1ZuEojQftI9GpdQawcQda/a75uez4wL+QbmgSfu3yKqgw3+K6DOCHsQmlasjXSd buWUruvYQUuhAo8Y6MVYlwqgM7MRe+tzudUI4bb8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6CFA0603AF Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=absahu@codeaurora.org From: Abhishek Sahu To: Andy Gross , Wolfram Sang Cc: David Brown , Sricharan R , Austin Christ , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Abhishek Sahu Subject: [PATCH v2 11/13] i2c: qup: send NACK for last read sub transfers Date: Mon, 12 Mar 2018 18:45:00 +0530 Message-Id: <1520860502-14886-12-git-send-email-absahu@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1520860502-14886-1-git-send-email-absahu@codeaurora.org> References: <1520860502-14886-1-git-send-email-absahu@codeaurora.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP According to I2c specification, “If a master-receiver sends a repeated START condition, it sends a not-acknowledge (A) just before the repeated START condition”. QUP v2 supports sending of NACK without stop with QUP_TAG_V2_DATARD_NACK so added the same. Signed-off-by: Abhishek Sahu Reviewed-by: Austin Christ Reviewed-by: Andy Gross --- * Changes from v1: None drivers/i2c/busses/i2c-qup.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 5bb7ebe..4ebd922 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b/drivers/i2c/busses/i2c-qup.c @@ -104,6 +104,7 @@ #define QUP_TAG_V2_DATAWR 0x82 #define QUP_TAG_V2_DATAWR_STOP 0x83 #define QUP_TAG_V2_DATARD 0x85 +#define QUP_TAG_V2_DATARD_NACK 0x86 #define QUP_TAG_V2_DATARD_STOP 0x87 /* Status, Error flags */ @@ -606,7 +607,9 @@ static int qup_i2c_set_tags(u8 *tags, struct qup_i2c_dev *qup, tags[len++] = QUP_TAG_V2_DATAWR_STOP; } else { if (msg->flags & I2C_M_RD) - tags[len++] = QUP_TAG_V2_DATARD; + tags[len++] = qup->blk.pos == (qup->blk.count - 1) ? + QUP_TAG_V2_DATARD_NACK : + QUP_TAG_V2_DATARD; else tags[len++] = QUP_TAG_V2_DATAWR; }