From patchwork Fri Mar 16 09:44:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manu Gautam X-Patchwork-Id: 10286811 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3B2DB60386 for ; Fri, 16 Mar 2018 09:46:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3690C28E05 for ; Fri, 16 Mar 2018 09:46:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B65628E08; Fri, 16 Mar 2018 09:46:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A4B4C28E05 for ; Fri, 16 Mar 2018 09:46:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752812AbeCPJp2 (ORCPT ); Fri, 16 Mar 2018 05:45:28 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58042 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752604AbeCPJpZ (ORCPT ); Fri, 16 Mar 2018 05:45:25 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id EDAC060C65; Fri, 16 Mar 2018 09:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521193524; bh=sP+M9E87W9reLmXLwvUI52+Agb5z12um2xJw8ZHt3Y4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dk1Pvun92Pz0fnsXlb3ZBkDm73+IhQe9k3r1ULoQz5bKMtCe/LETGbE2hOBVBUKG8 aL8f+RWG/6Hx+cpyVao+dEgN3eUtJ+PJto9V0HeiW5iOsoHu50LLgr6YAb8/uRex0X KiSCFpVHGY4jUVUQ7mXDsn1NKoY2F7xopIvuQ+aQ= Received: from mgautam-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D796E60C64; Fri, 16 Mar 2018 09:45:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521193524; bh=sP+M9E87W9reLmXLwvUI52+Agb5z12um2xJw8ZHt3Y4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Dk1Pvun92Pz0fnsXlb3ZBkDm73+IhQe9k3r1ULoQz5bKMtCe/LETGbE2hOBVBUKG8 aL8f+RWG/6Hx+cpyVao+dEgN3eUtJ+PJto9V0HeiW5iOsoHu50LLgr6YAb8/uRex0X KiSCFpVHGY4jUVUQ7mXDsn1NKoY2F7xopIvuQ+aQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D796E60C64 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mgautam@codeaurora.org From: Manu Gautam To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Manu Gautam , Vivek Gautam , Krzysztof Kozlowski , Jaehoon Chung , linux-kernel@vger.kernel.org (open list:GENERIC PHY FRAMEWORK) Subject: [PATCH 2/6] phy: qcom-qusb2: Fix crash if nvmem cell not specified Date: Fri, 16 Mar 2018 15:14:55 +0530 Message-Id: <1521193500-4696-3-git-send-email-mgautam@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1521193500-4696-1-git-send-email-mgautam@codeaurora.org> References: <1521193500-4696-1-git-send-email-mgautam@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Driver currently crashes due to NULL pointer deference while updating PHY tune register if nvmem cell is NULL. Since, fused value for Tune1/2 register is optional, we'd rather bail out. Signed-off-by: Manu Gautam Reviewed-by: Vivek Gautam --- drivers/phy/qualcomm/phy-qcom-qusb2.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qusb2.c b/drivers/phy/qualcomm/phy-qcom-qusb2.c index 94afeac..40fdef8 100644 --- a/drivers/phy/qualcomm/phy-qcom-qusb2.c +++ b/drivers/phy/qualcomm/phy-qcom-qusb2.c @@ -315,6 +315,10 @@ static void qusb2_phy_set_tune2_param(struct qusb2_phy *qphy) const struct qusb2_phy_cfg *cfg = qphy->cfg; u8 *val; + /* efuse register is optional */ + if (!qphy->cell) + return; + /* * Read efuse register having TUNE2/1 parameter's high nibble. * If efuse register shows value as 0x0, or if we fail to find