diff mbox series

[4/5] arm: dts: qcom: Add ipq8064-ap161.dts

Message ID 1533305419-29152-5-git-send-email-sricharan@codeaurora.org (mailing list archive)
State Deferred, archived
Delegated to: Andy Gross
Headers show
Series arm: dts: qcom: Few updates for ipq8064 | expand

Commit Message

Sricharan Ramabadhran Aug. 3, 2018, 2:10 p.m. UTC 
Add a new board dts for ipq8064-ap161.

Signed-off-by: Sricharan R <sricharan@codeaurora.org>
---
 Documentation/devicetree/bindings/arm/qcom.txt | 2 ++
 arch/arm/boot/dts/Makefile                     | 1 +
 arch/arm/boot/dts/qcom-ipq8064-ap161.dts       | 7 +++++++
 3 files changed, 10 insertions(+)
 create mode 100644 arch/arm/boot/dts/qcom-ipq8064-ap161.dts

Comments

Rob Herring Aug. 6, 2018, 8:35 p.m. UTC | #1 
On Fri, Aug 3, 2018 at 8:10 AM Sricharan R <sricharan@codeaurora.org> wrote:
>
> Add a new board dts for ipq8064-ap161.
>
> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom.txt | 2 ++
>  arch/arm/boot/dts/Makefile                     | 1 +
>  arch/arm/boot/dts/qcom-ipq8064-ap161.dts       | 7 +++++++
>  3 files changed, 10 insertions(+)
>  create mode 100644 arch/arm/boot/dts/qcom-ipq8064-ap161.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.txt b/Documentation/devicetree/bindings/arm/qcom.txt
> index ee532e7..2325135 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.txt
> +++ b/Documentation/devicetree/bindings/arm/qcom.txt
> @@ -15,6 +15,7 @@ The 'SoC' and 'board' elements are required. All other elements are optional.
>
>  The 'SoC' element must be one of the following strings:
>
> +       ipq8064
>         apq8016
>         apq8074
>         apq8084
> @@ -30,6 +31,7 @@ The 'SoC' element must be one of the following strings:
>
>  The 'board' element must be one of the following strings:
>
> +       ap
>         cdp
>         liquid
>         dragonboard
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 37a3de7..233661a 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -772,6 +772,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>         qcom-ipq4019-ap.dk07.1-c1.dtb \
>         qcom-ipq4019-ap.dk07.1-c2.dtb \
>         qcom-ipq8064-ap148.dtb \
> +       qcom-ipq8064-ap161.dtb \
>         qcom-msm8660-surf.dtb \
>         qcom-msm8960-cdp.dtb \
>         qcom-msm8974-fairphone-fp2.dtb \
> diff --git a/arch/arm/boot/dts/qcom-ipq8064-ap161.dts b/arch/arm/boot/dts/qcom-ipq8064-ap161.dts
> new file mode 100644
> index 0000000..aab5174
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-ipq8064-ap161.dts
> @@ -0,0 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include "qcom-ipq8064-v1.0.dtsi"
> +
> +/ {
> +       model = "Qualcomm Technologies, Inc. IPQ8064/AP-161";
> +       compatible = "qcom,ipq8064-ap161";

Doesn't match what you documented above. I'm guessing the ap148 board
didn't either...

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sricharan Ramabadhran Aug. 7, 2018, 2:22 a.m. UTC | #2 
Hi Rob,

On 8/7/2018 2:05 AM, Rob Herring wrote:
> On Fri, Aug 3, 2018 at 8:10 AM Sricharan R <sricharan@codeaurora.org> wrote:
>>
>> Add a new board dts for ipq8064-ap161.
>>
>> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
>> ---
>>  Documentation/devicetree/bindings/arm/qcom.txt | 2 ++
>>  arch/arm/boot/dts/Makefile                     | 1 +
>>  arch/arm/boot/dts/qcom-ipq8064-ap161.dts       | 7 +++++++
>>  3 files changed, 10 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/qcom-ipq8064-ap161.dts
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.txt b/Documentation/devicetree/bindings/arm/qcom.txt
>> index ee532e7..2325135 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.txt
>> +++ b/Documentation/devicetree/bindings/arm/qcom.txt
>> @@ -15,6 +15,7 @@ The 'SoC' and 'board' elements are required. All other elements are optional.
>>
>>  The 'SoC' element must be one of the following strings:
>>
>> +       ipq8064
>>         apq8016
>>         apq8074
>>         apq8084
>> @@ -30,6 +31,7 @@ The 'SoC' element must be one of the following strings:
>>
>>  The 'board' element must be one of the following strings:
>>
>> +       ap
>>         cdp
>>         liquid
>>         dragonboard
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 37a3de7..233661a 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -772,6 +772,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>>         qcom-ipq4019-ap.dk07.1-c1.dtb \
>>         qcom-ipq4019-ap.dk07.1-c2.dtb \
>>         qcom-ipq8064-ap148.dtb \
>> +       qcom-ipq8064-ap161.dtb \
>>         qcom-msm8660-surf.dtb \
>>         qcom-msm8960-cdp.dtb \
>>         qcom-msm8974-fairphone-fp2.dtb \
>> diff --git a/arch/arm/boot/dts/qcom-ipq8064-ap161.dts b/arch/arm/boot/dts/qcom-ipq8064-ap161.dts
>> new file mode 100644
>> index 0000000..aab5174
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/qcom-ipq8064-ap161.dts
>> @@ -0,0 +1,7 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +#include "qcom-ipq8064-v1.0.dtsi"
>> +
>> +/ {
>> +       model = "Qualcomm Technologies, Inc. IPQ8064/AP-161";
>> +       compatible = "qcom,ipq8064-ap161";
> 
> Doesn't match what you documented above. I'm guessing the ap148 board
> didn't either...

oops. yeah, ap148 id not having it. will add that and also correct this.
would call it as 'ap161' as the name for the board part.

Regards,
 Sricharan
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.txt b/Documentation/devicetree/bindings/arm/qcom.txt
index ee532e7..2325135 100644
--- a/Documentation/devicetree/bindings/arm/qcom.txt
+++ b/Documentation/devicetree/bindings/arm/qcom.txt
@@ -15,6 +15,7 @@  The 'SoC' and 'board' elements are required. All other elements are optional.
 
 The 'SoC' element must be one of the following strings:
 
+	ipq8064
 	apq8016
 	apq8074
 	apq8084
@@ -30,6 +31,7 @@  The 'SoC' element must be one of the following strings:
 
 The 'board' element must be one of the following strings:
 
+	ap
 	cdp
 	liquid
 	dragonboard
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 37a3de7..233661a 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -772,6 +772,7 @@  dtb-$(CONFIG_ARCH_QCOM) += \
 	qcom-ipq4019-ap.dk07.1-c1.dtb \
 	qcom-ipq4019-ap.dk07.1-c2.dtb \
 	qcom-ipq8064-ap148.dtb \
+	qcom-ipq8064-ap161.dtb \
 	qcom-msm8660-surf.dtb \
 	qcom-msm8960-cdp.dtb \
 	qcom-msm8974-fairphone-fp2.dtb \
diff --git a/arch/arm/boot/dts/qcom-ipq8064-ap161.dts b/arch/arm/boot/dts/qcom-ipq8064-ap161.dts
new file mode 100644
index 0000000..aab5174
--- /dev/null
+++ b/arch/arm/boot/dts/qcom-ipq8064-ap161.dts
@@ -0,0 +1,7 @@ 
+// SPDX-License-Identifier: GPL-2.0
+#include "qcom-ipq8064-v1.0.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. IPQ8064/AP-161";
+	compatible = "qcom,ipq8064-ap161";
+};