| Message ID | 1545313174-13481-2-git-send-email-rohitkr@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: qcom: sdm845: add support for ADSP PIL | expand |
On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote: > Add memory nodes required for remoteproc q6v5_adsp pil. > This range doesn't match the documented memory map. I would prefer to see a "Specify all PIL regions as defined in V10" or similar. Regards, Bjorn > Signed-off-by: Rohit kumar <rohitkr@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 23a253b..c0a012f 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -88,6 +88,11 @@ > reg = <0 0x86200000 0 0x2d00000>; > no-map; > }; > + > + pil_adsp_mem: memory@8b100000 { > + reg = <0 0x8b100000 0 0x1a00000>; > + no-map; > + }; > }; > > cpus { > -- > Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., > is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. >
Thanks Bjorn for review. On 1/4/2019 5:12 AM, Bjorn Andersson wrote: > On Thu 20 Dec 05:39 PST 2018, Rohit kumar wrote: > >> Add memory nodes required for remoteproc q6v5_adsp pil. >> > This range doesn't match the documented memory map. I would prefer to > see a "Specify all PIL regions as defined in V10" or similar. Yes, Sibi will post it along with other PIL regions with update address in next spin. > > Regards, > Bjorn > >> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> index 23a253b..c0a012f 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> @@ -88,6 +88,11 @@ >> reg = <0 0x86200000 0 0x2d00000>; >> no-map; >> }; >> + >> + pil_adsp_mem: memory@8b100000 { >> + reg = <0 0x8b100000 0 0x1a00000>; >> + no-map; >> + }; >> }; >> >> cpus { >> -- >> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., >> is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. >> Regards, Rohit
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 23a253b..c0a012f 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -88,6 +88,11 @@ reg = <0 0x86200000 0 0x2d00000>; no-map; }; + + pil_adsp_mem: memory@8b100000 { + reg = <0 0x8b100000 0 0x1a00000>; + no-map; + }; }; cpus {
Add memory nodes required for remoteproc q6v5_adsp pil. Signed-off-by: Rohit kumar <rohitkr@codeaurora.org> --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++ 1 file changed, 5 insertions(+)