| Message ID | 1572591543-15501-1-git-send-email-kgunda@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [V1] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l | expand |
Quoting Kiran Gunda (2019-10-31 23:59:03) > Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs > found on SC7180 based platforms. > > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 2 ++ > drivers/mfd/qcom-spmi-pmic.c | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > index 1437062..b5fc64e 100644 > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > @@ -32,6 +32,8 @@ Required properties: > "qcom,pm8998", > "qcom,pmi8998", > "qcom,pm8005", > + "qcom,pm6150", > + "qcom,pm6150l", Please sort on compatible string > or generalized "qcom,spmi-pmic". > - reg: Specifies the SPMI USID slave address for this device. > For more information see: > diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c > index e8fe705..d916aa8 100644 > --- a/drivers/mfd/qcom-spmi-pmic.c > +++ b/drivers/mfd/qcom-spmi-pmic.c > @@ -34,6 +34,8 @@ > #define PM8998_SUBTYPE 0x14 > #define PMI8998_SUBTYPE 0x15 > #define PM8005_SUBTYPE 0x18 > +#define PM6150L_SUBTYPE 0x27 > +#define PM6150_SUBTYPE 0x28 And on macro name here. > > static const struct of_device_id pmic_spmi_id_table[] = { > { .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE }, > @@ -53,6 +55,8 @@ > { .compatible = "qcom,pm8998", .data = (void *)PM8998_SUBTYPE }, > { .compatible = "qcom,pmi8998", .data = (void *)PMI8998_SUBTYPE }, > { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE }, > + { .compatible = "qcom,pm6150l", .data = (void *)PM6150L_SUBTYPE }, > + { .compatible = "qcom,pm6150", .data = (void *)PM6150_SUBTYPE }, And compatible here. > { }
On 2019-11-04 23:22, Stephen Boyd wrote: > Quoting Kiran Gunda (2019-10-31 23:59:03) >> Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs >> found on SC7180 based platforms. >> >> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> >> --- >> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 2 ++ >> drivers/mfd/qcom-spmi-pmic.c | 4 ++++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt >> b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt >> index 1437062..b5fc64e 100644 >> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt >> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt >> @@ -32,6 +32,8 @@ Required properties: >> "qcom,pm8998", >> "qcom,pmi8998", >> "qcom,pm8005", >> + "qcom,pm6150", >> + "qcom,pm6150l", > > Please sort on compatible string > Will do it in next post. >> or generalized "qcom,spmi-pmic". >> - reg: Specifies the SPMI USID slave address for this >> device. >> For more information see: >> diff --git a/drivers/mfd/qcom-spmi-pmic.c >> b/drivers/mfd/qcom-spmi-pmic.c >> index e8fe705..d916aa8 100644 >> --- a/drivers/mfd/qcom-spmi-pmic.c >> +++ b/drivers/mfd/qcom-spmi-pmic.c >> @@ -34,6 +34,8 @@ >> #define PM8998_SUBTYPE 0x14 >> #define PMI8998_SUBTYPE 0x15 >> #define PM8005_SUBTYPE 0x18 >> +#define PM6150L_SUBTYPE 0x27 >> +#define PM6150_SUBTYPE 0x28 > > And on macro name here. > Will do it in next post. >> >> static const struct of_device_id pmic_spmi_id_table[] = { >> { .compatible = "qcom,spmi-pmic", .data = (void >> *)COMMON_SUBTYPE }, >> @@ -53,6 +55,8 @@ >> { .compatible = "qcom,pm8998", .data = (void >> *)PM8998_SUBTYPE }, >> { .compatible = "qcom,pmi8998", .data = (void >> *)PMI8998_SUBTYPE }, >> { .compatible = "qcom,pm8005", .data = (void >> *)PM8005_SUBTYPE }, >> + { .compatible = "qcom,pm6150l", .data = (void >> *)PM6150L_SUBTYPE }, >> + { .compatible = "qcom,pm6150", .data = (void >> *)PM6150_SUBTYPE }, > > And compatible here. > Will do it in next post. >> { }
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt index 1437062..b5fc64e 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt @@ -32,6 +32,8 @@ Required properties: "qcom,pm8998", "qcom,pmi8998", "qcom,pm8005", + "qcom,pm6150", + "qcom,pm6150l", or generalized "qcom,spmi-pmic". - reg: Specifies the SPMI USID slave address for this device. For more information see: diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c index e8fe705..d916aa8 100644 --- a/drivers/mfd/qcom-spmi-pmic.c +++ b/drivers/mfd/qcom-spmi-pmic.c @@ -34,6 +34,8 @@ #define PM8998_SUBTYPE 0x14 #define PMI8998_SUBTYPE 0x15 #define PM8005_SUBTYPE 0x18 +#define PM6150L_SUBTYPE 0x27 +#define PM6150_SUBTYPE 0x28 static const struct of_device_id pmic_spmi_id_table[] = { { .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE }, @@ -53,6 +55,8 @@ { .compatible = "qcom,pm8998", .data = (void *)PM8998_SUBTYPE }, { .compatible = "qcom,pmi8998", .data = (void *)PMI8998_SUBTYPE }, { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE }, + { .compatible = "qcom,pm6150l", .data = (void *)PM6150L_SUBTYPE }, + { .compatible = "qcom,pm6150", .data = (void *)PM6150_SUBTYPE }, { } };
Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs found on SC7180 based platforms. Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> --- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 2 ++ drivers/mfd/qcom-spmi-pmic.c | 4 ++++ 2 files changed, 6 insertions(+)