| Message ID | 1596445047-2975-2-git-send-email-hsin-hsiung.wang@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for MT6315 regulator | expand |
On Mon, Aug 3, 2020 at 4:57 PM Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> wrote: > > Add new shutdown() method. Use it in the standard driver model style. > > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> > --- > drivers/spmi/spmi.c | 12 ++++++++++++ > drivers/spmi/spmi.c | 12 ++++++++++++ > include/linux/spmi.h | 1 + > 2 files changed, 13 insertions(+) > > diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c > index c16b60f..5fde024 100644 > --- a/drivers/spmi/spmi.c > +++ b/drivers/spmi/spmi.c > @@ -357,6 +357,17 @@ static int spmi_drv_remove(struct device *dev) > return 0; > } > > +static void spmi_drv_shutdown(struct device *dev) > +{ > + const struct spmi_driver *sdrv = to_spmi_driver(dev->driver); > + > + if (!sdrv) > + return; > + > + > + if (sdrv->shutdown) > + sdrv->shutdown(to_spmi_device(dev)); Slight more succinct (assuming sdrv _can_ actually be NULL, I'm not sure about that) if (srdv && sdrv->shutdown) > +} > +} > + > static int spmi_drv_uevent(struct device *dev, struct kobj_uevent_env *env) > { > int ret; > @@ -373,6 +384,7 @@ static struct bus_type spmi_bus_type = { > @@ -373,6 +384,7 @@ static struct bus_type spmi_bus_type = { > .match = spmi_device_match, > .probe = spmi_drv_probe, > .remove = spmi_drv_remove, > + .shutdown = spmi_drv_shutdown, > .uevent = spmi_drv_uevent, > }; > > diff --git a/include/linux/spmi.h b/include/linux/spmi.h > index 394a3f6..729bcbf 100644 > --- a/include/linux/spmi.h > +++ b/include/linux/spmi.h > @@ -138,6 +138,7 @@ struct spmi_driver { > struct device_driver driver; > int (*probe)(struct spmi_device *sdev); > void (*remove)(struct spmi_device *sdev); > + void (*shutdown)(struct spmi_device *sdev); > }; > > static inline struct spmi_driver *to_spmi_driver(struct device_driver *d) > -- > 2.6.4
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c index c16b60f..5fde024 100644 --- a/drivers/spmi/spmi.c +++ b/drivers/spmi/spmi.c @@ -357,6 +357,17 @@ static int spmi_drv_remove(struct device *dev) return 0; } +static void spmi_drv_shutdown(struct device *dev) +{ + const struct spmi_driver *sdrv = to_spmi_driver(dev->driver); + + if (!sdrv) + return; + + + if (sdrv->shutdown) + sdrv->shutdown(to_spmi_device(dev)); +} +} + static int spmi_drv_uevent(struct device *dev, struct kobj_uevent_env *env) { int ret; @@ -373,6 +384,7 @@ static struct bus_type spmi_bus_type = { @@ -373,6 +384,7 @@ static struct bus_type spmi_bus_type = { .match = spmi_device_match, .probe = spmi_drv_probe, .remove = spmi_drv_remove, + .shutdown = spmi_drv_shutdown, .uevent = spmi_drv_uevent, }; diff --git a/include/linux/spmi.h b/include/linux/spmi.h index 394a3f6..729bcbf 100644 --- a/include/linux/spmi.h +++ b/include/linux/spmi.h @@ -138,6 +138,7 @@ struct spmi_driver { struct device_driver driver; int (*probe)(struct spmi_device *sdev); void (*remove)(struct spmi_device *sdev); + void (*shutdown)(struct spmi_device *sdev); }; static inline struct spmi_driver *to_spmi_driver(struct device_driver *d)
Add new shutdown() method. Use it in the standard driver model style. Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> --- drivers/spmi/spmi.c | 12 ++++++++++++ drivers/spmi/spmi.c | 12 ++++++++++++ include/linux/spmi.h | 1 + 2 files changed, 13 insertions(+)