| Message ID | 1604373541-12641-2-git-send-email-clew@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] soc: qcom: aoss: Expose send for generic usecase | expand |
On Mon 02 Nov 21:19 CST 2020, Chris Lew wrote: > It can be useful to control the different power states of various > parts of hardware for device testing. Add a debugfs node to send > messages through qmp to aoss for debugging and testing purposes. > > Signed-off-by: Chris Lew <clew@codeaurora.org> > --- > drivers/soc/qcom/qcom_aoss.c | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c > index 8f052db1880a..2fd755d2a92d 100644 > --- a/drivers/soc/qcom/qcom_aoss.c > +++ b/drivers/soc/qcom/qcom_aoss.c > @@ -4,6 +4,7 @@ > */ > #include <dt-bindings/power/qcom-aoss-qmp.h> > #include <linux/clk-provider.h> > +#include <linux/debugfs.h> > #include <linux/interrupt.h> > #include <linux/io.h> > #include <linux/mailbox_client.h> > @@ -85,6 +86,8 @@ struct qmp { > struct clk_hw qdss_clk; > struct genpd_onecell_data pd_data; > struct qmp_cooling_device *cooling_devs; > + > + struct dentry *debugfs_fp; > }; > > struct qmp_pd { > @@ -541,6 +544,34 @@ struct qmp_device *qmp_get(struct device_node *np) > } > EXPORT_SYMBOL_GPL(qmp_get); > > +static ssize_t aoss_dbg_write(struct file *file, const char __user *userstr, > + size_t len, loff_t *pos) > +{ > + struct qmp *qmp = file->private_data; > + char buf[QMP_MSG_LEN] = {}; > + int ret; > + > + if (!len || len >= QMP_MSG_LEN) > + return len; > + > + ret = copy_from_user(buf, userstr, len); > + if (ret) { > + dev_err(qmp->dev, "copy from user failed, ret:%d\n", ret); > + return len; > + } > + > + ret = qmp_send(qmp, buf, QMP_MSG_LEN); > + if (ret) > + dev_err(qmp->dev, "debug send failed, ret:%d\n", ret); You should propagate this error to the caller, i.e. return ret ? ret : len; And with that the error print doesn't really add any value, so please drop it. > + > + return len; > +} > + This will result in a compile warning when compiled without CONFIG_DEBUG_FS, so either mark it __maybe_unused or wrap the whole hunk in a #if IS_ENABLED(CONFIG_DEBUG_FS). PS. Feel free to resubmit this change on its own, as it can be merged independently from patch 1. Regards, Bjorn > +static const struct file_operations aoss_dbg_fops = { > + .open = simple_open, > + .write = aoss_dbg_write, > +}; > + > static int qmp_probe(struct platform_device *pdev) > { > struct resource *res; > @@ -595,6 +626,9 @@ static int qmp_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, qmp); > > + qmp->debugfs_fp = debugfs_create_file("aoss_send_message", 0220, NULL, > + qmp, &aoss_dbg_fops); > + > return 0; > > err_remove_qdss_clk: > @@ -611,6 +645,8 @@ static int qmp_remove(struct platform_device *pdev) > { > struct qmp *qmp = platform_get_drvdata(pdev); > > + debugfs_remove(qmp->debugfs_fp); > + > qmp_qdss_clk_remove(qmp); > qmp_pd_remove(qmp); > qmp_cooling_devices_remove(qmp); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c index 8f052db1880a..2fd755d2a92d 100644 --- a/drivers/soc/qcom/qcom_aoss.c +++ b/drivers/soc/qcom/qcom_aoss.c @@ -4,6 +4,7 @@ */ #include <dt-bindings/power/qcom-aoss-qmp.h> #include <linux/clk-provider.h> +#include <linux/debugfs.h> #include <linux/interrupt.h> #include <linux/io.h> #include <linux/mailbox_client.h> @@ -85,6 +86,8 @@ struct qmp { struct clk_hw qdss_clk; struct genpd_onecell_data pd_data; struct qmp_cooling_device *cooling_devs; + + struct dentry *debugfs_fp; }; struct qmp_pd { @@ -541,6 +544,34 @@ struct qmp_device *qmp_get(struct device_node *np) } EXPORT_SYMBOL_GPL(qmp_get); +static ssize_t aoss_dbg_write(struct file *file, const char __user *userstr, + size_t len, loff_t *pos) +{ + struct qmp *qmp = file->private_data; + char buf[QMP_MSG_LEN] = {}; + int ret; + + if (!len || len >= QMP_MSG_LEN) + return len; + + ret = copy_from_user(buf, userstr, len); + if (ret) { + dev_err(qmp->dev, "copy from user failed, ret:%d\n", ret); + return len; + } + + ret = qmp_send(qmp, buf, QMP_MSG_LEN); + if (ret) + dev_err(qmp->dev, "debug send failed, ret:%d\n", ret); + + return len; +} + +static const struct file_operations aoss_dbg_fops = { + .open = simple_open, + .write = aoss_dbg_write, +}; + static int qmp_probe(struct platform_device *pdev) { struct resource *res; @@ -595,6 +626,9 @@ static int qmp_probe(struct platform_device *pdev) platform_set_drvdata(pdev, qmp); + qmp->debugfs_fp = debugfs_create_file("aoss_send_message", 0220, NULL, + qmp, &aoss_dbg_fops); + return 0; err_remove_qdss_clk: @@ -611,6 +645,8 @@ static int qmp_remove(struct platform_device *pdev) { struct qmp *qmp = platform_get_drvdata(pdev); + debugfs_remove(qmp->debugfs_fp); + qmp_qdss_clk_remove(qmp); qmp_pd_remove(qmp); qmp_cooling_devices_remove(qmp);
It can be useful to control the different power states of various parts of hardware for device testing. Add a debugfs node to send messages through qmp to aoss for debugging and testing purposes. Signed-off-by: Chris Lew <clew@codeaurora.org> --- drivers/soc/qcom/qcom_aoss.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+)