diff mbox series

[v1] arm64: dts: sc7180: Add camera clock controller node

Message ID 1604687907-25712-1-git-send-email-tdas@codeaurora.org (mailing list archive)
State New, archived
Headers show
Series [v1] arm64: dts: sc7180: Add camera clock controller node | expand

Commit Message

Taniya Das Nov. 6, 2020, 6:38 p.m. UTC
Add the camera clock controller node supported on SC7180.

Signed-off-by: Taniya Das <tdas@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 +++++++++++++
 1 file changed, 13 insertions(+)

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the  Linux Foundation.

Comments

Douglas Anderson Nov. 11, 2020, 2:08 a.m. UTC | #1
Hi,

On Fri, Nov 6, 2020 at 10:39 AM Taniya Das <tdas@codeaurora.org> wrote:
>
> Add the camera clock controller node supported on SC7180.
>
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

This matches the bindings, which has landed in the clock tree.  It's
also sorted properly.  Thus:

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Bjorn Andersson Nov. 11, 2020, 4:47 a.m. UTC | #2
On Fri 06 Nov 12:38 CST 2020, Taniya Das wrote:

> Add the camera clock controller node supported on SC7180.
> 
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index f5ef2cb..e795dba 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -5,6 +5,7 @@
>   * Copyright (c) 2019, The Linux Foundation. All rights reserved.
>   */
> 
> +#include <dt-bindings/clock/qcom,camcc-sc7180.h>

Applied the patch without this include, as it was not available in the
tag I branched off my 5.11 branch off.

Regards,
Bjorn

>  #include <dt-bindings/clock/qcom,dispcc-sc7180.h>
>  #include <dt-bindings/clock/qcom,gcc-sc7180.h>
>  #include <dt-bindings/clock/qcom,gpucc-sc7180.h>
> @@ -2896,6 +2897,18 @@
>  			qcom,bcm-voters = <&apps_bcm_voter>;
>  		};
> 
> +		camcc: clock-controller@ad00000 {
> +			compatible = "qcom,sc7180-camcc";
> +			reg = <0 0x0ad00000 0 0x10000>;
> +			clocks = <&rpmhcc RPMH_CXO_CLK>,
> +			       <&gcc GCC_CAMERA_AHB_CLK>,
> +			       <&gcc GCC_CAMERA_XO_CLK>;
> +			clock-names = "bi_tcxo", "iface", "xo";
> +			#clock-cells = <1>;
> +			#reset-cells = <1>;
> +			#power-domain-cells = <1>;
> +		};
> +
>  		mdss: mdss@ae00000 {
>  			compatible = "qcom,sc7180-mdss";
>  			reg = <0 0x0ae00000 0 0x1000>;
> --
> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
> of the Code Aurora Forum, hosted by the  Linux Foundation.
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index f5ef2cb..e795dba 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -5,6 +5,7 @@ 
  * Copyright (c) 2019, The Linux Foundation. All rights reserved.
  */

+#include <dt-bindings/clock/qcom,camcc-sc7180.h>
 #include <dt-bindings/clock/qcom,dispcc-sc7180.h>
 #include <dt-bindings/clock/qcom,gcc-sc7180.h>
 #include <dt-bindings/clock/qcom,gpucc-sc7180.h>
@@ -2896,6 +2897,18 @@ 
 			qcom,bcm-voters = <&apps_bcm_voter>;
 		};

+		camcc: clock-controller@ad00000 {
+			compatible = "qcom,sc7180-camcc";
+			reg = <0 0x0ad00000 0 0x10000>;
+			clocks = <&rpmhcc RPMH_CXO_CLK>,
+			       <&gcc GCC_CAMERA_AHB_CLK>,
+			       <&gcc GCC_CAMERA_XO_CLK>;
+			clock-names = "bi_tcxo", "iface", "xo";
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+			#power-domain-cells = <1>;
+		};
+
 		mdss: mdss@ae00000 {
 			compatible = "qcom,sc7180-mdss";
 			reg = <0 0x0ae00000 0 0x1000>;