| Message ID | 1636072273-16034-1-git-send-email-quic_bbhatt@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | bus: mhi: core: Read missing channel configuration entry | expand |
On 11/4/2021 5:31 PM, Bhaumik Bhatt wrote: > The 'wake-capable' entry in channel configuration is not set when > parsing the configuration specified by the controller driver. Add > the missing entry to ensure channel is correctly specified as a > 'wake-capable' channel. > > Signed-off-by: Bhaumik Bhatt <quic_bbhatt@quicinc.com> Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
On Thu, Nov 04, 2021 at 05:31:13PM -0700, Bhaumik Bhatt wrote: > The 'wake-capable' entry in channel configuration is not set when > parsing the configuration specified by the controller driver. Add > the missing entry to ensure channel is correctly specified as a > 'wake-capable' channel. > > Signed-off-by: Bhaumik Bhatt <quic_bbhatt@quicinc.com> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org> Looks like this one is qualified as a bug fix. Please add the fixes tag and Cc stable. And the subject could be, "bus: mhi: core: Fix reading wake_capable configuration" Thanks, Mani > --- > drivers/bus/mhi/core/init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c > index 5aaca6d..f1ec3441 100644 > --- a/drivers/bus/mhi/core/init.c > +++ b/drivers/bus/mhi/core/init.c > @@ -788,6 +788,7 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl, > mhi_chan->offload_ch = ch_cfg->offload_channel; > mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch; > mhi_chan->pre_alloc = ch_cfg->auto_queue; > + mhi_chan->wake_capable = ch_cfg->wake_capable; > > /* > * If MHI host allocates buffers, then the channel direction > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c index 5aaca6d..f1ec3441 100644 --- a/drivers/bus/mhi/core/init.c +++ b/drivers/bus/mhi/core/init.c @@ -788,6 +788,7 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl, mhi_chan->offload_ch = ch_cfg->offload_channel; mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch; mhi_chan->pre_alloc = ch_cfg->auto_queue; + mhi_chan->wake_capable = ch_cfg->wake_capable; /* * If MHI host allocates buffers, then the channel direction
The 'wake-capable' entry in channel configuration is not set when parsing the configuration specified by the controller driver. Add the missing entry to ensure channel is correctly specified as a 'wake-capable' channel. Signed-off-by: Bhaumik Bhatt <quic_bbhatt@quicinc.com> --- drivers/bus/mhi/core/init.c | 1 + 1 file changed, 1 insertion(+)