diff mbox series

[v9,1/3] phy: qcom-edp: add regulator_set_load to edp phy

Message ID 1653077167-16684-2-git-send-email-quic_khsieh@quicinc.com (mailing list archive)
State Superseded
Headers show
Series eDP/DP Phy vdda realted function | expand

Commit Message

Kuogee Hsieh May 20, 2022, 8:06 p.m. UTC 
This patch add regulator_set_load() before enable regulator at
eDP phy driver.

Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
---
 drivers/phy/qualcomm/phy-qcom-edp.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Stephen Boyd May 20, 2022, 8:14 p.m. UTC | #1 
Quoting Kuogee Hsieh (2022-05-20 13:06:05)
> This patch add regulator_set_load() before enable regulator at
> eDP phy driver.
>
> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-edp.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
> index cacd32f..0b7f318 100644
> --- a/drivers/phy/qualcomm/phy-qcom-edp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-edp.c
> @@ -639,6 +639,9 @@ static int qcom_edp_phy_probe(struct platform_device *pdev)
>         if (ret)
>                 return ret;
>
> +       regulator_set_load(edp->supplies[0].consumer, 21800); /* 1.2 V vdda-phy */
> +       regulator_set_load(edp->supplies[1].consumer, 36000); /* 0.9 V vdda-pll */

Why aren't there checks for errors on these API calls?
diff mbox series

Patch

diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
index cacd32f..0b7f318 100644
--- a/drivers/phy/qualcomm/phy-qcom-edp.c
+++ b/drivers/phy/qualcomm/phy-qcom-edp.c
@@ -639,6 +639,9 @@  static int qcom_edp_phy_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
+	regulator_set_load(edp->supplies[0].consumer, 21800); /* 1.2 V vdda-phy */
+	regulator_set_load(edp->supplies[1].consumer, 36000); /* 0.9 V vdda-pll */
+
 	ret = qcom_edp_clks_register(edp, pdev->dev.of_node);
 	if (ret)
 		return ret;