| Message ID | 1661898311-30126-2-git-send-email-quic_gurus@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | SCM: Add support for wait-queue aware firmware | expand |
On 31/08/2022 01:25, Guru Das Srinagesh wrote: > For firmware that supports it, allow multiple SCM calls to be passed > down to it by removing the serialization lock in the SCM driver. > > This patch is based on this YAML conversion patch [1] that is in-flight > currently. > > [1] https://lore.kernel.org/lkml/20220708090431.30437-1-david@ixit.cz/ > > Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com> Thank you for your patch. There is something to discuss/improve. If you make a resend, at least be sure you Cc proper people. Use scripts/get_maintainers.pl to CC all maintainers and relevant mailing lists. This was not Cced to device tree maintainers, therefore it has to be NAK-ed. > --- > Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > index 9fdeee0..e279fd2 100644 > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > @@ -70,6 +70,11 @@ properties: > '#reset-cells': > const: 1 > > + allow-multi-call: > + description: > + Specify this flag to remove SCM call serialization. Need to ensure that > + the firmware being used supports this feature first. Missing vendor prefix, missing type. Isn't support for this obvious from compatible?\ Best regards, Krzysztof
Hey Krzysztof, Thanks for taking time to review the series. On 8/31/22 1:30 PM, Krzysztof Kozlowski wrote: > On 31/08/2022 01:25, Guru Das Srinagesh wrote: >> For firmware that supports it, allow multiple SCM calls to be passed >> down to it by removing the serialization lock in the SCM driver. >> >> This patch is based on this YAML conversion patch [1] that is in-flight >> currently. >> >> [1] https://lore.kernel.org/lkml/20220708090431.30437-1-david@ixit.cz/ >> >> Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com> > > Thank you for your patch. There is something to discuss/improve. > > If you make a resend, at least be sure you Cc proper people. Use > scripts/get_maintainers.pl to CC all maintainers and relevant mailing lists. > > This was not Cced to device tree maintainers, therefore it has to be NAK-ed. > > >> --- >> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> index 9fdeee0..e279fd2 100644 >> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> @@ -70,6 +70,11 @@ properties: >> '#reset-cells': >> const: 1 >> >> + allow-multi-call: >> + description: >> + Specify this flag to remove SCM call serialization. Need to ensure that >> + the firmware being used supports this feature first. > > Missing vendor prefix, missing type. Ack > > Isn't support for this obvious from compatible?\ On further testing it looks like the property can't be truly enabled on sm8450 yet so I'll drop the patch in the next re-spin. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml index 9fdeee0..e279fd2 100644 --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml @@ -70,6 +70,11 @@ properties: '#reset-cells': const: 1 + allow-multi-call: + description: + Specify this flag to remove SCM call serialization. Need to ensure that + the firmware being used supports this feature first. + qcom,dload-mode: $ref: /schemas/types.yaml#/definitions/phandle-array items:
For firmware that supports it, allow multiple SCM calls to be passed down to it by removing the serialization lock in the SCM driver. This patch is based on this YAML conversion patch [1] that is in-flight currently. [1] https://lore.kernel.org/lkml/20220708090431.30437-1-david@ixit.cz/ Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com> --- Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 5 +++++ 1 file changed, 5 insertions(+)