| Message ID | 1661898311-30126-4-git-send-email-quic_gurus@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | SCM: Add support for wait-queue aware firmware | expand |
On 31/08/2022 01:25, Guru Das Srinagesh wrote: > Add an interrupt specification to the bindings to support the wait-queue > feature. > > Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com> Also not CC-ed to proper people and lists. > --- > Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > index e279fd2..4d6c89f 100644 > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > @@ -75,6 +75,11 @@ properties: > Specify this flag to remove SCM call serialization. Need to ensure that > the firmware being used supports this feature first. > > + interrupts: > + description: > + The wait-queue interrupt that firmware raises as part of handshake > + protocol to handle sleeping SCM calls. Missing constraints. Which firmwares support it? > + > qcom,dload-mode: > $ref: /schemas/types.yaml#/definitions/phandle-array > items: Best regards, Krzysztof
Hey Krzysztof, Thanks for taking time to review the series. On 8/31/22 1:32 PM, Krzysztof Kozlowski wrote: > On 31/08/2022 01:25, Guru Das Srinagesh wrote: >> Add an interrupt specification to the bindings to support the wait-queue >> feature. >> >> Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com> > > Also not CC-ed to proper people and lists. > >> --- >> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> index e279fd2..4d6c89f 100644 >> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> @@ -75,6 +75,11 @@ properties: >> Specify this flag to remove SCM call serialization. Need to ensure that >> the firmware being used supports this feature first. >> >> + interrupts: >> + description: >> + The wait-queue interrupt that firmware raises as part of handshake >> + protocol to handle sleeping SCM calls. > > Missing constraints. > > Which firmwares support it? > The interrupt property for scm firmware from a binding perspective is completely optional i.e. not all tz fw running in the wild on sm8450 devices support this feature. The bootloader does the interrupt property addition on sm8450 devices with support. -Sibi >> + >> qcom,dload-mode: >> $ref: /schemas/types.yaml#/definitions/phandle-array >> items: > > > Best regards, > Krzysztof >
On 18/10/2022 01:49, Sibi Sankar wrote: >>> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >>> index e279fd2..4d6c89f 100644 >>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >>> @@ -75,6 +75,11 @@ properties: >>> Specify this flag to remove SCM call serialization. Need to ensure that >>> the firmware being used supports this feature first. >>> >>> + interrupts: >>> + description: >>> + The wait-queue interrupt that firmware raises as part of handshake >>> + protocol to handle sleeping SCM calls. >> >> Missing constraints. >> >> Which firmwares support it? >> > > The interrupt property for scm firmware from a binding perspective > is completely optional i.e. not all tz fw running in the wild on sm8450 > devices support this feature. The bootloader does the interrupt property > addition on sm8450 devices with support. OK. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml index e279fd2..4d6c89f 100644 --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml @@ -75,6 +75,11 @@ properties: Specify this flag to remove SCM call serialization. Need to ensure that the firmware being used supports this feature first. + interrupts: + description: + The wait-queue interrupt that firmware raises as part of handshake + protocol to handle sleeping SCM calls. + qcom,dload-mode: $ref: /schemas/types.yaml#/definitions/phandle-array items:
Add an interrupt specification to the bindings to support the wait-queue feature. Signed-off-by: Guru Das Srinagesh <quic_gurus@quicinc.com> --- Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 5 +++++ 1 file changed, 5 insertions(+)