diff mbox series

[5/8] ARM: dts: qcom: sdx65-mtp: Update the pmic used in sdx65

Message ID 1690970366-30982-6-git-send-email-quic_rohiagar@quicinc.com (mailing list archive)
State Superseded
Headers show
Series Add pmics supported in Qualcomm's SDX75 platform | expand

Commit Message

Rohit Agarwal Aug. 2, 2023, 9:59 a.m. UTC
Update the pmic used in sdx65 platform to pm7250b.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Konrad Dybcio Aug. 2, 2023, 12:46 p.m. UTC | #1
On 2.08.2023 11:59, Rohit Agarwal wrote:
> Update the pmic used in sdx65 platform to pm7250b.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
Has this changed with a board revision? Was this wrong before?

Need more explanation, and this definitely deserves a Fixes: tag.

Konrad
>  arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
> index 02d8d6e..fcf1c51 100644
> --- a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
> @@ -7,7 +7,7 @@
>  #include "qcom-sdx65.dtsi"
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  #include <arm64/qcom/pmk8350.dtsi>
> -#include <arm64/qcom/pm8150b.dtsi>
> +#include <arm64/qcom/pm7250b.dtsi>
>  #include "qcom-pmx65.dtsi"
>  
>  / {
Rohit Agarwal Aug. 2, 2023, 1:17 p.m. UTC | #2
On 8/2/2023 6:16 PM, Konrad Dybcio wrote:
> On 2.08.2023 11:59, Rohit Agarwal wrote:
>> Update the pmic used in sdx65 platform to pm7250b.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
> Has this changed with a board revision? Was this wrong before?
>
> Need more explanation, and this definitely deserves a Fixes: tag.
Just went through the sdx65 pmics and found this mistake so updating here.
Although the validations were successful with the earlier pmic as well 
when originally pushed the patch.
Will add the fixes tag.

Thanks,
Rohit.
>
> Konrad
>>   arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
>> index 02d8d6e..fcf1c51 100644
>> --- a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
>> +++ b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
>> @@ -7,7 +7,7 @@
>>   #include "qcom-sdx65.dtsi"
>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>   #include <arm64/qcom/pmk8350.dtsi>
>> -#include <arm64/qcom/pm8150b.dtsi>
>> +#include <arm64/qcom/pm7250b.dtsi>
>>   #include "qcom-pmx65.dtsi"
>>   
>>   / {
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
index 02d8d6e..fcf1c51 100644
--- a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
+++ b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
@@ -7,7 +7,7 @@ 
 #include "qcom-sdx65.dtsi"
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 #include <arm64/qcom/pmk8350.dtsi>
-#include <arm64/qcom/pm8150b.dtsi>
+#include <arm64/qcom/pm7250b.dtsi>
 #include "qcom-pmx65.dtsi"
 
 / {