| Message ID | 1765c436635ecc05fc463524c1e7517297660728.1628617260.git.schowdhu@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add driver support for Data Capture and Compare Engine(DCC) for SM8150,SC7280,SC7180,SDM845 | expand |
On 8/10/21 12:54 PM, Souradeep Chowdhury wrote: > Documentation for Data Capture and Compare(DCC) device tree bindings > in yaml format. Even though Rob has already reviewed this... I think it would be nice if you gave these memory regions names, such as "config" for the first one and "sram" or something for the second one. It's a little more descriptive than just looking them up using their positions. -Alex > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Souradeep Chowdhury <schowdhu@codeaurora.org> > --- > .../devicetree/bindings/arm/msm/qcom,dcc.yaml | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > new file mode 100644 > index 0000000..b7a6619 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Data Capture and Compare > + > +maintainers: > + - Souradeep Chowdhury <schowdhu@codeaurora.org> > + > +description: | > + DCC (Data Capture and Compare) is a DMA engine which is used to save > + configuration data or system memory contents during catastrophic failure > + or SW trigger. DCC is used to capture and store data for debugging purpose > +properties: > + compatible: > + items: > + - enum: > + - qcom,sm8150-dcc > + - qcom,sc7280-dcc > + - qcom,sc7180-dcc > + - qcom,sdm845-dcc > + - const: qcom,dcc > + > + reg: > + items: > + - description: DCC base register region > + - description: DCC RAM base register region > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + dma@10a2000{ > + compatible = "qcom,sm8150-dcc","qcom,dcc"; > + reg = <0x010a2000 0x1000>, > + <0x010ad000 0x2000>; > + }; >
diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml new file mode 100644 index 0000000..b7a6619 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml @@ -0,0 +1,43 @@ +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Data Capture and Compare + +maintainers: + - Souradeep Chowdhury <schowdhu@codeaurora.org> + +description: | + DCC (Data Capture and Compare) is a DMA engine which is used to save + configuration data or system memory contents during catastrophic failure + or SW trigger. DCC is used to capture and store data for debugging purpose +properties: + compatible: + items: + - enum: + - qcom,sm8150-dcc + - qcom,sc7280-dcc + - qcom,sc7180-dcc + - qcom,sdm845-dcc + - const: qcom,dcc + + reg: + items: + - description: DCC base register region + - description: DCC RAM base register region + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + dma@10a2000{ + compatible = "qcom,sm8150-dcc","qcom,dcc"; + reg = <0x010a2000 0x1000>, + <0x010ad000 0x2000>; + };