From patchwork Wed Feb 15 04:51:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?J=2E_Neusch=C3=A4fer?= X-Patchwork-Id: 9573353 X-Patchwork-Delegate: agross@codeaurora.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5D944600F6 for ; Wed, 15 Feb 2017 04:53:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5679C2843D for ; Wed, 15 Feb 2017 04:53:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4B2CD2843F; Wed, 15 Feb 2017 04:53:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CED2B2843D for ; Wed, 15 Feb 2017 04:53:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751108AbdBOEx3 (ORCPT ); Tue, 14 Feb 2017 23:53:29 -0500 Received: from mout.gmx.net ([212.227.17.21]:63930 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267AbdBOEx2 (ORCPT ); Tue, 14 Feb 2017 23:53:28 -0500 Received: from latitude.space.aachen.ccc.de ([89.0.64.187]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Mhdex-1cywwy1Dfv-00MvEz; Wed, 15 Feb 2017 05:53:23 +0100 From: =?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= To: linux-arm-msm@vger.kernel.org Cc: devicetree@vger.kernel.org, Andy Gross , =?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= Subject: [PATCH 1/2] ARM: dts: msm8974: Hook up adsp-pil's xo clock Date: Wed, 15 Feb 2017 05:51:56 +0100 Message-Id: <20170215045157.11659-1-j.neuschaefer@gmx.net> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-Provags-ID: V03:K0:ao+wXRWg956xR1653pPmnBBThxaIZDJdy65q/dr6UCnBP4Cot5R LV1xWg/Vm5P9GYAISYfjHsiL60G7Po+0pDmeXDf+vfbJJ7RN8brEPUaOhytGlAEHj0SBukR ofzEJiAfKws4K6DyqDYhY5jO+AD9ZqqDRdDBslu+gu6QG70per6EiCJgsG8M3wMFNckj22+ NDQni/kcrcihOUDHAlrFQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:oMG+zDLb11k=:f8HNJ/rmRLMQA0bGM7RQyU NXY1dhhSvNgmnoYaNe8RM6w3JYa1cL/eEK0/eCZ4rtcLK0PVNX4m1uT5xPIRt0JjnwAc0R6aY C0n/6h+EtFE8CIak2zzLd9GvEfA+9Aym6qlsG5d0BvTD2yW6XexKzO+jxjfNnUbs98r8N7J69 a+QYXJ4O5G6BuuV2tA0w+u+Psrz02cTBM3oEXi2xRxcKoDneaIXCOwggQllYyJiSfWKl2R4kV Le1SM+Y8s4KeUESW2xLlewunGj2leOh8ubLKh+5Wnp9P1cdEpR18v8f7QQNCMrWN/gdib90Ab XF3cDtSi7ge9DyXgZ0vJUcxctnBpaRKVQzmLrs0KC5NTL25uJCHvzEmYgMJxFPc5rcyKJ5piD o6540KbEeGkZRH4NWNVteCTLpnPrX6rQgyOX85O5vE6ATX0fmbGvfSrRhKhEEjK50I01CpZfB q/dRq1hHcEizSI/3ERj/H6RoH9gdglpnMrjlybifRYxCBfCYys3MoIefQmyYqzLeofk8VE5cH DzhZv+N+z28tXp7m7Uwdt0+U7Rnb0oBckh0wDfBVBtQ6ezyfWGDISfXVCPPaYe/GDGoAX5DSS GuNDRiup2vXVvhNUPBSraBwTDLLFTc1CH7oFEnQBhyY7bvtLTbVudw8X743VazJwhbz6wc9tv 66dOYNJMAqh7g/mCORbwHaZFmD/o9zgqoOZXh0kBzQuzckYjnoh8bGS39UEnQdZwGGNgFgwjt t68it+JR0+Y1gMkEj/FomBW2gWgg4RlqQmVFPz6CB270GqXgMMBXOU+Px1ClL+AOybN85C7h9 x/Yod3a Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Without this patch (and with CONFIG_QCOM_ADSP_PIL), I get this error: [ 0.711529] qcom_adsp_pil adsp-pil: failed to get xo clock [ 0.711540] remoteproc remoteproc0: releasing adsp-pil With this patch, adsp-pil can initialize correctly. Signed-off-by: Jonathan Neuschäfer Reviewed-by: Bjorn Andersson --- NOTE: I don't know if I actually chose the right clock source. Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt suggests that adsp-pil's xo should be controlled by the RPM processor; Existing devicetrees and a recent patch to msm8996.dtsi use &xo_board, though: https://www.spinics.net/lists/linux-arm-msm/msg25711.html --- arch/arm/boot/dts/qcom-msm8974.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi index d3e1a61b8671..cccd8cba8872 100644 --- a/arch/arm/boot/dts/qcom-msm8974.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi @@ -250,6 +250,9 @@ cx-supply = <&pm8841_s2>; + clocks = <&xo_board>; + clock-names = "xo"; + memory-region = <&adsp_region>; qcom,smem-states = <&adsp_smp2p_out 0>;