From patchwork Fri Oct 6 10:57:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Archit Taneja X-Patchwork-Id: 9988981 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D2B3F603FA for ; Fri, 6 Oct 2017 10:57:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C3E3E28599 for ; Fri, 6 Oct 2017 10:57:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B892728C34; Fri, 6 Oct 2017 10:57:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6444028C9B for ; Fri, 6 Oct 2017 10:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbdJFK5P (ORCPT ); Fri, 6 Oct 2017 06:57:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:47756 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbdJFK5P (ORCPT ); Fri, 6 Oct 2017 06:57:15 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E5FE4609F7; Fri, 6 Oct 2017 10:57:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1507287434; bh=e0Y3w9fIJi3bhRYrYAtEgNB+dLisZHlgAeJr9CGPkNA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZmhUlE6IFwJvR9we4+ITXrWc/mKn/3C4hMFVh2hFf/Cqa2LPM+fBvY3B/tCsdnGGg ZfcnZ66u7n0hIPcDiUr51GTtDmKmicj1GmbagcZvzeXI/T/pqJb7o0oK5AFXuyp1Bw ypOCLpgsj96iV5oC0Uez4LCN/uF2qsBSbVUnBcbk= Received: from localhost (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: architt@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D7FE7601D1; Fri, 6 Oct 2017 10:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1507287434; bh=e0Y3w9fIJi3bhRYrYAtEgNB+dLisZHlgAeJr9CGPkNA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZmhUlE6IFwJvR9we4+ITXrWc/mKn/3C4hMFVh2hFf/Cqa2LPM+fBvY3B/tCsdnGGg ZfcnZ66u7n0hIPcDiUr51GTtDmKmicj1GmbagcZvzeXI/T/pqJb7o0oK5AFXuyp1Bw ypOCLpgsj96iV5oC0Uez4LCN/uF2qsBSbVUnBcbk= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D7FE7601D1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org From: Archit Taneja To: robdclark@gmail.com Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Archit Taneja Subject: [PATCH 1/2] drm/msm/dsi: Use correct pm_runtime_put variant during host_init Date: Fri, 6 Oct 2017 16:27:06 +0530 Message-Id: <20171006105707.20416-2-architt@codeaurora.org> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20171006105707.20416-1-architt@codeaurora.org> References: <20171006105707.20416-1-architt@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The DSI runtime PM suspend/resume callbacks check whether msm_host->cfg_hnd is non-NULL before trying to enable the bus clocks. This is done to accommodate early calls to these functions that may happen before the bus clocks are even initialized. Calling pm_runtime_put_autosuspend() in dsi_host_init() can result in racy behaviour since msm_host->cfg_hnd is set very soon after. If the suspend callback happens too late, we end up trying to disable clocks that were never enabled, resulting in a bunch of WARN_ON splats. Use pm_runtime_put_sync() so that the suspend callback is called immediately. Reported-by: Nicolas Dechesne Signed-off-by: Archit Taneja --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index dbb31a014419..deaf869374ea 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -248,7 +248,7 @@ static const struct msm_dsi_cfg_handler *dsi_get_config( clk_disable_unprepare(ahb_clk); disable_gdsc: regulator_disable(gdsc_reg); - pm_runtime_put_autosuspend(dev); + pm_runtime_put_sync(dev); put_clk: clk_put(ahb_clk); put_gdsc: