| Message ID | 20171207151942.5805-6-damien.riegel@savoirfairelinux.com (mailing list archive) |
|---|---|
| State | Deferred, archived |
| Delegated to: | Andy Gross |
| Headers | show |
On Thu 07 Dec 07:19 PST 2017, Damien Riegel wrote: > Also, it was using whitespaces for indentation on some lines, fix that > while moving it. > > Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com> Rather than extending single nodes like this I would prefer that we bring in the associated pmic node, by this we avoid just having a huge flat list of nodes. I.e. that we make this: &pm8916_1 { codec@f000 { status = "okay"; clocks = <&gcc GCC_CODEC_DIGCODEC_CLK>; clock-names = "mclk"; qcom,mbhc-vthreshold-low = <75 150 237 450 500>; qcom,mbhc-vthreshold-high = <75 150 237 450 500>; }; }; Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi index d4b35d81a282..981450f50e10 100644 --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi @@ -544,14 +544,6 @@ }; }; -&wcd_codec { - status = "okay"; - clocks = <&gcc GCC_CODEC_DIGCODEC_CLK>; - clock-names = "mclk"; - qcom,mbhc-vthreshold-low = <75 150 237 450 500>; - qcom,mbhc-vthreshold-high = <75 150 237 450 500>; -}; - &smd_rpm_regulators { vdd_l1_l2_l3-supply = <&pm8916_s3>; vdd_l5-supply = <&pm8916_s3>; @@ -671,3 +663,11 @@ regulator-max-microvolt = <3337000>; }; }; + +&wcd_codec { + status = "okay"; + clocks = <&gcc GCC_CODEC_DIGCODEC_CLK>; + clock-names = "mclk"; + qcom,mbhc-vthreshold-low = <75 150 237 450 500>; + qcom,mbhc-vthreshold-high = <75 150 237 450 500>; +};
Also, it was using whitespaces for indentation on some lines, fix that while moving it. Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com> --- arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)