| Message ID | 20180425144631.19731-1-sibis@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Wed 25 Apr 07:46 PDT 2018, Sibi Sankar wrote: > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 9be763da0664..bea985045759 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -21,6 +21,27 @@ > reg = <0 0x80000000 0 0>; > }; > > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + memory@85fc0000 { > + reg = <0 0x85fc0000 0 0x40000>; The region 0x85fe0000 + 0x20000 seems to be command db, which should be described on its own. So please reduce the size to 0x20000. > + no-map; > + }; > + > + smem_mem: smem-mem@86000000 { smem_mem: memory@86000000 ? > + reg = <0x0 0x86000000 0x0 0x200000>; > + no-map; > + }; > + > + memory@86000000 { memory@86200000 > + reg = <0 0x86200000 0 0x2d00000>; > + no-map; > + }; > + }; > + The rest looks good. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Bjorn, Thanks for the review On 04/26/2018 03:36 AM, Bjorn Andersson wrote: > On Wed 25 Apr 07:46 PDT 2018, Sibi Sankar wrote: >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> index 9be763da0664..bea985045759 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> @@ -21,6 +21,27 @@ >> reg = <0 0x80000000 0 0>; >> }; >> >> + reserved-memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + >> + memory@85fc0000 { >> + reg = <0 0x85fc0000 0 0x40000>; > > The region 0x85fe0000 + 0x20000 seems to be command db, which should be > described on its own. So please reduce the size to 0x20000. > >> + no-map; >> + }; >> + >> + smem_mem: smem-mem@86000000 { > > smem_mem: memory@86000000 ? Should I update kernel docs as well to say all nodes should have memory has default name? Just followed what was done in msm8916 and msm8996. > >> + reg = <0x0 0x86000000 0x0 0x200000>; >> + no-map; >> + }; >> + >> + memory@86000000 { > > memory@86200000 > >> + reg = <0 0x86200000 0 0x2d00000>; >> + no-map; >> + }; >> + }; >> + > > The rest looks good. > > Regards, > Bjorn >
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 9be763da0664..bea985045759 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -21,6 +21,27 @@ reg = <0 0x80000000 0 0>; }; + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + memory@85fc0000 { + reg = <0 0x85fc0000 0 0x40000>; + no-map; + }; + + smem_mem: smem-mem@86000000 { + reg = <0x0 0x86000000 0x0 0x200000>; + no-map; + }; + + memory@86000000 { + reg = <0 0x86200000 0 0x2d00000>; + no-map; + }; + }; + cpus { #address-cells = <2>; #size-cells = <0>; @@ -147,6 +168,18 @@ }; }; + tcsr_mutex: hwlock { + compatible = "qcom,tcsr-mutex"; + syscon = <&tcsr_mutex_regs 0 0x1000>; + #hwlock-cells = <1>; + }; + + smem { + compatible = "qcom,smem"; + memory-region = <&smem_mem>; + hwlocks = <&tcsr_mutex 3>; + }; + psci { compatible = "arm,psci-1.0"; method = "smc"; @@ -339,6 +372,11 @@ }; }; + tcsr_mutex_regs: syscon@1f40000 { + compatible = "syscon"; + reg = <0x1f40000 0x40000>; + }; + apss_shared: mailbox@17990000 { compatible = "qcom,sdm845-apss-shared"; reg = <0x17990000 0x1000>;
Add all the necessary dt nodes to support SMEM driver on SDM845. It also adds the required memory carveouts so that the kernel does not access memory that is in use. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- This patch depends on: https://patchwork.kernel.org/patch/10276419/ https://patchwork.kernel.org/patch/10363361/ arch/arm64/boot/dts/qcom/sdm845.dtsi | 38 ++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+)