diff mbox series

[v6,6/9] soc: qcom: Remove depends on OF from QCOM_RPMH

Message ID 20180829075724.9095-7-niklas.cassel@linaro.org (mailing list archive)
State Accepted, archived
Delegated to: Andy Gross
Headers show
Series soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs | expand

Commit Message

Niklas Cassel Aug. 29, 2018, 7:57 a.m. UTC 
QCOM_RPHM already selects ARM64, which always selects OF.

Additionally, the rpmh driver only uses linux/of.h, which has dummy
definitions for all functions, in order for code to to be able to
build without CONFIG_OF set.

Remove the superfluous depends on OF.

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
 drivers/soc/qcom/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bjorn Andersson Sept. 3, 2018, 7:24 p.m. UTC | #1 
On Wed 29 Aug 00:57 PDT 2018, Niklas Cassel wrote:

> QCOM_RPHM already selects ARM64, which always selects OF.

Nit. "already depends on ARM64"

> 
> Additionally, the rpmh driver only uses linux/of.h, which has dummy
> definitions for all functions, in order for code to to be able to
> build without CONFIG_OF set.
> 
> Remove the superfluous depends on OF.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Regards,
Bjorn

> ---
>  drivers/soc/qcom/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index ac657164a136..cf4ece232897 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -94,7 +94,7 @@ config QCOM_RMTFS_MEM
>  
>  config QCOM_RPMH
>  	bool "Qualcomm RPM-Hardened (RPMH) Communication"
> -	depends on ARCH_QCOM && ARM64 && OF || COMPILE_TEST
> +	depends on ARCH_QCOM && ARM64 || COMPILE_TEST
>  	help
>  	  Support for communication with the hardened-RPM blocks in
>  	  Qualcomm Technologies Inc (QTI) SoCs. RPMH communication uses an
> -- 
> 2.17.1
>
diff mbox series

Patch

diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index ac657164a136..cf4ece232897 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -94,7 +94,7 @@  config QCOM_RMTFS_MEM
 
 config QCOM_RPMH
 	bool "Qualcomm RPM-Hardened (RPMH) Communication"
-	depends on ARCH_QCOM && ARM64 && OF || COMPILE_TEST
+	depends on ARCH_QCOM && ARM64 || COMPILE_TEST
 	help
 	  Support for communication with the hardened-RPM blocks in
 	  Qualcomm Technologies Inc (QTI) SoCs. RPMH communication uses an