| Message ID | 20181026122542.4714-1-sibis@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: qcom: sdm845: Add SCM DT node | expand |
On Fri 26 Oct 05:25 PDT 2018, Sibi Sankar wrote: > Add SCM DT node to enable SCM functionality on SDM845. > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index b72bdb0a31a5..fad22acfda4d 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -221,6 +221,12 @@ > }; > }; > > + firmware { > + scm { > + compatible = "qcom,scm-sdm845", "qcom,scm"; > + }; > + }; > + > tcsr_mutex: hwlock { > compatible = "qcom,tcsr-mutex"; > syscon = <&tcsr_mutex_regs 0 0x1000>; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
Hi Sibi, On 10/26/2018 03:25 PM, Sibi Sankar wrote: > Add SCM DT node to enable SCM functionality on SDM845. > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index b72bdb0a31a5..fad22acfda4d 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -221,6 +221,12 @@ > }; > }; > > + firmware { > + scm { > + compatible = "qcom,scm-sdm845", "qcom,scm"; > + }; > + }; What will happen if the platform is without tz firmware? I'd move this DT node in sdm845-mtp.dts or at least make it status = disabled.
Hi Stan, Thanks for the review! On 2018-10-29 15:02, Stanimir Varbanov wrote: > Hi Sibi, > > On 10/26/2018 03:25 PM, Sibi Sankar wrote: >> Add SCM DT node to enable SCM functionality on SDM845. >> >> Signed-off-by: Sibi Sankar <sibis@codeaurora.org> >> --- >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi >> b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> index b72bdb0a31a5..fad22acfda4d 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> @@ -221,6 +221,12 @@ >> }; >> }; >> >> + firmware { >> + scm { >> + compatible = "qcom,scm-sdm845", "qcom,scm"; >> + }; >> + }; > > What will happen if the platform is without tz firmware? I'd move this > DT node in sdm845-mtp.dts or at least make it status = disabled. Even in the absence of tz firmware, ATF is expected to implement the necessary handlers for the SMC calls so I don't think it is necessary to keep it disabled.
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index b72bdb0a31a5..fad22acfda4d 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -221,6 +221,12 @@ }; }; + firmware { + scm { + compatible = "qcom,scm-sdm845", "qcom,scm"; + }; + }; + tcsr_mutex: hwlock { compatible = "qcom,tcsr-mutex"; syscon = <&tcsr_mutex_regs 0 0x1000>;
Add SCM DT node to enable SCM functionality on SDM845. Signed-off-by: Sibi Sankar <sibis@codeaurora.org> --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)