From patchwork Wed Nov 14 22:24:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Marek X-Patchwork-Id: 10683197 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AD66813B5 for ; Wed, 14 Nov 2018 22:28:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A027727F85 for ; Wed, 14 Nov 2018 22:28:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 945642BE9E; Wed, 14 Nov 2018 22:28:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2262227F85 for ; Wed, 14 Nov 2018 22:28:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389423AbeKOIdW (ORCPT ); Thu, 15 Nov 2018 03:33:22 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:46556 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387528AbeKOIdW (ORCPT ); Thu, 15 Nov 2018 03:33:22 -0500 Received: by mail-qk1-f196.google.com with SMTP id q1so28779278qkf.13 for ; Wed, 14 Nov 2018 14:28:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marek-ca.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/bfKcwnq24c7GQi8+QH2x+kJfYvWUyEGaldZxXhKaVQ=; b=QKZ5pI1bCT7/DOJNRodcpFW2+FjFGAvbRmPyw+gmRGvrGv8nVQINYAN2zniAefu7ci zIpLKh8Sh05TTfEV/TlSEqfDg8bCdFo7lNcSrMua2Cm6PGS7U6CTtpeo+Q20AJ6zEQt6 N20f80YcJetdTymcNAZPv/mUuqCImxBRr1zG7HcWMr/bCChnk8KtmujailTeuA/6WSec 1i2RolnaFzIFme/fkHhecYkXFj8zRkuVI9RupqwyNghNlyOGb+gzpRYJK4mgmlkfy+o+ GfyBOtb0hdQdBTXGaUY/pViYYz2spMW5AXccJcs1hPzt1ipjsveObAD7ppngTQgqO7Qk RF9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/bfKcwnq24c7GQi8+QH2x+kJfYvWUyEGaldZxXhKaVQ=; b=H9QhvnYgqwEMOk7sCqv6XfKwY5GHEUSQ/HxM9y6Re6Do18lEZNtFFiTzSyWWDWSw+3 qe5bguzYurVHejV9M5CWt9UFdSPhCXMDzb0+mB196ScXebVP1/t4h4vhSYo1fRlKRP8q Bkc2wynh0UJnrvdYB0IOU+oV8nu5EqvMuGyRGWvVNyqHO/i9/kPcIwfBlLsddhPN8MfW mMVdUuzwgigt0uunDcrfa/5sNN5I8i+bU5rsvs14Ip0W7U8Rluyz58EVX4Gy/OmuUKTV xSHq6OeicE4P7tCTfbzhHdwuCDwr7qgDWuyk2VemJQzaDkwH4F7bkgwwgE3qG+3tn09b c0Sw== X-Gm-Message-State: AGRZ1gJjWXe12Qp3Z7joaAyoWyyD1DZopZb5vYinqStYTkg52q4/KIXN 8/1NsSrw0iCJN2lcy04rTrdC6w== X-Google-Smtp-Source: AJdET5epL6+ReeWFys4n1HAC8S4qwmwIIA3xO6f9HkBmSqPYapFnJDyUgIc+8U2r19cShRkqDkE6Xg== X-Received: by 2002:a37:6005:: with SMTP id u5mr3457068qkb.219.1542234496099; Wed, 14 Nov 2018 14:28:16 -0800 (PST) Received: from localhost.localdomain (modemcable014.247-57-74.mc.videotron.ca. [74.57.247.14]) by smtp.gmail.com with ESMTPSA id 24sm24067595qkp.65.2018.11.14.14.28.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 14:28:15 -0800 (PST) From: Jonathan Marek To: freedreno@lists.freedesktop.org Cc: Rob Clark , David Airlie , linux-arm-msm@vger.kernel.org (open list:DRM DRIVER FOR MSM ADRENO GPU), dri-devel@lists.freedesktop.org (open list:DRM DRIVER FOR MSM ADRENO GPU), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 9/9] drm/msm: set priv->kms to NULL before uninit Date: Wed, 14 Nov 2018 17:24:16 -0500 Message-Id: <20181114222418.15960-9-jonathan@marek.ca> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181114222418.15960-1-jonathan@marek.ca> References: <20181114222418.15960-1-jonathan@marek.ca> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP otherwise, priv->kms is non-NULL and msm_drm_uninit will cause a panic. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/msm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index bda23011494d..94b0593f6090 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -533,6 +533,7 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv) */ dev_err(dev, "failed to load kms\n"); ret = PTR_ERR(kms); + priv->kms = NULL; goto err_msm_uninit; }